From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.bugs Subject: bug#36861: 27.0.50; display-fill-column-indicator-mode in log-edit-mode Date: Tue, 6 Aug 2019 19:51:46 +0200 Message-ID: <20190806175146.fpgzslvlaydpih7k@Ergus> References: <875znjntfe.fsf@mail.linkov.net> <83mugvhr66.fsf@gnu.org> <871ry6rksu.fsf@mail.linkov.net> <83zhksexvx.fsf@gnu.org> <87sgqhricg.fsf@mail.linkov.net> <87o914u65x.fsf@mail.linkov.net> <04C790C7-2667-4480-BDC9-BE838D307A74@aol.com> <837e7qcpbj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="175327"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: 36861@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 06 19:53:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hv3e1-000jSF-1l for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Aug 2019 19:53:09 +0200 Original-Received: from localhost ([::1]:35362 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hv3dz-00050U-Gt for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Aug 2019 13:53:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59117) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hv3dv-00050M-Ex for bug-gnu-emacs@gnu.org; Tue, 06 Aug 2019 13:53:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hv3du-0000Hu-Cy for bug-gnu-emacs@gnu.org; Tue, 06 Aug 2019 13:53:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57139) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hv3du-0000Hp-9m for bug-gnu-emacs@gnu.org; Tue, 06 Aug 2019 13:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hv3du-0003CT-6D for bug-gnu-emacs@gnu.org; Tue, 06 Aug 2019 13:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ergus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Aug 2019 17:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36861 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36861-submit@debbugs.gnu.org id=B36861.156511392412226 (code B ref 36861); Tue, 06 Aug 2019 17:53:01 +0000 Original-Received: (at 36861) by debbugs.gnu.org; 6 Aug 2019 17:52:04 +0000 Original-Received: from localhost ([127.0.0.1]:37727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hv3cx-0003B7-FE for submit@debbugs.gnu.org; Tue, 06 Aug 2019 13:52:04 -0400 Original-Received: from sonic310-11.consmr.mail.ir2.yahoo.com ([77.238.177.32]:37224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hv3cv-0003Ac-IM for 36861@debbugs.gnu.org; Tue, 06 Aug 2019 13:52:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1565113914; bh=uOgKKxfRwC9YPlWi3SsSgNsJCD68QUZPhbvsMW7VRvs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=dTgKwz1GsniK7VkcKLdGvUNJhnXiOtngNTLKJ8AXt9LP90MrznjEh52j303//zMqIYD3kpQ4fiT4Ywm7Hy9fKIYHkX1t7UnWvncRhrMKjYuJgoXf6qzfOmqID0uKpZj380NBPIS5Ed/ela4jco6XrurAgUjnQmmbdABba8jkDx4o+C9skZ05fax/D6ZFKI2uXnC2Q+yj9l92J40sSKK3WkdHU8p4AxFF82Av9wYybZm4fVHC+j1yMqSWbBhlipC6cNwFkdeBVCPGkGgX7oJm1SAexIZaVaf4fiDpv0DN4dDRXSyezrGJojs9BRKCrQVjB7zLtR/eIAqtoneHZTUo0Q== X-YMail-OSG: buXSF.YVM1kHS2Y_OybeWIckfCIBKY59YSWUY2sHLtgUTGJ7EqLeaoLpyvqLcCc QlOCh6MsjlbpVXwxneriYUJYFVttcnzgF57O5.odWDo4hs2bs23yWigF973JyW5YXN8EuWilUWcu 8RZ1.4XUOT4ez_mO2Ayg1Hu9XGnvUNnCJai3E.eamBNm75ywRh8tqHcwNtXF2pdsBecCXViaDALN GZFgRJdcYAQ7hgsVdqwTxk8QaMviKYGgIHc0B0kLWGJsV2Ji893QTSCrIQZFIHRTwdhmHCxHjtlW d0MUuk8N9EnhC4Xy1g2Bywk4spRwbKsfQSAm9GBrra55xEG98k1mbCPXDiGx4IiADVuSSQZxVi5m 2vO_aVELwvdTtcNwD4OesMn1Yx0Zpu5OerBETNWDTn6_Rz0_Ry.xItiXAibk38clbYj1s3HWDWD2 MvUMSVsfGS3jLT6D.q.sjgam5gewzNT6pBj_I.FlNw_cODDW2X6fxosJl.a1KNLlq6kyEhW7iSoW C12Yz4ck.qNDHl_KvtDCyri_HLaS6gIpbdDBdif7auGg2d7clBJegUyp20hVIsYgAP8gzDp3XymQ bt0x_.AdFjRMZe.xUiBWE8qhqG14gxJaVwNxUnaua1EOAFYCv_y7WXUV_fjCS.EuEgpkB1So8R0K LDKMA9pTYeSENd4yFHjaqP1V7s26rbbCa_0liLzWFcOu.L42M8.uUr_3BzUI.AscNeWxOLCgZWaY lbFJicnCxYgCe2iK1I8f1uZJbkZRFqrU8ajsP0N_5syiBaWfjqpGtdpeNSY4XpoQ45Ba43waiFOY JPifi3tsCfWnSpH8Qp9lIQzceXocbYNApGzFj9y4Sx Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Tue, 6 Aug 2019 17:51:54 +0000 Original-Received: by smtp404.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID a2ed279da6699d48ba0a7e645d050761; Tue, 06 Aug 2019 17:51:49 +0000 (UTC) Content-Disposition: inline In-Reply-To: <837e7qcpbj.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164689 Archived-At: On Tue, Aug 06, 2019 at 05:59:28PM +0300, Eli Zaretskii wrote: >> Date: Sun, 04 Aug 2019 22:30:05 +0200 >> CC: Eli Zaretskii ,36861@debbugs.gnu.org >> From: Ergus >> >> Dfci was not designed to be used in this way, and the mode initialization actually sets the character, but in the >> future it could make many other dynamic tests/checks if needed. So I don't think we should modify it to work >> the other way you suggest, because for menit is not general enough. But I will follow the Eli's suggestions in >> this aspects more than my own opinion. >> Any way, if you want to use the mode in this way (for now) you can/need to set the >> display-fill-column-indicator-character to your desired value and it should work as it is now. But I can't promise >> that it will work the same way in the future. >> But again, probably Eli will suggest a better solution for your use case. > >I don't think I understand the problem. Why doesn't just setting the >characters and the mode variable work as expected? AFAIU, one needs >to call the mode function only if one wants Emacs to deduce the >indicator character automatically. Hi: It should work as you say. But the default value for display-fill-column-indicator-character is nil until the mode function is executed (at least once). I think that what they want is display-fill-column-indicator-character to be non-nil without initialization; which we cannot set without some checks. Probably I'll need to reword the doc string about the default value to specify that the value is really nil and it is initialized to the other non-nil values in the mode function. Does it makes sense?