From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.bugs Subject: bug#36858: 27.0.50; display bugs with display-fill-column-indicator-mode Date: Tue, 6 Aug 2019 01:54:05 +0200 Message-ID: <20190805235403.o4lvxzbggm3cnk6n@Ergus> References: <83wofwexkr.fsf@gnu.org> <9C122236-898E-4D49-A117-CDF062360224@aol.com> <83r263g4w5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="808"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: 36858@debbugs.gnu.org, rotim.davor@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 06 01:55:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1humon-0018JE-PG for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Aug 2019 01:55:09 +0200 Original-Received: from localhost ([::1]:57532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1humom-0002aV-1H for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Aug 2019 19:55:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60418) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1humoh-0002aO-6o for bug-gnu-emacs@gnu.org; Mon, 05 Aug 2019 19:55:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1humog-0003sU-0A for bug-gnu-emacs@gnu.org; Mon, 05 Aug 2019 19:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55445) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1humof-0003sQ-T3 for bug-gnu-emacs@gnu.org; Mon, 05 Aug 2019 19:55:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1humof-0002YO-PV for bug-gnu-emacs@gnu.org; Mon, 05 Aug 2019 19:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ergus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Aug 2019 23:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36858 X-GNU-PR-Package: emacs Original-Received: via spool by 36858-submit@debbugs.gnu.org id=B36858.15650492639756 (code B ref 36858); Mon, 05 Aug 2019 23:55:01 +0000 Original-Received: (at 36858) by debbugs.gnu.org; 5 Aug 2019 23:54:23 +0000 Original-Received: from localhost ([127.0.0.1]:36033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1humo3-0002XI-Ew for submit@debbugs.gnu.org; Mon, 05 Aug 2019 19:54:23 -0400 Original-Received: from sonic302-21.consmr.mail.ir2.yahoo.com ([87.248.110.84]:40345) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1humo0-0002X1-Sc for 36858@debbugs.gnu.org; Mon, 05 Aug 2019 19:54:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1565049254; bh=Runkl71W4kB9wW3/WV8hLrxngEFIP0GRqO6yM1Xnogk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=XjG0rG9Uzwf7l7HxkDCOBz2uBPtj0YkoCDBXPuYWT6mjetw4iQlayMevUsA6D+AYW9FIr3TwFzjrvpQEMeFkOZfwHRtTxPPnRUn5GF1tQhgknmCUrOWl2s8H4wIF2s9yDwWFSBxMbX91Me/T5XSsDjBCBKwF9uhy3aCYotBmmZ8gLUg4HBRjTTqycMBtxmrj30G+PJzc+5Yqmtxbp2J5AkrvS7lb8TT7aqkRuLZ34R414O0Uh+MmjrbHTa8P2AfM1Qwheva2YYcdgkWT3AFsiJlmJm859y46yIq6dTvaMNcevn9wj9+aZmk0qUr2a2cwV4jYbNB+J0pYiCCe8UxyWQ== X-YMail-OSG: A3AzwykVM1m92.6EzWCekkMv78CZ96qbVEt.KEBOriJLLifJSC7nShgTd.g2y6u xU9MENaWG3HTwgJ89AVYMUbcqlpo6dYyejcyHKgGnZN.6L4g22uIRUMKR2Mm6adVQhqBbOXVwHO0 5s5fB.jbGKeo1qfvnGkPgFJXYmfHgntjSxdruEFST9HiVXstOt77_J_UXNN0QRvC9RidGLf_FvwE _52UWoVsMVA6Izk37.mQLPrTuzteA1oK2VwfBBW4mhQeUAIBtWZ.7amjMRtmqmDH5WhZNIW7O0iX vhqA9a2yfOEQfkNDDwcs9PlDTs_SKMK1fZZ0P0rGUYA3lJd1YVSmyxZGEUZbcDDOT3paOQJwY6d0 xvJj0RQYmnjAoiYBTdih9ZvwYEq6xfEM8D0LcIY6D0UPzYmHpaivATKkGUFc_za_c3.y8d8uZA0G ti0bbBXQ3rbDgQkps9twmXPFuw2w5vAiZV4e4dnYnFWcA9gwPbkAZ00949Svq0_jEK09JtmtDU3k 5_OCMij2q5XDB3ZtlmRvViH2jtApaYkpRK_ijSA_81pp9i1Dey3b6LqYSiqMxiRCRhByzGUsLhYY pvoJo19NcAh2YEgUPbZjpqAcNrpkVYUSeXBRRRlMeC8sRnFsjk7V4M7GgDT3EZPZW.pf72N7Y5O_ rQm7Iwk34eXt_rhfwpphxb91Kah_qC07dbeY8JATxu.OHBqUxJL1EMxTtVubc_PNVTp96SlgTMSQ ohvE_JsIvuWFM1VS1Q1EsiH3tRT8Sa2MBnToxUkJaxZK5b0Ydwvgyv0Fp2qjhogs0ZrtW7cZnGsW sXaWmn090jZ93gmfUvr44aOGRI7NwPDbo87K6vuRc. Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ir2.yahoo.com with HTTP; Mon, 5 Aug 2019 23:54:14 +0000 Original-Received: by smtp413.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 0cc062197d54bb9635704e20252a3533; Mon, 05 Aug 2019 23:54:10 +0000 (UTC) Content-Disposition: inline In-Reply-To: <83r263g4w5.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164661 Archived-At: Hi Eli: There are two different behaviors for tui and gui in extend_face_to_end_of_line. In gui the face is automatically extended. It is unclear for me what face it is using, because this has to do with the issue that in X the last character is extended automatically, so no loop or stretch_glyph is needed. But it seems to be using the default face because the underline is not extend after the text and the space for the cursor. ON the other hand, for the tui there is if (it->glyph_row->ends_at_zv_p) it->face_id = default_face->id; else it->face_id = face->id; which extends the face using the face of the last glyph. this extends the underline until the end of the row; but it is different to the gui behavior, so it is incoherent. Whats the right behavior in the general case? Extend the underline the whole line or fit it to the text? If it is the second whats the right face to fill until the end of the row Does the same policy applies to append_space_for_newline? Because now there is an extra underlined space after the text. I am just waiting for your recommendation in order to submit a fix for this issue. Thanks in advance Esgus. On Fri, Aug 02, 2019 at 02:53:30PM +0300, Eli Zaretskii wrote: >> Date: Fri, 02 Aug 2019 12:25:15 +0200 >> CC: 36858@debbugs.gnu.org,Davor Rotim >> From: Ergus >> >> I will give a look the next week. > >Thanks. > >> The org mode issue seems more or less easy to fix. >> >> But for the company-mode I need to check if there is a condition to distinguish normal text from the company >> popups. From the display engine. Else we could consider to extend the line always until the end of the >> screen... If that is possible... > >The glyph rows generated by Company should all have their ends_at_zv_p >flag set in this use case, AFAIR. Maybe this will help.