all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 36832@debbugs.gnu.org
Subject: bug#36832: Supply option to suppress scrolling in compilation mode buffers.
Date: Tue, 30 Jul 2019 19:32:35 +0000	[thread overview]
Message-ID: <20190730193235.GE5427@ACM> (raw)
In-Reply-To: <83pnlrijiu.fsf@gnu.org>

Hello, Eli.

On Tue, Jul 30, 2019 at 19:17:45 +0300, Eli Zaretskii wrote:
> > Date: Tue, 30 Jul 2019 15:59:37 +0000
> > Cc: 36832@debbugs.gnu.org
> > From: Alan Mackenzie <acm@muc.de>

> > > With this setting, how would the user know which error line is the
> > > "current" one, whose source is displayed above?

> > Either by remembering it (she's just hit <CR> on it, after all), or by
> > doing C-x o to move to that line, then C-x o to move back again.

> > The new option is intended for users who find being reminded of the
> > current error line less important than being able to see the error lines
> > above the current one "in context".

> > A possible modification would be to highlight the current line in the
> > compilation mode buffer, but that's beginning to feel like a lot of work
> > for a feature which might not really be wanted by anybody.

> If this feature will not be wanted by anybody, why are we discussing
> its addition?

To attempt to guess whether anybody will want it.

> I'm okay with adding the value you suggest if there will be some means
> for delineating the current error line, either automatically when the
> value t is in use or by an independent optional feature.

I suppose we could put something like ">" or "=>" in column 0 of the
pertinent line, the way that edebug does, when there's no fringe.

> > This is an option, a non-default option, one which nobody is forced to
> > use.  Having hacked it up a couple of days ago, I find it less stressful
> > to use than the setting where the buffer jumps when I hit <CR> on it.

> I understand, but I don't want us to introduce options that look like
> we didn't think them through.

OK.

The current code does two things, sometimes, on <CR> being hit: (i) it
puts an indicator into the fringe; (ii) it scrolls the compile mode
window upwards, the pertinent line moving either to the top, or to a
specified window line.

Unfortunately, the code which does these things seems to be fragmented,
and there is just one user option to control (i) and (ii) above.

One solution would be always to mark to the line in the compile mode
window, whether by an indicator in the fringe or a ">" or "=>" at column
0.  Then only scroll the compile mode window when the user has explicitly
requested this by the user option compilation-context-lines.

Why do these little things so often turn out to be so complicated?  ;-(

-- 
Alan Mackenzie (Nuremberg, Germany).





  parent reply	other threads:[~2019-07-30 19:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-28 20:32 bug#36832: Supply option to suppress scrolling in compilation mode buffers Alan Mackenzie
2019-07-30 15:14 ` Eli Zaretskii
2019-07-30 15:59   ` Alan Mackenzie
2019-07-30 16:17     ` Eli Zaretskii
2019-07-30 19:20       ` Juri Linkov
2019-07-31 14:20         ` Eli Zaretskii
2019-07-30 19:32       ` Alan Mackenzie [this message]
2019-07-31 14:21         ` Eli Zaretskii
2019-08-25 10:32           ` Alan Mackenzie
2019-09-01 21:50 ` Mattias Engdegård
     [not found] ` <handler.36832.B.156434595120203.ack@debbugs.gnu.org>
2019-09-03 17:44   ` Alan Mackenzie
2019-09-04 12:41 ` Mattias Engdegård
2019-09-05 17:50   ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190730193235.GE5427@ACM \
    --to=acm@muc.de \
    --cc=36832@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.