all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: npostavs@gmail.com, emacs-devel@gnu.org
Subject: Re: Elisp manual: Note that created faces cannot be removed.
Date: Mon, 22 Jul 2019 15:18:48 +0000	[thread overview]
Message-ID: <20190722151847.GB5933@ACM> (raw)
In-Reply-To: <83ef2iqgu3.fsf@gnu.org>

Hello, Eli.

On Mon, Jul 22, 2019 at 17:33:40 +0300, Eli Zaretskii wrote:
> > Date: Mon, 22 Jul 2019 10:02:09 +0000
> > Cc: emacs-devel@gnu.org, Noam Postavsky <npostavs@gmail.com>
> > From: Alan Mackenzie <acm@muc.de>

> > Sorry to go on about this (trivial) point, but I'm not happy about my
> > proposed text any more.  With the mechanism pointed out by Noam, it
> > clearly _is_ possible to undefine a face, but it's unsafe.

> > So, using "undefine" rather than "remove" (suggested to me by private
> > email), and inserting the word "safely", I now propose this:

> > diff --git a/doc/lispref/display.texi b/doc/lispref/display.texi
> > index 276d60b21a..4ae0bba723 100644
> > --- a/doc/lispref/display.texi
> > +++ b/doc/lispref/display.texi
> > @@ -2476,6 +2476,10 @@ Defining Faces
> >  usual procedure is to define a face with @code{defface}, and then use
> >  its name directly.

> > +@cindex face (non-removability of)
> > +Note that once you have defined a face (usually with @code{defface}),
> > +you cannot later undefine this face safely, except by restarting Emacs.

> That's fine with me, but unlike you, I don't really see a difference:
> for the reader of the ELisp manual "cannot undefine safely" and
> "cannot remove" are identical for all practical purposes.  Moreover,
> "undefine a face" is not really well-defined.

Well, I've just committed the change.  Maybe there's only a slight
difference between "cannot remove" and "cannot undefine safely", but
there actually is a difference - the latter is closer to the truth.

"undefine a face" might not be well-defined, but since we can't do it
anyway (at least, not safely), that surely doesn't matter too much.
Stefan has suggested we hack such a facility, but ...  Well somebody
would have to do it, and the benefit of it would not be great.

Anyway, I think we've talked around this enough already, so let's just
close the conversation.  :-)

-- 
Alan Mackenzie (Nuremberg, Germany).



      reply	other threads:[~2019-07-22 15:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-20 18:37 Elisp manual: Note that created faces cannot be removed Alan Mackenzie
2019-07-20 18:39 ` Eli Zaretskii
2019-07-20 18:41   ` Eli Zaretskii
2019-07-20 20:26     ` Alan Mackenzie
2019-07-21  2:28       ` Eli Zaretskii
2019-07-22 10:02         ` Alan Mackenzie
2019-07-22 14:33           ` Eli Zaretskii
2019-07-22 15:18             ` Alan Mackenzie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190722151847.GB5933@ACM \
    --to=acm@muc.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.