From: Alan Third <alan@idiocy.org>
To: Keith David Bershatsky <esq@lawlist.com>
Cc: emacs-devel@gnu.org
Subject: Re: -getRed:green:blue:alpha: not defined for the NSColor
Date: Sun, 14 Jul 2019 11:24:11 +0100 [thread overview]
Message-ID: <20190714102411.GA11787@breton.holly.idiocy.org> (raw)
In-Reply-To: <m2r26toley.wl%esq@lawlist.com>
On Sat, Jul 13, 2019 at 11:10:29AM -0700, Keith David Bershatsky wrote:
> The following change made with
> 9624f609493da7c08016ba00d6895bad0fe26a0e is what prevents Emacs on
> OSX 10.6.8 from working. Would it be possible for the Emacs team to
> put in a condition that permits Emacs on OSX 10.6 to use the two
> lines of code that were removed? [I do not know what is the earliest
> version of OSX that can make use of two new lines of code without
> breaking.]
Hi Keith, thanks for tracking this down. Can you try this change:
modified src/nsimage.m
@@ -310,6 +310,6 @@ - (instancetype)setXBMColor: (NSColor *)color
return self;
- if ([color colorSpace] != [NSColorSpace deviceRGBColorSpace])
- rgbColor = [color colorUsingColorSpace:[NSColorSpace deviceRGBColorSpace]];
+ if ([color colorSpace] != [NSColorSpace genericRGBColorSpace])
+ rgbColor = [color colorUsingColorSpace:[NSColorSpace genericRGBColorSpace]];
else
rgbColor = color;
If that doesn’t work I’ll make your suggested change.
--
Alan Third
next prev parent reply other threads:[~2019-07-14 10:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-13 18:10 -getRed:green:blue:alpha: not defined for the NSColor Keith David Bershatsky
2019-07-14 10:24 ` Alan Third [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-07-14 16:12 Keith David Bershatsky
2019-07-14 16:42 ` Alan Third
2019-07-13 4:48 Keith David Bershatsky
2019-07-12 21:52 Keith David Bershatsky
2019-07-12 23:56 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190714102411.GA11787@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=emacs-devel@gnu.org \
--cc=esq@lawlist.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.