From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: highlight-indent-guides in display engine Date: Fri, 12 Jul 2019 11:58:43 +0200 Message-ID: <20190712095841.qn5rlgxxgqjllz4k@Ergus> References: <20190706211716.semd47fksgh66rug@Ergus> <83sgrh7uol.fsf@gnu.org> <20190711190651.b2kg64fg2ole2i5d@Ergus> <83zhlk2xiu.fsf@gnu.org> <20190712002127.6tm3scplu73syinp@Ergus> <83tvbr3fl7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="131120"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 12 11:59:03 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlsKT-000Xuf-8E for ged-emacs-devel@m.gmane.org; Fri, 12 Jul 2019 11:59:01 +0200 Original-Received: from localhost ([::1]:47832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlsKS-0007gF-Aj for ged-emacs-devel@m.gmane.org; Fri, 12 Jul 2019 05:59:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51045) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlsKP-0007g8-MU for emacs-devel@gnu.org; Fri, 12 Jul 2019 05:58:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hlsKO-0004hz-Da for emacs-devel@gnu.org; Fri, 12 Jul 2019 05:58:57 -0400 Original-Received: from sonic304-21.consmr.mail.ir2.yahoo.com ([77.238.179.146]:39975) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hlsKO-0004fT-1S for emacs-devel@gnu.org; Fri, 12 Jul 2019 05:58:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1562925534; bh=rVuRuB3rMohtuzGnNnd7M/UthiQ3ggpCd8kaUi0ulcU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=nT5m5K1s0vbbOM23k216rEJ5KEu3yhSXG0QJ66Y0Yp1ILs6aCHdEBC+dDjgAutDhcjpFJ0D9gxzeHXPfPHDoBTBhSvKi//xkHb8+dShjxA65AVm6f6pvJCTe0S2NVjEgXq1vZ8Q/Ipu+eDL8gEFb3M3lMS9a5ysFkZhV0Gv5UJpv9EHn+Pu4iLkYnDGtR1h2T4azqupueMbADm3aQrV+p3Jynjv7kLa/7BOoU32bpSdjZBb+CtfQx+1cgqT6MNeRcxwa+tjNe9Wnx/eak9wJCqBEgb/2/Ogpm7JGpjtJlQv5FWR+Ek5A2CU0GiicmTp7rnuZkvaihKgC30Myz2R3+A== X-YMail-OSG: iv0_EOoVM1mBj7eQmOc8GPM5hY..vJdGLoszfH4S6oV89UoeNAdIG6MXoudYl6h GoUSTSFxAqho9zSw1XG6B8cYcFXWuiNLJVoe1O8KCsnQdBqWdItA_xFCYquxFLDdChEzt93AFjuf 2emIWg0KPnq1k3w_ATGgAGQY8GM7NGDNPNKBbVZS7zHmkpgPxzR7h7Vkfm80IJAHvzDdLZugBLIX pGpvZF5u1VGbZzcbrQbaxRLyI6eOXppA6YN88KAYTzyp6kUVkm66mShbFHHKcamJulAXOQEmKDwA 4Ddt6WMEsMmFZDp4kz1RrcI_OGoNqiv7zeA1IjU2JDssUBH0p58Wcc_SxGUyfs7HYk6kWepb52GK eTq2pe3PJJYgdbl.0orN5w7NdKnzWHxMFHrbwkACa37xq.dbRGQ0ZWv_mcNX0XK43dLE07u8y7OA qX.hwb.aSx_YCJcE3R2rOvSDWHrNPzChpoMUtEtq0yiPQIxD3PVHhxKm8R6_SlpeVKlSSPYGw5.f JbfYUYvGYj6LuF2IONk1vlA1LxK9RX9aJC6vrh5qxAwpxjoKxc3RQFrcTYG36K6xSS21h8miZPDK Varlb36np.f9IOri1ioXpdsxL6FMuVnlc.xp4Pv1OPZn2rn0Hkshxz5u9TNxUWpo6S8Rw3aTMAU5 R5wI_CFfXzVsbadaZ6iRZuv1uSsmsXc0aoCclXeC8Z.2xMavUIjRwaipa9KEBfamaoouU1rS2I48 GB82KTRxWqU1Z8LPSsJRJw8kKh8cr0KCqSJlnnPlRJJc_lYGNrQ8k2akOyhEd.U6MIfFzlkbyNvE N.865hlHXkKYSNpPKqO1K3mNX4EVTJ_cIRxmKztUnS Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ir2.yahoo.com with HTTP; Fri, 12 Jul 2019 09:58:54 +0000 Original-Received: by smtp401.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 6791a9464a74d0d70d763165cbd72332; Fri, 12 Jul 2019 09:58:50 +0000 (UTC) Content-Disposition: inline In-Reply-To: <83tvbr3fl7.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.179.146 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238518 Archived-At: On Fri, Jul 12, 2019 at 09:57:24AM +0300, Eli Zaretskii wrote: >> Date: Fri, 12 Jul 2019 02:21:27 +0200 >> From: Ergus >> Cc: emacs-devel@gnu.org >> >> >I don't think I understand: what do you mean by "add the indicator"? >> >How would this indicator look like? >> > >> Maybe a vertical bar (like our previous column indicator) or a width >> line. Or something customizable somehow. We just need to look around, >> there are several alternatives. We must chose the one that fits better >> and produces less complications for us. But provides the functionality >> somehow. >> >> I don't thing how the indicator looks like may be a problem, but how >> accurate or specific it behaves. >> >> I am just looking around and Geany adds some vertical points as the >> indicator positions (every tab or every x spaces). But the spaces are >> only "indicated" when used for the indentation.. >> >> Sublime behaves in the same way. But there is an option to highlight the >> indicator only in the blocks around the current cursor. (As in the >> attachement) > >I didn't receive any attachments with your message. > >> Athom on the other hand seems to behave as in the >> highlight-indent-guides.el package: >> https://atom.io/packages/indent-guide-improved >> >> With the animations and so on. Which seems to be the most complete >> behavior, but less efficient. > >The animations and highlighting inside the current block should be in >Lisp, not in the display code. If at all. > >> In all the cases I just see that they add the indicator based on the >> characters between the beginning of the line and the indentation (first >> non blank character) not looking at the previous lines. They ignore if >> there is a previous line with wrong indentation or if the current line >> adds 3 tabs more respecting to the previous one. >> >> So, implementing it in this way doesn't seems to be so complex right? > >So basically you are talking about displaying some special glyph at >every tab stop inside leading whitespace of a line, or making each >tab-stop width have a different background color? Yes, this should be >possible to do in the display code. I just hope enough people will >see this as sufficient, because if most current users of these >packages won't switch, this new feature will not be worth its >development, documentation, and maintenance effort. Maybe we should >ask on Reddit first? Hi Eli: I think several people will prefer to have the whole functionalities and options to customize (as usual in emacs if there is a feature that solves N issues, then somebody will come asking for the N+1 option.) But in any case the minimal solution will be enough for a big number of users if it compensates with performance. But I agree that we must ask in reddit. May you please add a reddit poster about? Because as I don't use reddit very often, most users ignore them. Thanks in advance, Ergus