From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: highlight-indent-guides in display engine Date: Fri, 12 Jul 2019 02:21:27 +0200 Message-ID: <20190712002127.6tm3scplu73syinp@Ergus> References: <20190706211716.semd47fksgh66rug@Ergus> <83sgrh7uol.fsf@gnu.org> <20190711190651.b2kg64fg2ole2i5d@Ergus> <83zhlk2xiu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="140400"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 12 02:21:54 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hljJy-000aNm-2p for ged-emacs-devel@m.gmane.org; Fri, 12 Jul 2019 02:21:54 +0200 Original-Received: from localhost ([::1]:45948 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hljJv-0007LA-Vq for ged-emacs-devel@m.gmane.org; Thu, 11 Jul 2019 20:21:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40247) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hljJo-0007Ks-MT for emacs-devel@gnu.org; Thu, 11 Jul 2019 20:21:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hljJn-0001Cl-IG for emacs-devel@gnu.org; Thu, 11 Jul 2019 20:21:44 -0400 Original-Received: from sonic310-12.consmr.mail.ir2.yahoo.com ([77.238.177.33]:43466) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hljJn-00019Z-Am for emacs-devel@gnu.org; Thu, 11 Jul 2019 20:21:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1562890901; bh=xth6tYq940t4v9ZcTXytfmRD/vGJ6VqJ85uAxV4y8os=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=k7SpdQeYvPmfDt+9iaKcDP3+VRcVV9CNdnBLYA5D3ivpr+d6s3UurQW3re2m9YLGDt1glU2wKKhEek5n4qvEx8DO/mXf3AhueX/7vOStMnLVbklqnY64i5MbI0LMkXyfMLUFprOd/s1un4waK+F5VAQhGnX8tgDWelypGszFQ422/9hGSOl5ATlndvTs9hDZab0sU8BWVvYLt1tvN8L7wEwcT/7PYAdFeSLatxXzcWzkx4iksQOhE7Oo9xJD8xCjwT1tUYuqkEqFIqiswgW/+f7+fCKchzR7yFR3riRXmMTpGAnWFSREawjihFwRy03BAsLFKvCGXFASaJM0heaTZQ== X-YMail-OSG: RMr_zfgVM1ndhyMZaxIlg0inkAoEBT9OJsniRaQSWp1Na1jdrductpzgizsqzXo CPzExi9t0WV_LZaMr1557FpoGv6.xDCaMyyQR2JCmqYc00QsaIQYrnXexSOUd1OgaGHPJ3Nhdk8y BgjHSUA9zWoHSRP8yigLJtnbkYTXPnMxJvTNvxVVv9IQcD3SdjlGBMxrUFcelc71z7PeC6vdxfNS SszyWQbg7KjGSbUvdl_v.SlKbYpe0J1Z_8JFtLcX8Fe.VVT6hUg_fgS6ptel9SE4.Fx6TxUM12RI mcisTIYo9TzpuUelIRxoKD9LzgJZQfRZ.ihIfcVuCkVN34o_i5M0m6Dnfik5GvlG.mgJm7TeNmSk 5.Dat7zFZx8g3EVM.a5_xT_Sjscup.WG5HX7B009JCx0_SqjsK3QOFH50292mGxd8vRIJ.LC62gj uUocQExLosUC9lmEOOQ80r2KAX5921D5s.RXhrsDna37fx_BGzD8Zv38bvFwvREte_c0Qxwy3j6O 1kQv_Bz.KKJ1m3YrDayEGQCFb1l2TfFejW_XquYcDh9xh0Rxp4HfUjwit0rms6m2SHQCGNnaoWJU wJJTKVTNeMGLlKSOxX0I64yAHOsoXMRdnwA6xiY_PSZ9L28ecHpLGJOw3puXgbnmAMNmB5eNXHVt _2lTTZ1KYMpwCFHssxE.mkdEVTQ20BKRrc1176L4FzQjaZZeHhHpm06_CgaTJNKDzxIGped5bbZL BBH2GTOqO5jShh3DmTUo5otMHohXZaX6ns5ycU4lhnz1Q2mfGJSqRxY2myI1iVTjnb6sDWpQeLa7 xvzwXTCQ27mEzLgYid.pLtdnZaoXaAIuSaQCL349S5 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Fri, 12 Jul 2019 00:21:41 +0000 Original-Received: by smtp431.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 8643df759ea5817cefa8647a6a3e8b8f; Fri, 12 Jul 2019 00:21:36 +0000 (UTC) Content-Disposition: inline In-Reply-To: <83zhlk2xiu.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.177.33 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238515 Archived-At: On Thu, Jul 11, 2019 at 10:15:21PM +0300, Eli Zaretskii wrote: >> Date: Thu, 11 Jul 2019 21:06:51 +0200 >> From: Ergus >> Cc: emacs-devel@gnu.org >> >> Check if indenting with spaces or tabs && add the indicator for >> those character (or every tab-width spaces) from the beginning of the line >> until the first different character of the line. And that's it... > >I don't think I understand: what do you mean by "add the indicator"? >How would this indicator look like? > Maybe a vertical bar (like our previous column indicator) or a width line. Or something customizable somehow. We just need to look around, there are several alternatives. We must chose the one that fits better and produces less complications for us. But provides the functionality somehow. I don't thing how the indicator looks like may be a problem, but how accurate or specific it behaves. I am just looking around and Geany adds some vertical points as the indicator positions (every tab or every x spaces). But the spaces are only "indicated" when used for the indentation.. Sublime behaves in the same way. But there is an option to highlight the indicator only in the blocks around the current cursor. (As in the attachement) Athom on the other hand seems to behave as in the highlight-indent-guides.el package: https://atom.io/packages/indent-guide-improved With the animations and so on. Which seems to be the most complete behavior, but less efficient. In all the cases I just see that they add the indicator based on the characters between the beginning of the line and the indentation (first non blank character) not looking at the previous lines. They ignore if there is a previous line with wrong indentation or if the current line adds 3 tabs more respecting to the previous one. So, implementing it in this way doesn't seems to be so complex right?