From: Alan Mackenzie <acm@muc.de>
To: "João Távora" <joaotavora@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [PATCH] Re: Algorithm in electric-pair--unbalanced-strings-p unsuitable for CC Mode
Date: Thu, 4 Jul 2019 19:01:00 +0000 [thread overview]
Message-ID: <20190704190100.GG5564@ACM> (raw)
In-Reply-To: <CALDnm51RwAYJmCaOCMmrRErksnKEwaMKarap1eHgz1_P_XgJpw@mail.gmail.com>
Hello, João.
On Thu, Jul 04, 2019 at 19:45:26 +0100, João Távora wrote:
> On Wed, Jul 03, 2019 at 14:31:58 +0100, João Távora wrote:
> > [ .... ]
> > > If [you] don't agree, find a small enough solution that fixes e-p-m,
> > > propose it here, then find a consensus that overrides my opinion, it
> > > happens all the time, won't hold it against you or anyone else, good
> > > luck.
> > Here is the entire part of the fix needed for bug #36474, that should go
> > into elec-pair-mode.el:
> I'll have a look, but please show the whole change, not just
> the new function. A new function by itself has no effect in e-p-m or
> any other part of emacs. You should show where you intend to use it
> (it should, in principle, be in one of e-p-m's external-facing variables).
At the top of c-basic-common-init:
diff -r eb4ee9bb0682 cc-mode.el
--- a/cc-mode.el Thu Jul 04 13:01:08 2019 +0000
+++ b/cc-mode.el Thu Jul 04 18:56:49 2019 +0000
@@ -521,6 +521,14 @@
(setq c-buffer-is-cc-mode mode)
+ ;; Prepare for the use of `electric-pair-mode':
+ (eval-after-load "elec-pair"
+ '(when (and (boundp 'electric-pair-inhibit-predicate)
+ (fboundp 'electric-pair-cc-inhibit-predicate))
+ (make-local-variable 'electric-pair-inhibit-predicate)
+ (setq electric-pair-inhibit-predicate
+ #'electric-pair-cc-inhibit-predicate)))
+
;; these variables should always be buffer local; they do not affect
;; indentation style.
(make-local-variable 'parse-sexp-ignore-comments)
> Thanks,
> João
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2019-07-04 19:01 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 13:16 bug#36474: Algorithm in electric-pair--unbalanced-strings-p unsuitable for CC Mode Alan Mackenzie
[not found] ` <CALDnm51Hi10KMqYneWBamNL4sNdzHEz6_NasGk=oR_y-=1Y7nQ@mail.gmail.com>
2019-07-02 15:27 ` Fwd: " João Távora
2019-07-02 16:04 ` bug#36474: " Alan Mackenzie
2019-07-02 17:22 ` João Távora
2019-07-02 17:22 ` João Távora
2019-07-02 18:28 ` bug#36474: " Alan Mackenzie
2019-07-02 21:11 ` Stefan Monnier
2019-07-03 9:28 ` João Távora
2019-07-03 10:58 ` Alan Mackenzie
2019-07-03 13:07 ` Dmitry Gutov
2019-07-03 13:32 ` Alan Mackenzie
2019-07-03 14:25 ` Dmitry Gutov
2019-07-03 15:58 ` Eli Zaretskii
2019-07-03 20:54 ` Alan Mackenzie
2019-07-04 2:33 ` Eli Zaretskii
2019-07-04 1:36 ` Richard Stallman
2019-07-03 13:33 ` Eli Zaretskii
2019-07-03 13:35 ` João Távora
2019-07-03 13:31 ` João Távora
2019-07-03 18:25 ` Kévin Le Gouguec
2019-07-04 0:52 ` João Távora
2019-07-04 6:17 ` Kévin Le Gouguec
2019-07-04 15:05 ` Alan Mackenzie
2019-07-04 15:50 ` João Távora
2019-07-04 16:58 ` [PATCH] " Alan Mackenzie
2019-07-04 18:45 ` João Távora
2019-07-04 19:01 ` Alan Mackenzie [this message]
2019-07-04 21:44 ` João Távora
2019-07-08 10:05 ` Alan Mackenzie
2019-07-08 12:10 ` João Távora
2019-07-08 15:49 ` Stefan Monnier
2019-07-08 16:33 ` Stefan Monnier
2019-07-08 17:24 ` Alan Mackenzie
2019-07-08 17:32 ` Stefan Monnier
2019-07-08 16:45 ` Alan Mackenzie
2019-07-08 17:29 ` Stefan Monnier
2019-07-08 18:05 ` Alan Mackenzie
2019-07-08 20:59 ` Stefan Monnier
2019-07-09 6:41 ` Clément Pit-Claudel
2019-07-09 9:06 ` João Távora
2019-07-09 9:23 ` João Távora
2019-07-09 9:52 ` Alan Mackenzie
2019-07-09 10:54 ` João Távora
2019-07-09 11:18 ` João Távora
2019-07-09 15:18 ` Dmitry Gutov
2019-07-09 15:40 ` contextual refontification (was: [PATCH] Re: Algorithm in electric-pair--unbalanced-strings-p unsuitable for CC Mode) Stefan Monnier
2019-07-10 9:32 ` João Távora
2019-07-09 15:43 ` [PATCH] Re: Algorithm in electric-pair--unbalanced-strings-p unsuitable for CC Mode João Távora
2019-07-09 15:31 ` Alan Mackenzie
2019-07-09 16:14 ` João Távora
2019-07-09 12:33 ` Clément Pit-Claudel
2019-07-09 14:28 ` João Távora
2019-07-09 16:05 ` Clément Pit-Claudel
2019-07-09 16:32 ` João Távora
2019-07-09 17:09 ` João Távora
2019-07-09 13:45 ` Stefan Monnier
2019-07-09 16:00 ` Alan Mackenzie
2019-07-09 17:11 ` Stefan Monnier
2019-07-09 18:26 ` Alan Mackenzie
2019-07-09 18:47 ` Eli Zaretskii
2019-07-09 18:53 ` João Távora
2019-07-10 10:32 ` Alan Mackenzie
2019-07-10 10:40 ` Lars Ingebrigtsen
2019-07-10 12:24 ` João Távora
2019-07-10 14:14 ` Clément Pit-Claudel
2019-07-10 16:07 ` João Távora
2019-07-11 15:14 ` Lars Ingebrigtsen
2019-07-11 15:43 ` João Távora
2019-07-11 15:51 ` Lars Ingebrigtsen
2019-07-11 16:13 ` João Távora
2019-07-12 15:58 ` Lars Ingebrigtsen
2019-07-12 18:47 ` João Távora
2019-07-13 0:08 ` Lars Ingebrigtsen
2019-07-10 12:10 ` João Távora
2019-07-10 14:03 ` Alan Mackenzie
2019-07-10 16:05 ` João Távora
2019-07-10 17:56 ` Alan Mackenzie
2019-07-11 0:11 ` Richard Stallman
2019-07-03 16:56 ` Stefan Monnier
2019-07-03 16:58 ` Stefan Monnier
2019-07-04 15:24 ` Alan Mackenzie
2019-07-04 15:52 ` Stefan Monnier
2019-07-04 16:42 ` Alan Mackenzie
2019-07-04 20:16 ` Stefan Monnier
2019-07-04 21:27 ` João Távora
[not found] ` <handler.36474.B.156207340818492.ack@debbugs.gnu.org>
2019-07-08 9:36 ` bug#36474: Acknowledgement (Algorithm in electric-pair--unbalanced-strings-p unsuitable for CC Mode) Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190704190100.GG5564@ACM \
--to=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.