From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: master b9ac4f8.. (Fix locating pdump by symlink) breaks with stow Date: Mon, 24 Jun 2019 16:19:23 +0200 Message-ID: <20190624141923.rz776iwfkuw3h2mo@Ergus> References: <87imsvuvnr.fsf@wavexx.thregr.org> <20190624111050.jindvg6j4hr5j226@Ergus> <20190624122841.vfezkecaxjqwzjy3@Ergus> <20190624135046.x4r54hwj4yzfea5t@Ergus> <230e1b8e13eed00f47c1119ec6d619e4.squirrel@dancol.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="35213"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: Yuri D'Elia , Emacs developers , Yuri Khan To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 24 16:19:52 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfPp0-00093L-Uo for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2019 16:19:51 +0200 Original-Received: from localhost ([::1]:51614 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfPoz-0005FK-QG for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2019 10:19:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51666) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfPoj-0005Ee-9R for emacs-devel@gnu.org; Mon, 24 Jun 2019 10:19:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfPoi-0000iC-7u for emacs-devel@gnu.org; Mon, 24 Jun 2019 10:19:33 -0400 Original-Received: from sonic312-25.consmr.mail.ir2.yahoo.com ([77.238.178.96]:39987) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfPoh-0000fd-OV for emacs-devel@gnu.org; Mon, 24 Jun 2019 10:19:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1561385969; bh=/xX7Do2PUZMq+NR15fedV+esxZebCOCWzvIlKjQZY0A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=H5UInp2CQlnYRHwyj2WL+6yuKfU81lG1oCRvkptoFc1/sypvYMlUMkUa9nuxKy5XJaSZmMpHyP20/wDuAADkPdO7ejeNs1bvn2h9uQ5YwEZG+cnsp29GErb8SIvMb70nLwMO1tWQkdxyXchhTUJbGvK+q2xqZTwCaAYR0y9ZfbpmM/zJ7svS2kz4SZQStQT/5ko3Kmgv0nXBu0zt6rO1/BVho8WqzUbVXgSBFmv1RVhI8URiAWjUcMGSeTEt3n9gbu9FJZEiugkHRJcfsolRXNEQ3VOgJXh4oIDIX9Sq11fJlmjjnNyPYSvpfgZdKf1Kr1YqCl8RoDKk0hZ0ltdlvw== X-YMail-OSG: U2nDOMwVM1kF2wDf3HWlEDFd4oUwwbY1xLKCrharPUytM8KNz53D014O3CL0OcX 2nz7qacn3DoWs4F2lwxLBylTad_YST9hOXA_1OqYel8Ldzmr_NUL_aKZDSHwxl.uJhYHav8WtYQt FxzimJUcH.64TGeBFUVtzS2cJ_9rzQ5hEpXaeA7GyPHr0fnt4j9oDY6cUTVVQVbaP2n7RIApRma2 GdLpW1sF.qU3eWv9sc1wDsE5V6ml7I_ouIYEJkYEj7m2L1YQbgqm_DRJxg2e24rRR3TXxLhQVOPf JKZxSR9.ZvEIOuQZmaTL6hmXiJecBQpvLT1QQzSULpfGlom1NZg4XWPMrknZgCqiMIgMxfYwfYuQ Sq3gsO8_rEVnxjMf_SVarRUds.t7jJ71PonFwePBZK.WicmrxCacJGHWqR0xBgKctUi6KR35V6AI BqItt_mqQ5XVLOKZezaAdwR2fu.1rfWfGX8mOY6b5I5cXE5gQA4kHkmEhWM09ESlpEmDuVkIvIDX pfBOXoBaGZy7seIAhoCRFM4vhT9JqSqKQ3rlpYokRKcDnWke8wZ9PE6JfsIj1QJ6TE52WIf4OUps oLLnJf4kXTmtWTS.sLJH0c7BQAfcI_unEmZlPn3sZtWddq4u.VWGr1FiVm75P2W.l7oLbDvW1a38 q68pKIYzjmio0EvUPxt_iFIjK9Vbbp3dMMl6AI1uB_IR3lZ92_hQOK.gAiELSXLk38ETdNe4TQNy Yt4nvgENLTPJB_8MtFjOW9ynHSxarzGnPucVGeachIHTNn.eb_1aoa54ISrLu6whER.ajm0pmXIW 0Miqgl_P67pGimXb0INL0OkI.tZC8ej0R5Fxg6DM0C Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ir2.yahoo.com with HTTP; Mon, 24 Jun 2019 14:19:29 +0000 Original-Received: from 2.152.205.184.dyn.user.ono.com (EHLO Ergus) ([2.152.205.184]) by smtp409.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 4512ee202d1f04f0ae629ce825a33b81; Mon, 24 Jun 2019 14:19:27 +0000 (UTC) Content-Disposition: inline In-Reply-To: <230e1b8e13eed00f47c1119ec6d619e4.squirrel@dancol.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.178.96 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238101 Archived-At: On Mon, Jun 24, 2019 at 06:54:10AM -0700, Daniel Colascione wrote: >> On Mon, Jun 24, 2019 at 06:21:12AM -0700, Daniel Colascione wrote: >>>> On Mon, Jun 24, 2019 at 06:57:32PM +0700, Yuri Khan wrote: >>>>>On Mon, Jun 24, 2019 at 6:12 PM Ergus wrote: >>>>> >>>>>> 750| char* argv0 = realpath (argv[0], NULL); >>>>>> 751| if (!argv0) >>>>>> 752| fatal ("could not resolve realpath of \"%s\": %s", >>>>>> 752| argv0, strerror (errno)); >>>>> >>>>>This looks wrong. If we called realpath and it returned null, we???d >>>>>probably want the original argv[0] in the error message, not the null >>>>>result. >>>>> >>>> >>>> This also produces problems when using emacs from an alias like em o >>>> emc >>>> which is a very common practice. >>>> >>>> So there should be actually other conditions to try if the first >>>> realpath call fails and not abort (call fatal) in the first try. >>> >>>Try it now. Sorry about the botched change. >>> >>> >> Hi Daniel: >> >> Did you pushed any change too savannah/master? > >Graph. Of course the push failed. *Now* try it. :-) > > Hi again: I think this is related with bug#35503 and could be used to fix it too (if not done already with your latest change) Very thanks, Ergus