From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: master b9ac4f8.. (Fix locating pdump by symlink) breaks with stow Date: Mon, 24 Jun 2019 16:05:25 +0200 Message-ID: <20190624140524.7hinqpe4hgqr2ocr@Ergus> References: <87imsvuvnr.fsf@wavexx.thregr.org> <20190624111050.jindvg6j4hr5j226@Ergus> <20190624122841.vfezkecaxjqwzjy3@Ergus> <20190624135046.x4r54hwj4yzfea5t@Ergus> <230e1b8e13eed00f47c1119ec6d619e4.squirrel@dancol.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="257436"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: Yuri D'Elia , Yuri Khan , Emacs developers To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 24 16:08:48 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfPeK-0014rn-7s for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2019 16:08:48 +0200 Original-Received: from localhost ([::1]:51470 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfPeJ-0003iK-59 for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2019 10:08:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47548) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfPbG-000297-55 for emacs-devel@gnu.org; Mon, 24 Jun 2019 10:05:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfPbF-0007sY-2P for emacs-devel@gnu.org; Mon, 24 Jun 2019 10:05:38 -0400 Original-Received: from sonic311-30.consmr.mail.ir2.yahoo.com ([77.238.176.162]:33201) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfPbE-0007pJ-Ok for emacs-devel@gnu.org; Mon, 24 Jun 2019 10:05:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1561385134; bh=ooNCLBzbZk6b/KcI1txdk+SuUEuMPwDjLZU8K8lOav8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=bzoCp3RWR3RBnKYl5pQapEEaGFFHTGoY21QbwHz3j1CsQmA7HM5pS1yowjxiNIsO2VFx5RZTOZeFoYF1zwUK188svD3Xw87r+52nRTEepa5LGz9URs9cSpYB7xfO3JhzyVqtX+DjqjWT2ntf3Z/SsJhzBKLgDcj6phPApKXsXVikM6CXFD+dL/MMnojr1jOhdfcIeaeN1F5BJDWK+Lv11ZJ/RTkGpFhyNBjtQqrsNHSnRe4ozAb8DJYZrqb8UUXZz7FqdLgV8OMrr/kr9YYG8I6iZfYOeUKk84YivQtCk0jQeVCwqU4LSR5uUop3UELtkduGelWqPQgWR6wL3Yjjqw== X-YMail-OSG: iodz6t4VM1nJbLeZNLnzB7oE8Ncs.VOjbPcoG68d1D09pQAhFrL_UufBT4JPVi5 OtbEN2KVt9JlG5Ow.2Dp9UgThJtTj2a_fgyAVwM8RpLhJeKQ4tCD9paairibA_dkfDvEZvOCYvDR TMtOyyyhcTVu18zhjED6XdbJlvPtG3Uf6qlHGKijZUM3Fyc3hA7QMkMHAraPUUZNMkN4j5XD4ZQT PMTzS8TBKt6A2px5b_ytlUjTbH8NTMXue3uGd5LwgzQz.d02Q1hkOmn3DDqbaaf56IYJsTUyOzKY yjJYN9wq2.OzTJwBH86dYbUCkLbHpF9VVcSdKrpQGadHknjxg2Ty1rBgVbbyOJtEet1B8HhqVThz Lrtxbquu129JzagKPSZyQy9tWY_VimPpHx4LBxmaCDM8v5wiPKtDvk0wrPPIV0MeXMfZbGSJB3vy zGSYoNwsU5emdYVP2J4UEE6PzY6uT5ElNFbyCF_KxQKAkmTIqHirkGL2y7GZj2BIW8i_MszP58gq _wFCujR.ordNg5_Jh.JCYi1YRrFPYLcpvLsI9tWpvQLIyMZvZx2wac2KRCOSeLLnsHiFjrCTw5Dj FB7mvcHbFKAS8VWcJFWZ9DrMvkeTs5R_kNwyRfUcebd9zNI.6ORqJ1ZACSBhY14bNgZH_Rd3QwmO WJJIxsXylOPwcFs8Vnaua5auc6WxzzPOUjjYJ_pXpmaTG2uaf4PTUMBcqWviqLdLnirRK_K0qPo. YIPEbVdS3NFqW2fwyPIlFLbw_8mJidOZgZHMwrJqLVz5wHLIitQstKcJA3bzJMIcy_4qE63S7ZFp .gYnewxEJ1qADhJWOlVS3tdf1yGLpMIIxWWnR1RivE Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ir2.yahoo.com with HTTP; Mon, 24 Jun 2019 14:05:34 +0000 Original-Received: from 2.152.205.184.dyn.user.ono.com (EHLO Ergus) ([2.152.205.184]) by smtp419.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID de59b57f73668570df6fa713364a4a35; Mon, 24 Jun 2019 14:05:28 +0000 (UTC) Content-Disposition: inline In-Reply-To: <230e1b8e13eed00f47c1119ec6d619e4.squirrel@dancol.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.176.162 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238099 Archived-At: On Mon, Jun 24, 2019 at 06:54:10AM -0700, Daniel Colascione wrote: >> On Mon, Jun 24, 2019 at 06:21:12AM -0700, Daniel Colascione wrote: >>>> On Mon, Jun 24, 2019 at 06:57:32PM +0700, Yuri Khan wrote: >>>>>On Mon, Jun 24, 2019 at 6:12 PM Ergus wrote: >>>>> >>>>>> 750| char* argv0 = realpath (argv[0], NULL); >>>>>> 751| if (!argv0) >>>>>> 752| fatal ("could not resolve realpath of \"%s\": %s", >>>>>> 752| argv0, strerror (errno)); >>>>> >>>>>This looks wrong. If we called realpath and it returned null, we???d >>>>>probably want the original argv[0] in the error message, not the null >>>>>result. >>>>> >>>> >>>> This also produces problems when using emacs from an alias like em o >>>> emc >>>> which is a very common practice. >>>> >>>> So there should be actually other conditions to try if the first >>>> realpath call fails and not abort (call fatal) in the first try. >>> >>>Try it now. Sorry about the botched change. >>> >>> >> Hi Daniel: >> >> Did you pushed any change too savannah/master? > >Graph. Of course the push failed. *Now* try it. :-) > Yes, it works for me. Very thanks :)