From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#36328: [jayden@yugabyte.com: Re: bug#36328: 26.2; Args out of range on search-and-replace of *.cc file] Date: Sun, 23 Jun 2019 20:10:48 +0000 Message-ID: <20190623201048.GC4736@ACM> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="159154"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Jayden Navarro , 36328@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 23 22:11:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hf8pa-000fGc-5I for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Jun 2019 22:11:18 +0200 Original-Received: from localhost ([::1]:46642 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hf8pZ-0000mO-87 for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Jun 2019 16:11:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47153) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hf8pL-0000m6-Rx for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 16:11:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hf8pK-0002ed-DG for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 16:11:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41153) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hf8pK-0002eU-91 for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 16:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hf8pK-0008Ne-1f for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 16:11:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jun 2019 20:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36328 X-GNU-PR-Package: emacs Original-Received: via spool by 36328-submit@debbugs.gnu.org id=B36328.156132066032205 (code B ref 36328); Sun, 23 Jun 2019 20:11:01 +0000 Original-Received: (at 36328) by debbugs.gnu.org; 23 Jun 2019 20:11:00 +0000 Original-Received: from localhost ([127.0.0.1]:54697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf8pH-0008NN-Jn for submit@debbugs.gnu.org; Sun, 23 Jun 2019 16:11:00 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:63736 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1hf8pF-0008ND-32 for 36328@debbugs.gnu.org; Sun, 23 Jun 2019 16:10:58 -0400 Original-Received: (qmail 65650 invoked by uid 3782); 23 Jun 2019 20:10:51 -0000 Original-Received: from acm.muc.de (p2E5D5B98.dip0.t-ipconnect.de [46.93.91.152]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 23 Jun 2019 22:10:50 +0200 Original-Received: (qmail 23735 invoked by uid 1000); 23 Jun 2019 20:10:48 -0000 Content-Disposition: inline X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161170 Archived-At: Hello, Juri. As the replace.el expert here, could you please have a look at bug #36328, and in particular, comment on Jayden's patch (below), which I think would be a good fix for the bug. Is there anything we've missed, such as unforeseen and unwanted effects somewhere else? Thanks! -- Alan Mackenzie (Nuremberg, Germany). ----- Forwarded message from Jayden Navarro ----- X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on f9b3f715-3f29-11e8-b508-002264fbbacc X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,HTML_MESSAGE, RCVD_IN_DNSWL_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yugabyte-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eZM1FmYPfQWqIxfpYI+vG/ojcQEm248LbjE6PiQr8CE=; b=2ELl2xbqAuUFiUbRfNinSQfbRbxhWgpTsLbHINR3oKe37wJPYbt4LoKqFc2wo7uEjo 79POKqduJ+PerwW+epBOAGP8zeqwAUNnKG7F/TMvPYixI8qh+oz6qQ7MuJfhtfc7ZVuw h1jiPQYSnJXkTMtZJZk3n+2RrKo4rRKbQQ4wrT+fq1ihZB8F3xVdbz3pGmLLmD0wwOzm Qr+tYUtR9ix6yDSKq+Jr5JS/Rmh3kH8HDq67OpFwWYHSClPjGxzGTJQWEn5JqEoR6bL6 agHOiamb4rXFNvDdxyd70EaOQ5cNNHfRlpODk1suZdZpoCfX8FpYcdcepmixs/qx/PAF Fbhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eZM1FmYPfQWqIxfpYI+vG/ojcQEm248LbjE6PiQr8CE=; b=I3nt5jWknsKit8BXYashILtTd3kbV+DPx6pTHDgPZW6ZtzX87SzXiuwGZoczrJXsD3 cNss+BZVBJtZLFTsIC74LkWhtYh2OCdU3o5TG7TQ0SQqyQJ+FwWOfAMyBOVi4GvTJCLA Wg9rokIiwKUR6O+DvD0M+gpepHhc0NlW4iAeOrGaIb/jerwNticHF0MRdRSL2DKQ5nrH fbMnO+5+nHEmIU2tUpd8EYqqHZQByXJfaKu7UKUJ/g1uCwbE5/SX401kslfM5ckl8xAC 5TJi08H4w3MKAGDzHJQrLdau7YoowFGZHvy1b0QiO7KjLDtRJ7HWVEu9TH3UUnILKg1r r90g== X-Gm-Message-State: APjAAAW9vckX+zTLPd5fU5sesgvGsywasM/voob85fK5EyMnJsiEqvlv +R4mtzsBALaEP8quUhVW6AZS2FgQuzeq+SsPVGjXoAsw9sg= X-Google-Smtp-Source: APXvYqxMxLxnGbgDBDwO7TQTe8IgNSSsQVMZ9S4j4kjCIGq7xdMYxG9J7kbLnxz35VR1RawX6tIm+0sJqHRqhftmU/c= X-Received: by 2002:a2e:3913:: with SMTP id g19mr15782122lja.212.1561306471058; Sun, 23 Jun 2019 09:14:31 -0700 (PDT) From: Jayden Navarro Date: Sun, 23 Jun 2019 09:14:19 -0700 Subject: Re: bug#36328: 26.2; Args out of range on search-and-replace of *.cc file To: Alan Mackenzie Cc: 36328@debbugs.gnu.org Hi Alan, Thank you for looking into this! Until this is officially fixed I've come up with the following workaround, going off of the details you provided: I created a "replace_fixed.el" file in "~/.emacs.d/lisp/" that is replace.el taken from https://raw.githubusercontent.com/emacs-mirror/emacs/emacs-26/lisp/replace.el with the following diff: diff --git a/replace.el b/replace_fixed.el index 08feb8e..8280fdd 100644 --- a/replace.el +++ b/replace_fixed.el @@ -2227,7 +2227,7 @@ It is called with three arguments, as if it were (isearch-forward (not backward)) (isearch-other-end match-beg) (isearch-error nil)) - (isearch-lazy-highlight-new-loop range-beg range-end)))) + (save-match-data (isearch-lazy-highlight-new-loop range-beg range-end))))) (defun replace-dehighlight () (when replace-overlay Then I added the following to my "~/.emacs", restarted my emacs server, and the issue was gone!: (load-library "~/.emacs.d/lisp/replace_fixed.el") This probably isn't the proper fix, but just thought I'd share in case anyone else is experiencing this and wanted a temporary workaround. Best, Jayden ----- End forwarded message -----