From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#36115: 27.0.50; Git master branch compile error with --with-cairo configure flag Date: Fri, 7 Jun 2019 17:48:26 +0100 Message-ID: <20190607164826.GA48250@breton.holly.idiocy.org> References: <874l5138ip.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="177537"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.12.0 (2019-05-25) Cc: Eugene Mah , 36115@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 07 21:11:53 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hZKHG-000k3o-EM for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Jun 2019 21:11:50 +0200 Original-Received: from localhost ([::1]:51486 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZKHF-0004Vr-7L for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Jun 2019 15:11:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48804) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZI36-0004Bh-Bh for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2019 12:49:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZI35-00081U-0k for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2019 12:49:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38763) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hZI34-0007yy-Kx for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2019 12:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hZI34-0000Z3-GU for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2019 12:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Jun 2019 16:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36115 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 36115-submit@debbugs.gnu.org id=B36115.15599261182128 (code B ref 36115); Fri, 07 Jun 2019 16:49:02 +0000 Original-Received: (at 36115) by debbugs.gnu.org; 7 Jun 2019 16:48:38 +0000 Original-Received: from localhost ([127.0.0.1]:52307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZI2f-0000YF-Qm for submit@debbugs.gnu.org; Fri, 07 Jun 2019 12:48:38 -0400 Original-Received: from mail-wm1-f52.google.com ([209.85.128.52]:34221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZI2e-0000Xx-5S for 36115@debbugs.gnu.org; Fri, 07 Jun 2019 12:48:37 -0400 Original-Received: by mail-wm1-f52.google.com with SMTP id w9so4468800wmd.1 for <36115@debbugs.gnu.org>; Fri, 07 Jun 2019 09:48:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=JJBh8OvAH2FWjleGgrTMZ6+qrczO9D6YDdUqt1kc5mg=; b=o9xvKnq/crQK/yO4lf6jGi83jjuK0ggOwN8Vlq3H4G2qy+KY8ZCrIHp2Mp+HwTLGGZ K1fXj+knr5B5QREVa5FDXbVx5Uh+sXDj5eUSaLEz7/MYRPr/535Baprs7Xgg0DSjnd+X M+eRndkaQiiaS8omgOS4srF/gcFxtPOIys9toZk/x1a/7CXRTarv6PR6jyM7EI9coEyi QB0aB0GQyuBaxCPr6l10q09Hn/nWkPpc+Jq8SkaOiio0UbsQY9AS6jPnEU9gRNyY+SBP hIxMHEHH0eUfVFUpgYJNeKMpnLfewouSKPO/dmegBpJSEqESC7RA0aymCP0ovUB2WktL fI6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=JJBh8OvAH2FWjleGgrTMZ6+qrczO9D6YDdUqt1kc5mg=; b=QY99jCySNNs9sZ3TCmzIm89GFtT5IsTxez5etCUOWx+l2OYMyQHlI8efYMm57I4nWP w/j8clCNoTniMMci7GXqqAghPfbQnlYUXhMkWJCZy1o/WC01m0y53Eju1JRekUlHbeAg 4s38BaYVLzpSwoT7+VLe+TZhwbJ+NqKoKx237xhgMaw43rVpsm3BKb8cGeV0kYDQ0km0 JrZPOJ1+c+HQgesXRYETbuDhooWqtxyzeifYkm7SWxHy5NHCRtUF/fOqLRkUcwCenVb9 fByU+Rt0xEadwu1ukFycU6Sv9Odwar+O/di6l2JnRk2wfCBDloTsksecPyDgWFbDKhHt d6ZQ== X-Gm-Message-State: APjAAAW3fA3JeYEMChtbJTBR9y9UF/G3YHHeSKflMY/zNdh2X0oGUZXz L7yTORQU/JGMgicL1AD7XhE= X-Google-Smtp-Source: APXvYqy6Tf/+V68j1TRO2GDVSaQkXzk5IBZch08IEcGN14NAQdWImC1fGark4mRFODCel8qwTOy56w== X-Received: by 2002:a1c:9e8e:: with SMTP id h136mr4319527wme.29.1559926109064; Fri, 07 Jun 2019 09:48:29 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-3d0f-eb14-4f10-dffd.holly.idiocy.org. [2001:8b0:3f8:8129:3d0f:eb14:4f10:dffd]) by smtp.gmail.com with ESMTPSA id d3sm2169496wrs.8.2019.06.07.09.48.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Jun 2019 09:48:28 -0700 (PDT) Content-Disposition: inline In-Reply-To: <874l5138ip.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160220 Archived-At: On Fri, Jun 07, 2019 at 08:05:50AM -0400, Noam Postavsky wrote: > tags 36115 fixed > close 36115 > quit > > Eugene Mah writes: > > > When compiling the latest git master branch, the following error occurs: > > > > image.c: In function ‘image_set_crop’: > > image.c:2046:16: error: ‘width’ undeclared (first use in this function); > > did you mean ‘Qwidth’? > > 2046 | img->width = width; > > > When the --with-cairo flag is omitted, master branch compiles without > > issue. > > > > The error occurs in the image_set_crop() function, so perhaps related to > > this commit > > http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=610fb73ab6d7a22b722f523d6ebc4aa8fa1db7c9 > > I believe this was fixed yesterday. > > c8123b45f7 2019-06-06T09:07:36-04:00 "Restore height and with from that were accidentally removed" > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c8123b45f7b9b660db2040ee85c3a2fd260d3f16 I hadn’t noticed this. I suspect a merge from master has transposed part of image_set_size into image_set_crop in my local branch and I failed to see it before pushing. I’ll sort this out asap. -- Alan Third