all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: Eugene Mah <eugenemah@gmail.com>, 36115@debbugs.gnu.org
Subject: bug#36115: 27.0.50; Git master branch compile error with --with-cairo configure flag
Date: Fri, 7 Jun 2019 17:48:26 +0100	[thread overview]
Message-ID: <20190607164826.GA48250@breton.holly.idiocy.org> (raw)
In-Reply-To: <874l5138ip.fsf@gmail.com>

On Fri, Jun 07, 2019 at 08:05:50AM -0400, Noam Postavsky wrote:
> tags 36115 fixed
> close 36115 
> quit
> 
> Eugene Mah <eugenemah@gmail.com> writes:
> 
> > When compiling the latest git master branch, the following error occurs:
> >
> > image.c: In function ‘image_set_crop’:
> > image.c:2046:16: error: ‘width’ undeclared (first use in this function);
> > did you mean ‘Qwidth’?
> >  2046 |   img->width = width;
> 
> > When the --with-cairo flag is omitted, master branch compiles without
> > issue.
> >
> > The error occurs in the image_set_crop() function, so perhaps related to
> > this commit
> > http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=610fb73ab6d7a22b722f523d6ebc4aa8fa1db7c9
> 
> I believe this was fixed yesterday.
> 
> c8123b45f7 2019-06-06T09:07:36-04:00 "Restore height and with from that were accidentally removed"
> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c8123b45f7b9b660db2040ee85c3a2fd260d3f16

I hadn’t noticed this. I suspect a merge from master has transposed
part of image_set_size into image_set_crop in my local branch and I
failed to see it before pushing.

I’ll sort this out asap.
-- 
Alan Third





  reply	other threads:[~2019-06-07 16:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-06 13:40 bug#36115: 27.0.50; Git master branch compile error with --with-cairo configure flag Eugene Mah
2019-06-07 12:05 ` Noam Postavsky
2019-06-07 16:48   ` Alan Third [this message]
2019-06-07 18:18     ` Alan Third

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190607164826.GA48250@breton.holly.idiocy.org \
    --to=alan@idiocy.org \
    --cc=36115@debbugs.gnu.org \
    --cc=eugenemah@gmail.com \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.