From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v2] Add xwidget webkit support for macOS Cocoa Date: Tue, 4 Jun 2019 17:22:12 +0100 Message-ID: <20190604162212.GA23349@breton.holly.idiocy.org> References: <12fa256f-5322-8a47-e8d0-5430e0fef741@cs.ucla.edu> <20190603235121.15533-1-pcr910303@icloud.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="146338"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.12.0 (2019-05-25) Cc: emacs-devel@gnu.org To: Sungbin Jo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 04 18:25:44 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hYCFr-000btQ-RR for ged-emacs-devel@m.gmane.org; Tue, 04 Jun 2019 18:25:44 +0200 Original-Received: from localhost ([127.0.0.1]:54963 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYCFq-0007w6-On for ged-emacs-devel@m.gmane.org; Tue, 04 Jun 2019 12:25:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYCCa-00062O-VL for emacs-devel@gnu.org; Tue, 04 Jun 2019 12:22:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYCCY-0007vt-Rz for emacs-devel@gnu.org; Tue, 04 Jun 2019 12:22:20 -0400 Original-Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:38692) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hYCCX-0007t3-F6 for emacs-devel@gnu.org; Tue, 04 Jun 2019 12:22:18 -0400 Original-Received: by mail-wr1-x444.google.com with SMTP id d18so16490653wrs.5 for ; Tue, 04 Jun 2019 09:22:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=u41m7Wpsh0EMIvJJbKxxzfJ1NLOVqMBE0C9MJoSuqNY=; b=TxrBk+tJZpFiGSrLXrlqdXFLzpHmX16YeaDW3Izmvb0ZcbHRQSTvfTORsJLmAUeTuS E1jhrPqKO9QiZZHU6yI0JmPHvKVCXGaZxl47JBzBHhCPnmogvThD5EXzeD467tzGbU98 kBj4kwr3AH1+ORfir2xtilWxV8FD/YygeH9IgUX58y+SWd1gmgRmJD8jALiwXPatqNOl ItaxFGwaYlquYPfobJ1ZhrZP7Od7Ha3Qt7i/vrhSwqxjkWn6VRvK7z5vQIWJUOjjbhI7 3M7R2H97bmg7wmED2tGNJY/zaUj0x6LJ3hI6UyQ4rpLVlH3RO6TyN3TLqcscdzf8dYrJ e8nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=u41m7Wpsh0EMIvJJbKxxzfJ1NLOVqMBE0C9MJoSuqNY=; b=dg4kObaYJx5YL3uNBrmk70xoxHfr4BsRV4VL2JGIeEqfPiIlcoNjv/cYIKksm7K7VZ iq/FIBK/RkkMvuFvErjE1Kena5xcKtcb0HtIao7m3bzDCdrCF/qf5fUzHbPQSNwBOeAn cXJMonYkgT5/wx1ADmHqa4b5g4PGDUpQOWn3ebQF8VBe+q3KR/ZTJ2gfA8/SvbpCfr5r 6PQfh5JEatufkIP/mOhN51iQRaN3/j4GCem9SFltnYPG9n419HXVWSN7TlQAaoR1kFpr 19bDEEnoqmGK7B3WR2RjVtAgbKTSTOWUnTfRkA1dvxZ6F/zpMxrCW5D+6Tiqc7fGhMGV njpw== X-Gm-Message-State: APjAAAWqMN/zVFe2+o9BnRR5Ne8GqicQCmTshmBF9rqmFCEvQ5Mt1cOq oxRd8wd3CH8uzN/CoDx4Jl0= X-Google-Smtp-Source: APXvYqwGB4GveLwPsk7g/iUJMTGVZiLf/x8e+TU5IQUk6ukabWQZHkiKuValASDudvX/YxpCdDuyhg== X-Received: by 2002:a5d:52c7:: with SMTP id r7mr20131389wrv.110.1559665335199; Tue, 04 Jun 2019 09:22:15 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-9466-ad51-3729-a6b8.holly.idiocy.org. [2001:8b0:3f8:8129:9466:ad51:3729:a6b8]) by smtp.gmail.com with ESMTPSA id e5sm9032731wro.46.2019.06.04.09.22.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jun 2019 09:22:14 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20190603235121.15533-1-pcr910303@icloud.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237251 Archived-At: On Tue, Jun 04, 2019 at 08:51:20AM +0900, Sungbin Jo wrote: > --- > configure.ac | 34 +- > lisp/xwidget.el | 315 ++++++++++++---- > nextstep/templates/Info.plist.in | 12 +- > src/Makefile.in | 1 + > src/emacs.c | 2 +- > src/nsterm.m | 23 +- > src/nsxwidget.h | 80 ++++ > src/nsxwidget.m | 611 +++++++++++++++++++++++++++++++ > src/xwidget.c | 261 ++++++++++++- > src/xwidget.h | 50 ++- > 10 files changed, 1288 insertions(+), 101 deletions(-) > create mode 100644 src/nsxwidget.h > create mode 100644 src/nsxwidget.m This applies fine now. Thanks. I’ve only had a brief test and it appears to work, but I did something wrong the first time I tried it. M‐x xwidget-webkit-browse-url RET idiocy.org RET it silently fails to load the page, then try the same but with https://idiocy.org/ and it starts spewing lots of this message into the terminal: 2019-06-04 17:15:16.041 Emacs[38758:2115790] xwHasFocus: Error Domain=WKErrorDomain Code=4 "A JavaScript exception occurred" UserInfo={WKJavaScriptExceptionLineNumber=1, WKJavaScriptExceptionMessage=ReferenceError: Can't find variable: xwHasFocus, WKJavaScriptExceptionColumnNumber=11, WKJavaScriptExceptionSourceURL=undefined, NSLocalizedDescription=A JavaScript exception occurred} If I type in the full correct URL the first time it’s fine. -- Alan Third