all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: emacs-devel@gnu.org, rms@gnu.org, Kenichi Handa <handa@m17n.org>
Subject: Re: [handa@m17n.org: C indentation problem]
Date: Tue, 21 May 2019 10:32:54 +0000	[thread overview]
Message-ID: <20190521103254.GA4706@ACM> (raw)
In-Reply-To: <87muk7hc46.fsf@tcd.ie>

Hello, Basil.

Sorry I missed this post when you posted it at the end of April.

The issue goes back to 2006.  ;-)

On Tue, Apr 30, 2019 at 14:11:05 +0100, Basil L. Contovounesios wrote:
> Kenichi Handa <handa@m17n.org> writes:

[ .... ]

> > Ah!  Yes.  I personally prefer Emacs 21 style (perhaps just
> > because I used to it for long time).

> >> However, CC Mode 5.28 seems to me to indent like the Emacs 22 sources are
> >> indented, i.e. column 5, and 5.

> CC Mode 5.33.2 also indents "Emacs 22-style", i.e. to 5 columns, but the
> current sources, AFAICS, are indented to 2 columns, "Emacs 21-style".

More to the point, we no longer have knr declarations.

> >> I suggest the following: a new lineup function,
> >> c-lineup-gnu-DEFUN-intro-cont which would be active only in GNU style,
> >> and would give the offset knr-argdecl-intro (i.e. 5) for the lines
> >> between DEFUN's closing paren and the function's opening brace.  This new
> >> function would be tried only if the existing c-lineup-topmost-intro-cont
> >> returns nil.

> Shouldn't the now-existing c-lineup-gnu-DEFUN-intro-cont be changed
> accordingly, to indent to 2 columns instead of 5?

Seeing as how we don't have knr declarations any more, it seems senseless
now to indent with the CC Mode syntactic symbol knr-argdecl-intro, i.e.
5.  Instead c-basic-offset (2) seems right.

How about the following patch?



diff -r f9e4e46ed54d cc-align.el
--- a/cc-align.el	Mon May 20 12:34:51 2019 +0000
+++ b/cc-align.el	Tue May 21 10:24:11 2019 +0000
@@ -112,7 +112,7 @@
     (let (case-fold-search)
       (goto-char (c-langelem-pos langelem))
       (if (looking-at "\\<DEFUN\\>")
-	  (c-calc-offset '(knr-argdecl-intro))))))
+	  c-basic-offset))))
 
 (defun c-block-in-arglist-dwim (arglist-start)
   ;; This function implements the DWIM to avoid far indentation of


> >> Question:  Are there any other C macros, besides DEFUN, whose indentation
> >> is also broken at the moment?  (I do not know the C source at all well.)

> > All I noticed is the DEFUN case.

> I too have yet to notice a problem with other macros.

That's good.

> Thanks,

> -- 
> Basil

-- 
Alan Mackenzie (Nuremberg, Germany).



  parent reply	other threads:[~2019-05-21 10:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1FTnAc-0004Fk-15@fencepost.gnu.org>
2006-04-18 22:15 ` [handa@m17n.org: C indentation problem] Alan Mackenzie
2006-04-19  1:30   ` Kenichi Handa
2019-04-30 13:11     ` Basil L. Contovounesios
2019-05-20 13:51       ` Basil L. Contovounesios
2019-05-21 10:32       ` Alan Mackenzie [this message]
2019-05-21 10:57         ` Basil L. Contovounesios
2019-05-21 12:00           ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190521103254.GA4706@ACM \
    --to=acm@muc.de \
    --cc=contovob@tcd.ie \
    --cc=emacs-devel@gnu.org \
    --cc=handa@m17n.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.