From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Fri, 3 May 2019 18:18:56 +0200 Message-ID: <20190503161856.l3f5zor7n4app5l4@Ergus> References: <83mul18wpv.fsf@gnu.org> <20190407200514.2p6gfucdcdsrqe47@Ergus> <83ef6d8c40.fsf@gnu.org> <20190408085102.ozcuvs323ilfid7n@Ergus> <83bm1g8s02.fsf@gnu.org> <20190412134633.g47vybtpkwxyw7dq@Ergus> <834l73mir0.fsf@gnu.org> <20190501110808.27o64tawy2gyjocr@Ergus> <83sgtvn08w.fsf@gnu.org> <87ef5ffwv9.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="2650"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: Eli Zaretskii , emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 03 23:16:36 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hMfXc-0012u5-Bv for ged-emacs-devel@m.gmane.org; Fri, 03 May 2019 23:16:24 +0200 Original-Received: from localhost ([127.0.0.1]:43243 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMau5-0002NE-4c for ged-emacs-devel@m.gmane.org; Fri, 03 May 2019 12:19:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMatt-0002M7-FA for emacs-devel@gnu.org; Fri, 03 May 2019 12:19:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMats-0002t2-Jw for emacs-devel@gnu.org; Fri, 03 May 2019 12:19:05 -0400 Original-Received: from sonic302-20.consmr.mail.ir2.yahoo.com ([87.248.110.83]:36086) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMats-0002r8-E2 for emacs-devel@gnu.org; Fri, 03 May 2019 12:19:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1556900341; bh=6KMUl+52MEOKuotAE5FGAI2efaXwqIJHAL3dfz6KGzE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=WBo2ZGofxZDZg/ftBx4D8F4+R1BN+d61kELKmRytQ2q8iO8+pRsqwkko3sYMVbz7Yzf6WKNRCIkXd9mxt4emd78OzdKgrLaE3JF/D+4Zdidi/mmCekEaUxWpFTfuTl+cb3tEyrHVqMeI3e3kgkkB5vyjuIUhBRV7/hljMa5ufxwQZ8Xvk8cBdhXr6jQ7/5MRKUzTcvziVfYAbu4MlRkY7uW2kIhqRDI/KVjSkBCo7zSTa51iw+CV46Fr5OoVWgTs677NUv8JcFK9KS5YBXA3ihPAfZBOCIeLvp/kwYbHBAmIo1mRAZ/LhetZeZO/ePf4yyr72QC6zfu5C8jw/O2wLw== X-YMail-OSG: M2cJaCYVM1mjiKlDzrVoxqzbPvD5b.8z_vMqb62Y9y8UivXIV4jBbUfpjwajgWo iMW5mQj7q4cPV12CssYlDblj9KaKxlZR1nyVAa4Xcbcq3uqGEKWN7VCITDuhwBIq4QpfBK_y9TW6 s2TerMCUQqleUOOT7q5e5Wqef.GVgn8yQTLePXA6aoNaqyTajnoEiGRu3klBQqXF6ob2TGXk4EqP kfV9Jlj4GjPqq6gRBEWx.k66P5_.XEXF4oDE3Rkzsb0rqMrxAh_8Rj_3NJlP1oRMWpH6lIrdCSRN EMkGbQd2S__PCNLAhtJ6xKS9GOr_PyM_GWhrrH359uc9erwnbskj.vxFumEuw0QBrKjx.YO2K.JJ CIqVbpLhCx9E9S7wtrWsRUFAUYQ4oO8bMYsZkX2U_GO1qIruYMckzs8fve8TYDY4prk4fCvbNFog wSlSvEn0jE69stWJR4DEiRgL2lhyh_n_ksKUAPtjA2rpmO38HAHpELFcLIfAJO2PooAkaaqcGMck Idp0Fi7Mrd5AhEsVk3kPqdY6hcZ6lyPIwMi8tXK852Q8zmsI48K4HrVHR17SkZCnXI0KOjNXJooj 1xF0H7xmjCJjjgM.F8nU93a9tQjMWe4jeOUD0.1ZUHfbAf_dT7WMx3V0K6VgWJsz.IWy4wiT3paW FYCxlFT6fdYVvkq7m2HwNKbesVs4fWn4iwd5aIRoLVhMHEz0h177nGbbdGeOAiK0JGRNpB6pgAnX y8nROzDExzuQVyqMX.tK8lo3l0aCOnO6nmMmvmDzkQTWeSqeLBY8AqsYycR8btFYDRhB7ScdTnsR 8ulgQ6K1_aOY825xfO5yAHB8VqYMTIx.0gt3L5034Y Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ir2.yahoo.com with HTTP; Fri, 3 May 2019 16:19:01 +0000 Original-Received: from 84.88.50.33 (EHLO Ergus) ([84.88.50.33]) by smtp428.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 6b2b0fe5826236ac51dc3c3b82d31182; Fri, 03 May 2019 16:19:00 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87ef5ffwv9.fsf@tcd.ie> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 87.248.110.83 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236120 Archived-At: I agree, but I added the -face because someone highlighted in another mail that there was already a symbol called fill-column. So what should I do then?? Any way there are plenty of symbols ending in -face... So I thought is was a "relaxed" requirement. On Fri, May 03, 2019 at 03:14:50PM +0100, Basil L. Contovounesios wrote: >Eli Zaretskii writes: > >>> Date: Wed, 1 May 2019 13:08:08 +0200 >>> From: Ergus >>> Cc: emacs-devel@gnu.org >>> >>> +@item fill-column-face >> >> This face should be indexed, use @vindex for that. > >[...] > >>> +;; Definition stolen from display-line-numbers. >>> +(defface fill-column-face >>> + '((t :inherit (shadow default))) >>> + "Face for displaying fill column indicator line. >> ^^^^ >> I'd drop the "line" part. You allude to the shape of the indicator >> character, but it doesn't have to look like a line, and using "line" >> is confusing here. > >I'm not sure how closely this convention is followed in new code, but >FWIW the defface docs under (info "(elisp) Defining Faces") say: > > -- Macro: defface face spec doc [keyword value]... > This macro declares FACE as a named face whose default face spec is > given by SPEC. You should not quote the symbol FACE, and it should > not end in ???-face??? (that would be redundant). > ^^^^^^^^^^^^^^^^^^ > >Thanks, > >-- >Basil