From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#35468: [PATCH] Refactor draw_glyph_string on X and w32 Date: Wed, 1 May 2019 22:08:47 +0100 Message-ID: <20190501210847.GA74837@breton.holly.idiocy.org> References: <877ebeor2d.fsf@gmail.com> <83tveit5ph.fsf@gnu.org> <87pnp5oqu1.fsf@gmail.com> <877ebcogg4.fsf@gmail.com> <83sgu0rsue.fsf@gnu.org> <20190430201129.GA73973@breton.holly.idiocy.org> <837ebaqdme.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="103833"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.11.3 (2019-02-01) Cc: 35468@debbugs.gnu.org, agrambot@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 01 23:09:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hLwTY-000Qsy-Gt for geb-bug-gnu-emacs@m.gmane.org; Wed, 01 May 2019 23:09:12 +0200 Original-Received: from localhost ([127.0.0.1]:41420 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLwTX-0001Li-GQ for geb-bug-gnu-emacs@m.gmane.org; Wed, 01 May 2019 17:09:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59392) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLwTP-0001LQ-JP for bug-gnu-emacs@gnu.org; Wed, 01 May 2019 17:09:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLwTO-0001BU-JM for bug-gnu-emacs@gnu.org; Wed, 01 May 2019 17:09:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59748) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hLwTO-0001BM-FM for bug-gnu-emacs@gnu.org; Wed, 01 May 2019 17:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hLwTO-0001Df-6X for bug-gnu-emacs@gnu.org; Wed, 01 May 2019 17:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 May 2019 21:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35468 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35468-submit@debbugs.gnu.org id=B35468.15567449394679 (code B ref 35468); Wed, 01 May 2019 21:09:02 +0000 Original-Received: (at 35468) by debbugs.gnu.org; 1 May 2019 21:08:59 +0000 Original-Received: from localhost ([127.0.0.1]:45059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLwTK-0001DO-T7 for submit@debbugs.gnu.org; Wed, 01 May 2019 17:08:59 -0400 Original-Received: from mail-wr1-f50.google.com ([209.85.221.50]:41203) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLwTI-0001D9-Pf for 35468@debbugs.gnu.org; Wed, 01 May 2019 17:08:57 -0400 Original-Received: by mail-wr1-f50.google.com with SMTP id c12so213634wrt.8 for <35468@debbugs.gnu.org>; Wed, 01 May 2019 14:08:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Qpx5Ukui1/lSCZpTRkjKdwJ5YM0LJ8LXDUB0ISmyQEg=; b=lpt1fJtGZDqgCnsi7VcQv6Fm6w2idMUOe6gLNapFFZGTG1nePc2UgXNYQNMqiE+ey+ loas+J7KQqa4YwlGJRDVzOrxzfX481GOSlRUlhDUGXItie6xFlkhIz1pKo5peyNBBQht yLiAIDe/5hfHEpzqLvcaVej2y167Uhag8XdWDGVKVYK7b1VgMhkzzMPf02C8hTDCC6QQ 06O/UWnTmCZLRUWK0RmUpCfZ5fLeoEaTTqXyH8e0tfYOaD7OxIG56nyrdrJMFcRH3zKH Mcq0ahSsZeuVv4TLfXQxAyF49o5V+bXKaQ6ZhtY2bsshJtVcYxHDPPX6buYFIzv0cQ7Z hJbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=Qpx5Ukui1/lSCZpTRkjKdwJ5YM0LJ8LXDUB0ISmyQEg=; b=AaLFK9cgylBZjIvq7d1+eXcDkvAbQoZBMQumRxY19NLszr6XADnSVMKc2hS92D4Xwj m465KO0mLzyLgGYZHNL0CYTEsbvOBzmRKTbau3jwhX0VGzuTCJBOzSBQSKlfJJl3cM0h FRK01po/18RwbgKsIjmv71tVgvvRfjrZ1vWKt+UWG//1YnDBqxMaRvMGxeU3+//wsdMm 817skix0XwCpuKcKBez+UZiza1NmCCbSV4s+5N7rXOxVJnp7DWCoELAEV36ZDUquuJJI RLVpAH5tUEcfWGiTlfuzLqw60OgfP3RCxbq8vzMKLDA4l4rqqyN5gmbKxsac/WfJp2k9 QkqA== X-Gm-Message-State: APjAAAVRp0Y0ssQVRVEqkARykJKkw12K/JX62qxW3pgyJoI41wkpQiqH Sle8G/CAG/rl3c3bgAvJ4MY= X-Google-Smtp-Source: APXvYqwCb+StU9zM57NwhakKidD1gA9DCep1uk7Rvh3OeSQxp3LZCLhji4shx7Gf037lNV3b2exNgg== X-Received: by 2002:adf:fcc8:: with SMTP id f8mr126515wrs.250.1556744930832; Wed, 01 May 2019 14:08:50 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-c8db-4b16-8787-1926.holly.idiocy.org. [2001:8b0:3f8:8129:c8db:4b16:8787:1926]) by smtp.gmail.com with ESMTPSA id z5sm7090058wre.70.2019.05.01.14.08.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 May 2019 14:08:49 -0700 (PDT) Content-Disposition: inline In-Reply-To: <837ebaqdme.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158606 Archived-At: On Wed, May 01, 2019 at 08:38:17PM +0300, Eli Zaretskii wrote: > > Date: Tue, 30 Apr 2019 21:11:29 +0100 > > From: Alan Third > > Cc: Alex Gramiak , 35468@debbugs.gnu.org > > > > > > if (s->hl == DRAW_MOUSE_FACE) > > > > { > > > > face = FACE_FROM_ID_OR_NULL (s->f, > > > > MOUSE_HL_INFO (s->f)->mouse_face_face_id); > > > > if (!face) > > > > face = FACE_FROM_ID (s->f, MOUSE_FACE_ID); > > > > } > > > > else > > > > face = s->face; > > > > > > I don't know why this is TRT, either. We could ask Alan to look into > > > this, or we could simply remove that, as other terminals don't use > > > box_line_width from the mouse face, they use s->face instead. > > > > A quick test doesn’t turn up any immediate issues with removing this, > > but I’m unsure in what circumstances DRAW_MOUSE_FACE would be in use. > > E.g., when you hover the mouse pointer above the mouse-sensitive > portions of the mode line. It looks exactly the same to me with or without the code. Perhaps I’d see something different if I was using some theme which defined mouse face differently. I really don’t see any reason why NS should behave differently from the other terms here. -- Alan Third