From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#35468: [PATCH] Refactor draw_glyph_string on X and w32 Date: Tue, 30 Apr 2019 21:11:29 +0100 Message-ID: <20190430201129.GA73973@breton.holly.idiocy.org> References: <877ebeor2d.fsf@gmail.com> <83tveit5ph.fsf@gnu.org> <87pnp5oqu1.fsf@gmail.com> <877ebcogg4.fsf@gmail.com> <83sgu0rsue.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="160903"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.11.3 (2019-02-01) Cc: 35468@debbugs.gnu.org, Alex Gramiak To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 30 22:15:30 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hLZ9x-000fbg-TL for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Apr 2019 22:15:26 +0200 Original-Received: from localhost ([127.0.0.1]:52809 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLZ9w-0007F1-S3 for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Apr 2019 16:15:24 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49851) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLZ6h-0004mf-Ji for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2019 16:12:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLZ6g-0008Gx-Kt for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2019 16:12:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57146) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hLZ6g-0008Gs-H9 for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2019 16:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hLZ6g-0002rI-A2 for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2019 16:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Apr 2019 20:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35468 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35468-submit@debbugs.gnu.org id=B35468.155665510110958 (code B ref 35468); Tue, 30 Apr 2019 20:12:02 +0000 Original-Received: (at 35468) by debbugs.gnu.org; 30 Apr 2019 20:11:41 +0000 Original-Received: from localhost ([127.0.0.1]:42457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLZ6K-0002qf-QG for submit@debbugs.gnu.org; Tue, 30 Apr 2019 16:11:41 -0400 Original-Received: from mail-wr1-f42.google.com ([209.85.221.42]:44155) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLZ6I-0002qS-TU for 35468@debbugs.gnu.org; Tue, 30 Apr 2019 16:11:39 -0400 Original-Received: by mail-wr1-f42.google.com with SMTP id c5so22425944wrs.11 for <35468@debbugs.gnu.org>; Tue, 30 Apr 2019 13:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=2yBRKYIq6i9wS7EgfQbxL75jE6e3mlRfkLgSfOhZ9bQ=; b=PjaAYtlKugqiSA9Dz9sSctWMsw3PjybxA7PkJSfdC6Pbc+I0/xqg9iv1WQvP72FzUm 4geD7x4iDKzFh/zppjQKT3t2zX9mLdJLGPRSQyy7twrLpJ+fRPuGt6Ui++eNPHIbVCLW MdBbmcwsA43y5GciU0ndrO0PVAtULKvqjOlIvtOFR9rF2SKX2XjrnJq18xW0Q3NOQlqm ICeyTvHHl2q5l63SQnFxbmWe7YeXwoERU9gUbj3hoTFccr/80M39eAxNi3UCBOmakgQY 4RKSV/hfNdFhLidWKUN5Lx25M6EdyriQpi/iHf1TbzDbqs72gLxJkbFlO5FHQ2+IDBZU 2P4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=2yBRKYIq6i9wS7EgfQbxL75jE6e3mlRfkLgSfOhZ9bQ=; b=dS2QWplhlr6qvPrAsNIdleu+j5p49SmzMAifyqqc+9LFzizAfqBnc/f4JbDxBj8aF0 zXFe9GLGunGxpAO8ZhNOss6cVfpaKqpT3WBx2MSZUV1gMmpZBRqes4gUfGBiFircLGap pkrN4gviODtyYp6OEfP2BXwFokg8vh5jxLR2H4psmt+vknHwOV/s8M2OfPq9LyEp1o17 6TCwSEnXnVOw2QIn2RaQRj6NySVih9XvZoTE0QFKRW9FpRRQgj/P2YYMq9QoYduwRbK9 V1DUgpQHgvW6GbF7mQB0KA/9OFEwfYVY7V8TkZAH7CGugfEcfrLOcocSLS8orQU6Kev6 k9aA== X-Gm-Message-State: APjAAAXmQn2R6z2E6o7N77uw6Z8OnPLWb74xs4Zjeu6njvrZCaSx3hJB kSQI6PmPUcfVW2kMWF57G+4= X-Google-Smtp-Source: APXvYqyhANqB368q3XYnex8zU1qFVf5gig++trzYVyjjy6DAiAaGefyhLBZp2pDxdKhCPoiLc+V6iQ== X-Received: by 2002:a5d:4cd1:: with SMTP id c17mr11292886wrt.231.1556655093003; Tue, 30 Apr 2019 13:11:33 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-c8db-4b16-8787-1926.holly.idiocy.org. [2001:8b0:3f8:8129:c8db:4b16:8787:1926]) by smtp.gmail.com with ESMTPSA id 67sm4904057wmz.41.2019.04.30.13.11.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Apr 2019 13:11:31 -0700 (PDT) Content-Disposition: inline In-Reply-To: <83sgu0rsue.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158532 Archived-At: On Tue, Apr 30, 2019 at 07:59:37AM +0300, Eli Zaretskii wrote: > > From: Alex Gramiak > > Cc: 35468@debbugs.gnu.org > > Date: Mon, 29 Apr 2019 11:43:23 -0600 > > > > It doesn't work for NS partially because of the following section only > > present in the NS equivalent of gui_draw_glyph_string_box. Would you be > > okay with putting this in the generic version inside a FRAME_NS_P (s->f) > > check? I don't know why only NS has this, though... > > > > if (s->hl == DRAW_MOUSE_FACE) > > { > > face = FACE_FROM_ID_OR_NULL (s->f, > > MOUSE_HL_INFO (s->f)->mouse_face_face_id); > > if (!face) > > face = FACE_FROM_ID (s->f, MOUSE_FACE_ID); > > } > > else > > face = s->face; > > I don't know why this is TRT, either. We could ask Alan to look into > this, or we could simply remove that, as other terminals don't use > box_line_width from the mouse face, they use s->face instead. A quick test doesn’t turn up any immediate issues with removing this, but I’m unsure in what circumstances DRAW_MOUSE_FACE would be in use. -- Alan Third