From: Konstantin Kharlamov <Hi-Angel@yandex.ru>
To: 35368@debbugs.gnu.org
Subject: bug#35368: [PATCH v2] Do potentially destructive operations in prepare-commit-msg
Date: Sun, 21 Apr 2019 23:17:30 +0300 [thread overview]
Message-ID: <20190421201730.30905-1-Hi-Angel@yandex.ru> (raw)
In-Reply-To: <20190421200313.26202-1-Hi-Angel@yandex.ru>
* build-aux/git-hooks/prepare-commit-msg: if someone occasionally puts
Signed-off line, it will likely get there through -s option of git.
Exploit this fact to abort before a user got a chance to type commit
message.
---
v2: instead of "magic" $1 use $COMMIT_MSG_FILE
autogen.sh | 2 +-
build-aux/git-hooks/prepare-commit-msg | 59 ++++++++++++++++++++++++++
2 files changed, 60 insertions(+), 1 deletion(-)
create mode 100755 build-aux/git-hooks/prepare-commit-msg
diff --git a/autogen.sh b/autogen.sh
index 40d0c37b11b..c85ecfecac6 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -332,7 +332,7 @@ hooks=
tailored_hooks=
sample_hooks=
-for hook in commit-msg pre-commit; do
+for hook in commit-msg pre-commit prepare-commit-msg; do
cmp -- build-aux/git-hooks/$hook "$hooks/$hook" >/dev/null 2>&1 ||
tailored_hooks="$tailored_hooks $hook"
done
diff --git a/build-aux/git-hooks/prepare-commit-msg b/build-aux/git-hooks/prepare-commit-msg
new file mode 100755
index 00000000000..f35f1dcbbc4
--- /dev/null
+++ b/build-aux/git-hooks/prepare-commit-msg
@@ -0,0 +1,59 @@
+#!/bin/sh
+# Check the format of GNU Emacs change log entries.
+
+# Copyright 2019 Free Software Foundation, Inc.
+
+# This file is part of GNU Emacs.
+
+# GNU Emacs is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# GNU Emacs is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
+
+COMMIT_MSG_FILE=$1
+COMMIT_SOURCE=$2
+SHA1=$3
+
+# Prefer gawk if available, as it handles NUL bytes properly.
+if type gawk >/dev/null 2>&1; then
+ awk=gawk
+else
+ awk=awk
+fi
+
+# Use a UTF-8 locale if available, so that the UTF-8 check works.
+# Use U+00A2 CENT SIGN to test whether the locale works.
+cent_sign_utf8_format='\302\242\n'
+cent_sign=`printf "$cent_sign_utf8_format"`
+print_at_sign='BEGIN {print substr("'$cent_sign'@", 2)}'
+at_sign=`$awk "$print_at_sign" </dev/null 2>/dev/null`
+if test "$at_sign" != @; then
+ at_sign=`LC_ALL=en_US.UTF-8 $awk "$print_at_sign" </dev/null 2>/dev/null`
+ if test "$at_sign" = @; then
+ LC_ALL=en_US.UTF-8
+ else
+ LC_ALL=C
+ fi
+ export LC_ALL
+fi
+
+exec $awk -v at_sign="$at_sign" -v cent_sign="$cent_sign" -v file="$COMMIT_MSG_FILE" '
+ /^Signed-off-by: / {
+ print "'\''Signed-off-by:'\'' in commit message"
+ status = 1
+ }
+ END {
+ if (status != 0) {
+ print "Commit aborted; please see the file 'CONTRIBUTE'"
+ }
+ exit status
+ }
+' <"$COMMIT_MSG_FILE"
--
2.21.0
next prev parent reply other threads:[~2019-04-21 20:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-21 20:03 bug#35368: [PATCH] Do potentially destructive operations in prepare-commit-msg Konstantin Kharlamov
2019-04-21 20:17 ` Konstantin Kharlamov [this message]
2019-05-14 17:33 ` bug#35368: [PATCH v2] " npostavs
2019-05-14 21:22 ` Konstantin Kharlamov
2019-05-14 22:09 ` Noam Postavsky
2019-05-14 22:15 ` Konstantin Kharlamov
2019-05-14 22:26 ` bug#35368: [PATCH v3] " Konstantin Kharlamov
2019-05-15 17:40 ` npostavs
2019-05-15 21:25 ` bug#35368: [PATCH v4] " Konstantin Kharlamov
2019-05-17 0:35 ` Noam Postavsky
2019-05-17 0:39 ` Konstantin Kharlamov
2019-05-15 21:28 ` bug#35368: [PATCH v3] " Konstantin Kharlamov
[not found] ` <handler.35368.B.155587702222113.ack@debbugs.gnu.org>
2019-04-23 9:57 ` bug#35368: Acknowledgement ([PATCH] Do potentially destructive operations in prepare-commit-msg) Konstantin Kharlamov
2019-04-23 10:40 ` Eli Zaretskii
2019-04-23 10:43 ` Basil L. Contovounesios
2019-04-23 11:00 ` Konstantin Kharlamov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190421201730.30905-1-Hi-Angel@yandex.ru \
--to=hi-angel@yandex.ru \
--cc=35368@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.