From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: CHECK_STRUCTS/dmpstruct.h mechanism is broken. Date: Wed, 10 Apr 2019 16:22:03 +0000 Message-ID: <20190410162203.GA4009@ACM> References: <20190228202146.GC4686@ACM> <20190228205955.GD4686@ACM> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="44138"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Daniel Colascione , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 10 18:22:27 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hEFzX-000BNp-Mv for ged-emacs-devel@m.gmane.org; Wed, 10 Apr 2019 18:22:27 +0200 Original-Received: from localhost ([127.0.0.1]:34261 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEFzW-00029g-FK for ged-emacs-devel@m.gmane.org; Wed, 10 Apr 2019 12:22:26 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEFzP-00029P-D3 for emacs-devel@gnu.org; Wed, 10 Apr 2019 12:22:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEFzL-0000Jw-0m for emacs-devel@gnu.org; Wed, 10 Apr 2019 12:22:18 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:39078 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1hEFzG-0000EX-Fh for emacs-devel@gnu.org; Wed, 10 Apr 2019 12:22:13 -0400 Original-Received: (qmail 53620 invoked by uid 3782); 10 Apr 2019 16:22:04 -0000 Original-Received: from acm.muc.de (p4FE15EEB.dip0.t-ipconnect.de [79.225.94.235]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 10 Apr 2019 18:22:04 +0200 Original-Received: (qmail 30143 invoked by uid 1000); 10 Apr 2019 16:22:03 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235225 Archived-At: Hello, Paul. On Tue, Apr 09, 2019 at 15:47:17 -0700, Paul Eggert wrote: > On 3/4/19 6:17 PM, Paul Eggert wrote: > > On 2/28/19 12:59 PM, Alan Mackenzie wrote: > >> is all this really needed? Is pdumper.c really that fragile, > >> that it can't cope with changes in certain structs? > > No, it's not needed, and in my experience the mechanism's costs far > > exceed any benefit. > No further comment and the mechanism just bit me again, so I installed > the attached patch to disable it. Why? Completely removing this mechanism seems very heavy handed. All that was needed to disable it was a single line change to set CHECK_STRUCTS to zero. You would have got further comment if you'd proposed a patch, rather than just a vague idea that might or might not have been followed through. Discussing the merits of a patch is always best done before committing it to master, not afterwards. What does Daniel say? > We can reenable it later if needed (which I hope won't happen....). Funnily enough, it was of use to me recently when it reminded me to amend dump_subr after extending struct subr. My main problem with this mechanism was the vagueness of the error messages it generated and of the comment in the code they pointed at, which wasted lots of time. Those defects have since been fixed. > >>From 891e507d06c3bfcd9ac181de6bb0ff9c27dfa4aa Mon Sep 17 00:00:00 2001 > From: Paul Eggert > Date: Tue, 9 Apr 2019 15:42:10 -0700 > Subject: [PATCH] Remove dmpstruct.h > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > The hassles of updating the dmpstruct.h-using code bit me again. > These updates are more trouble than they???re worth. See: > https://lists.gnu.org/r/emacs-devel/2019-03/msg00122.html > As I???m the main person who???s made changes in this area since > dmpstruct.h was introduced, I???m the most motivated to clean up > the situation. > * make-dist (possibly_non_vc_files): Remove src/dmpstruct.h. > * src/Makefile.in (dmpstruct_headers, dmpstruct.h): Remove. > (pdumper.o): Do not depend on dmpstruct.h. > (mostlyclean): Do not remove dmpstruct.h. > * src/dmpstruct.awk: Remove. > * src/pdumper.c: Do not include dmpstruct.h. > (CHECK_STRUCTS): Remove. All uses removed. > --- > .gitignore | 1 - > make-dist | 2 +- > src/Makefile.in | 10 +----- > src/dmpstruct.awk | 45 ------------------------ > src/pdumper.c | 89 ----------------------------------------------- > 5 files changed, 2 insertions(+), 145 deletions(-) > delete mode 100755 src/dmpstruct.awk [ .... ] -- Alan Mackenzie (Nuremberg, Germany).