From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Sun, 7 Apr 2019 20:19:25 +0200 Message-ID: <20190407181925.w3aztx44g5drtww2@Ergus> References: <83r2agbhwv.fsf@gnu.org> <20190405173010.snavjhxrmmufwp54@Ergus> <83h8bcb7ce.fsf@gnu.org> <20190405200319.jfwt7lgevas556id@Ergus> <834l7bbp9a.fsf@gnu.org> <83k1g79smt.fsf@gnu.org> <20190406152014.zykyiakddmwsmkko@Ergus> <83a7h39l8l.fsf@gnu.org> <20190406185936.ndw74l5ysowmoihf@Ergus> <837ec79cme.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="62516"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 07 20:19:48 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDCOQ-000G53-1c for ged-emacs-devel@m.gmane.org; Sun, 07 Apr 2019 20:19:46 +0200 Original-Received: from localhost ([127.0.0.1]:42090 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDCOO-0004FA-Re for ged-emacs-devel@m.gmane.org; Sun, 07 Apr 2019 14:19:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDCOG-0004F3-RP for emacs-devel@gnu.org; Sun, 07 Apr 2019 14:19:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDCOF-0002ja-Up for emacs-devel@gnu.org; Sun, 07 Apr 2019 14:19:36 -0400 Original-Received: from sonic314-20.consmr.mail.ir2.yahoo.com ([77.238.177.146]:45784) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hDCOF-0002ix-DH for emacs-devel@gnu.org; Sun, 07 Apr 2019 14:19:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1554661173; bh=SplGafD/HGeS3WPWxhYTxJ72njPDQY3Gmrzluu7t9yQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=LQEpufw/dBrHglQ+e1l0JGp0KgGbajDQAcwnQAYl6YfD1wDN/la0k03uIyoEcnpuls0zZGwIC0uKWE+Euh7QyR3LDabihT52yQxdSvE5wsRnGXqP/AMcYWJzQooBk4OpPgIdMvZmYWIQwkc8uL1jO54SglwzuWDA0aWY9nLbmKczuinF+1P3zvgBs2gdzquyBhIzREm/JtKQDP45/K0SmOsRBDASaNNGop1Se2C67ZobKjswfrlSd6JEponzex+v/G+WEMbjxnzcOelc20FtVlT+GIW//FgN0PsDJKxMU9MpNGWO+6Eppf6k9I9NQ72rhG9NRqqO64uYsiLahHks8w== X-YMail-OSG: GgQeyTwVM1mdzWVfe.DaZfex8skoGr0_7UowjHNflo0dMP6UIogZJv4yRDgOLK7 6zZrYd7Baqp6uAxwwzyDV0ZyTNqHOENAvnyLIV28bF4Xa7G2u_.lhqLvxhmpXHLoZJjVrbXnAY2F fHWPMFY0yo5h0fWOTXiE2ejiqobYBItRhpFqS.9sg3mTJ2Jdf3dXnNhFiJ148nrkKAnAJ0mnrPtk 95wJrZRvjqVC.uO2eryvFC0nKwHK5mtLkqP9knOSxcJzXi0ASmurp6NYJ6ijXpwBvpSNu96jGi82 3apvUzBPsxey.Ufs1aM9f8OpaGH1l.LLlAGfgYqakKh_tmJsvGMvHEd_UiV9IREUvgix6DwbOdD0 Q.7gZC7jGU7SzqRIsO_tP6sGn5Mb8zD6MIuZJF.THbxPVQSY8hgYvxCIF3sAr1DKba9_M1DMemux dYdi6rsUj8wWdUZjTU8_NH_OYZD4KZgy9X3Sc24oD7DopMnWCSXgqJs3brOm8AL3eujo52B.RGNP az.4f7pi3VUsz4RgtR.MB7KEiLoh3udrtv_RLpN7gKWhiK.utPT5JyeaUoo9J8v_3EdO3Gdr.hG_ 4ckr.O_Rq06LqGw7Xlv0qL12bPMtxmbsl7fk9Vd9zxQ9CxIJTfvihuCbfmWD5h2VtfGBMgEt.PaL Zabwh5.u8NVvyV19CSIzWZ51rkQSVlqxrNEBSZYlYNt8vpL1kIyWVu98sr.Tr_XNg.mNwkWyHc1I Ue78paFTMsAU_1JqHSjq6UonLgLuRLbZlqUBIezvrllpHBW1JJZ0lBwAgsMxUfJ3DDLMmzMMCM8E 6_oqY5Hn7ymoPBaWI765iiIWuVnelfObUP2iarowH1 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ir2.yahoo.com with HTTP; Sun, 7 Apr 2019 18:19:33 +0000 Original-Received: from 2.152.205.184.dyn.user.ono.com (EHLO Ergus) ([2.152.205.184]) by smtp413.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 0f69b35cceaf83db64d0fdfbf3dd89b9; Sun, 07 Apr 2019 18:19:28 +0000 (UTC) Content-Disposition: inline In-Reply-To: <837ec79cme.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.177.146 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235078 Archived-At: Hi all: I have been testing all the latest changes with the display-fci-mode and I have just found that the display-fill-column-indicator variable (and the others) are not buffer local anymore after the latest changes. So I cannot enable the mode for some buffers and not for others. As in display-line-numbers this works because there are still the Fmake_variable_buffer_local (Qdisplay_line_numbers); I tested customize-variable for display-line-numbers variables and it looks like setting in that way doesn't work as it was happening to display-fill-column-indicator yesterday. If I set any of those with set-variable it works. So it is exactly the same problem I had on yesterday. So the problem seems to be somewhere else. Any suggestion? On Sat, Apr 06, 2019 at 10:07:05PM +0300, Eli Zaretskii wrote: >> Date: Sat, 6 Apr 2019 20:59:36 +0200 >> From: Ergus >> Cc: emacs-devel@gnu.org >> >> I am wondering if there is a way to put conditionals there, because the >> redisplay needs to be triggered only if one of the variables is already >> non-nil and we need to redisplay if we change fill-column only if >> display-fill-column-indicator-column is t. Similar thing should happen >> for display-line-numbers right? > >I don't see why we should bother. These variables change only rarely, >so it isn't like they will trigger redisplay frequent enough to be a >problem. > >Btw, if you mean you added display-fill-column-indicator-* variables >to the list in frame.el, I don't think I see that. Did I miss >something? >