From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.bugs Subject: bug#35062: [PATCH v3 1/3] Remove redundant comparison Date: Sun, 7 Apr 2019 05:13:29 +0300 Message-ID: <20190407021331.948-1-Hi-Angel@yandex.ru> References: <1554071761.31929.0@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="67317"; mail-complaints-to="usenet@blaine.gmane.org" To: 35062@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 07 04:14:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hCxJz-000HNx-R3 for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Apr 2019 04:14:11 +0200 Original-Received: from localhost ([127.0.0.1]:33142 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCxJy-0005BR-Ll for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Apr 2019 22:14:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46203) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCxJr-0005BI-CT for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2019 22:14:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hCxJq-00048L-Dt for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2019 22:14:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34094) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hCxJq-00048F-6l for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2019 22:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hCxJp-0005gE-TN for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2019 22:14:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <1554071761.31929.0@yandex.ru> Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Apr 2019 02:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35062 X-GNU-PR-Package: emacs Original-Received: via spool by 35062-submit@debbugs.gnu.org id=B35062.155460322621780 (code B ref 35062); Sun, 07 Apr 2019 02:14:01 +0000 Original-Received: (at 35062) by debbugs.gnu.org; 7 Apr 2019 02:13:46 +0000 Original-Received: from localhost ([127.0.0.1]:47633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCxJa-0005fC-Dl for submit@debbugs.gnu.org; Sat, 06 Apr 2019 22:13:46 -0400 Original-Received: from forward100p.mail.yandex.net ([77.88.28.100]:50387) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCxJY-0005et-LT for 35062@debbugs.gnu.org; Sat, 06 Apr 2019 22:13:45 -0400 Original-Received: from mxback3o.mail.yandex.net (mxback3o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::1d]) by forward100p.mail.yandex.net (Yandex) with ESMTP id 5968759803FA for <35062@debbugs.gnu.org>; Sun, 7 Apr 2019 05:13:38 +0300 (MSK) Original-Received: from smtp1j.mail.yandex.net (smtp1j.mail.yandex.net [2a02:6b8:0:801::ab]) by mxback3o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id e2Lo7Smggu-DcECNUQw; Sun, 07 Apr 2019 05:13:38 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1554603218; bh=37fN331rqkG+0Ws3LzgjIUsoFXKILB1TC4YOgoJFN7k=; h=Subject:To:From:Date:Message-Id; b=EmS2X/+q6mC6Qlt3nfTjHr8hiFtDz5zE6W6p+CvmoGlvylkPmbu5D/345lqcCNLFQ FI0UNqR2g6DwL13LDupQiqZApUBK8C8TtiydKiJX+Hg6Pmta3OQQCwzmsYpGIO9kQ2 NWF99+v9J1Wbd6wRNYgfajPDH2pySWRquP0WkblU= Authentication-Results: mxback3o.mail.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: by smtp1j.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id pCSJWT6WkI-Dbi8PJCs; Sun, 07 Apr 2019 05:13:37 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) X-Mailer: git-send-email 2.21.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157296 Archived-At: * src/xterm.c (x_set_frame_alpha): due to preceding checks it is bound to be 0 ≤ alpha ≤ 1. (Bug#35062) --- v3: mention functions changed in commit messages, mention the bug number, and don't mention that it fixes a warning since intention of changes is clear either way. src/xterm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xterm.c b/src/xterm.c index f90d6713b02..e8f1e576a38 100644 --- a/src/xterm.c +++ b/src/xterm.c @@ -931,7 +931,7 @@ x_set_frame_alpha (struct frame *f) return; else if (alpha > 1.0) alpha = 1.0; - else if (0.0 <= alpha && alpha < alpha_min && alpha_min <= 1.0) + else if (alpha < alpha_min && alpha_min <= 1.0) alpha = alpha_min; opac = alpha * OPAQUE; -- 2.21.0