From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Sat, 6 Apr 2019 21:51:35 +0200 Message-ID: <20190406195135.f63rtgko23ko7yu3@Ergus> References: <83r2agbhwv.fsf@gnu.org> <20190405173010.snavjhxrmmufwp54@Ergus> <83h8bcb7ce.fsf@gnu.org> <20190405200319.jfwt7lgevas556id@Ergus> <834l7bbp9a.fsf@gnu.org> <83k1g79smt.fsf@gnu.org> <20190406152014.zykyiakddmwsmkko@Ergus> <83a7h39l8l.fsf@gnu.org> <20190406185936.ndw74l5ysowmoihf@Ergus> <837ec79cme.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="71534"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 06 21:52:25 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hCrMV-000IRw-IT for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2019 21:52:23 +0200 Original-Received: from localhost ([127.0.0.1]:58412 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCrMU-00027A-KN for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2019 15:52:22 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCrLt-000274-P3 for emacs-devel@gnu.org; Sat, 06 Apr 2019 15:51:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hCrLs-0000pb-PJ for emacs-devel@gnu.org; Sat, 06 Apr 2019 15:51:45 -0400 Original-Received: from sonic305-20.consmr.mail.ir2.yahoo.com ([77.238.177.82]:39518) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hCrLs-0000nb-Gl for emacs-devel@gnu.org; Sat, 06 Apr 2019 15:51:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1554580302; bh=TA9OGfsPxcI9VV3cs3X415U5M7XRUJzouRCZ1VclexM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=NQuHLwmFW25c6rK8jBd/81qi2cm7Rzn/92BPFlTEUg3Va9pcYtie57Hr0vRSYhTTSQ4aTF24/Mx0TEgwciaYaHVkiaT0gckEa01jTKOxIsoTYUGYaSBZ19P7pYIdlb2qhkmff4httsWLfx/gqxWoZxSg0bKsV3bR3iA3Mz1Ir4LCfLTe9Xv4sv/QqVfWFC3EIV8jC3VDIoawPGyIYARucEjHVox4qp1/LgV4+fiwOLdDnJ1/DG4Hln6PYlnbuelQizy/bM1t0wu/xDyHU5SL4iLo6g42D8rgpoSogfiGmyCJ7P4Eaiu073HLCgHz503Z1gNjp9XPdXNdbip0kUxfMw== X-YMail-OSG: dUrvRmwVM1k3R1Z07gSaZHD.MYz2wCMOdJRNrxwiXDrchoLVjahZOREU8bHmt5n 5Fz4VzTFT9nYK6WRSdZcNLxCyVvTMSZqf2fxdONgQPpIgLCScU7jo1box7HY5JTQDbfxOKDGX6i5 wd3Z9tbgLqvCRhzSraRwLkqgWt6yKn_wasci9F5jI2ECWxs_CovS4k0MF8A0u2.KFL8DDC8AI0mf W09AgwstHSVh1DfSyFb6S8loNmsWJkIpnMrRT2Jhyrf_jfrJNHI45lsxZnK5c5OWQvDK8HqNIZuV MCnwPDm56WKvUBPl_b6ZMFqrvO152jymGjePmTctI7zNGXFjVN3MDk9JhD_V.VH8uvM1GAcqJLXt ggVJn0itegHX_hXPpBNuy5av.N5yW6vKvBN7hmLD_Cg.mK7Q7ROujfxSJvaKMSq_._wIlX4WRlrO JFTLE9VxP71FJbVCdSkSvnYD7ym4pcfUrB.buMsfzFKLjqQcOeYYfpz2DnOhxGLD9dKDDZvfeDZb b_E3GldXxJ6eTK98XgeoUxTwbwozZnYBE1qRiGNUMJ176.HXcA9R.w4PA8H0IueS8FqraS7Im4S. GoUd6Bqjf3v2r4eIy5h6QH1alLJEJb2XKCH0ialoeanr4svF2EyU1ioGYUDqcQzGD_YVGxtGgk6V J6kpxfAlk6Fv4q9ZVZxHCvjX.Xvu.zGFeq_OYTW3EHCeVsaPxDaoO4Nm0tFje3JI4L4iXZLpBSnC x523d5zOiS8wn_PkVp1z14UjgmkGw5OoDaz4Fmf2SZVSBGUAgxGjgbIbaRrj5FEE.1o3WwUluorV _2ph4zBLKdDOJ8bt1S3V5Cq7xE9lym4szDQ7_sZ6Bj Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ir2.yahoo.com with HTTP; Sat, 6 Apr 2019 19:51:42 +0000 Original-Received: from 2.152.205.184.dyn.user.ono.com (EHLO Ergus) ([2.152.205.184]) by smtp430.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID c946324415d783c63e6b11b0a639e9fc; Sat, 06 Apr 2019 19:51:37 +0000 (UTC) Content-Disposition: inline In-Reply-To: <837ec79cme.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.177.82 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235042 Archived-At: On Sat, Apr 06, 2019 at 10:07:05PM +0300, Eli Zaretskii wrote: >> Date: Sat, 6 Apr 2019 20:59:36 +0200 >> From: Ergus >> Cc: emacs-devel@gnu.org >> >> I am wondering if there is a way to put conditionals there, because the >> redisplay needs to be triggered only if one of the variables is already >> non-nil and we need to redisplay if we change fill-column only if >> display-fill-column-indicator-column is t. Similar thing should happen >> for display-line-numbers right? > >I don't see why we should bother. These variables change only rarely, >so it isn't like they will trigger redisplay frequent enough to be a >problem. > >Btw, if you mean you added display-fill-column-indicator-* variables >to the list in frame.el, I don't think I see that. Did I miss >something? Sorry, I removed and then reinserted, but forgot to push the last commit.