From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Sat, 6 Apr 2019 20:59:36 +0200 Message-ID: <20190406185936.ndw74l5ysowmoihf@Ergus> References: <835zrsd670.fsf@gnu.org> <20190405150404.bm2d6wjtivwyesek@Ergus> <83r2agbhwv.fsf@gnu.org> <20190405173010.snavjhxrmmufwp54@Ergus> <83h8bcb7ce.fsf@gnu.org> <20190405200319.jfwt7lgevas556id@Ergus> <834l7bbp9a.fsf@gnu.org> <83k1g79smt.fsf@gnu.org> <20190406152014.zykyiakddmwsmkko@Ergus> <83a7h39l8l.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="117013"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 06 21:00:35 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hCqYM-000UF9-S4 for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2019 21:00:35 +0200 Original-Received: from localhost ([127.0.0.1]:57981 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCqYG-0007cV-OB for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2019 15:00:28 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCqXb-0007cN-Ao for emacs-devel@gnu.org; Sat, 06 Apr 2019 14:59:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hCqXa-0006aZ-5h for emacs-devel@gnu.org; Sat, 06 Apr 2019 14:59:47 -0400 Original-Received: from sonic304-22.consmr.mail.ir2.yahoo.com ([77.238.179.147]:40451) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hCqXZ-0006a1-Qq for emacs-devel@gnu.org; Sat, 06 Apr 2019 14:59:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1554577184; bh=kphUFZZQdovpY4p1doDKgqe+hQdpC0WL7enWVky8c1U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=TOKS4prkpWa0uH7OTDykiSv8xP/wTYWFCSqBsWj91qrPc4f+JFJqCE/Tndh6w3t2MauxOraxY8w9OcmJ1NBrB+GCYs+zdEkCSgZYQri4GbvJLnqpMYDJO3jfqV8Cy2d3QWrzfuMwHcUSrWyIJ9W8vJNepXx+wVvmLiE+PNAHsxxWRCNhsG43FFw4mcQYw4ynjF3mHMaz6EJINLTOrcvGp9nUQOIMqxtWPyK6C4Ov0TrIjVFEQnXZfkreleYNSmGfRWM0OGFd3CjUhSy9khbkxpUiA0/M7ES6jJKcqOwvtUq4xa2Ltv7skmm5M/7sjhIhIenMqbthHKzju3kEnJY5gg== X-YMail-OSG: ylB7MHoVM1kBaYCpDKG6qJofpUv9IYkgQMAWrlr114y5CN8WKvAGXHA3kCazC17 oy3fEYIPqTK5lxfYzQltMuYH.GvZCsLsOknZdEm8SFylQqKuM9rrNZL6AvC9JX_mwU31lU.JIyy. Ez.q2DTUUDDSRN2jrE2_bHpKA2GQc7YScigoPuG5cemAINiPPYbOioUFAX.guk607VlRAbhK6Iye _Ez6Z6QR4tw3eDktbwQoEKsy6x2sPm8PiHjxFv3_WWdLe_m1IDWL0Zh6w39JBjgK6K8eNX4U8XPm _PxpjyukZfPKmzmiCrQh.mSIKGsewVZwkNi8.l3Hw.HLIVSvZTpOxBoM.nvYcGkHBAMi0rWfrllJ 5HGUQgv1bdH1XVzBrWsvaohpCN3RFZ5okuLSlf6mD8JWD2CTsch0szO8CnVgoiYjm5qyK_14IFLw 2yyyuiUi06t8nn8kVjepB0kP_0UfMY5M_eisROIuc.2MAt54_nrF0ie9IUKnOWMlKTi.RIy6IduO DUHqFPSbRpofWimZC6pWkLM6qT27PkadswCI1l_Iz.kViDWmT7QvkNV5atY07UVkePaXl.Y9yhfj hHavejP7sUHxbPi3XHLC1V8POIrhs.oTUHi2qhv2T7cY5fWRwNUYKimRTuFZScBaQIhlvxOuRs2p 58B8KFbf73jjpjaTS5kVbrxT64ENfAnyBAIZWZp1Ud2N91p9MkqwnmWkMM7GsO0LLsXlc2s1By65 CKFMtes0TWWHSoCDVGsLg5p46dOP7kQldLeDz___SPORq_kx9GgCjkI9exl0MLy2Nel.RmpshdKk 4SNTkdCLJuaXvSXS4WgsOcGjK_oN.DiorQDdO2_UFM Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ir2.yahoo.com with HTTP; Sat, 6 Apr 2019 18:59:44 +0000 Original-Received: from 2.152.205.184.dyn.user.ono.com (EHLO Ergus) ([2.152.205.184]) by smtp429.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 96c521efc9ab68ba3840e3b5ac16dc1d; Sat, 06 Apr 2019 18:59:39 +0000 (UTC) Content-Disposition: inline In-Reply-To: <83a7h39l8l.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.179.147 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235040 Archived-At: On Sat, Apr 06, 2019 at 07:00:58PM +0300, Eli Zaretskii wrote: >> Date: Sat, 6 Apr 2019 17:20:14 +0200 >> From: Ergus >> Cc: emacs-devel@gnu.org >> >> In the first one I extended the conditions for the character >> selection. It is not perfect for the reasons we have exposed, but in the >> mean time it will work for no very fancy conditions until we agree if we >> should use | or find a better solution because I don't like that one :(, >> it looks too ugly by default. > >I agree. > >> In the last commit I removed the Qfoo symbols which seems to fix the >> customize-variable issue. >> >> I also removed the variables from frame.el because it seems they were >> not needed when I followed the procedure. > >Assuming you bound the command to change the variables to a simple >key, like F5, that's fine. "M-x set-variable", for example, won't do, >because it activates the minibuffer, and that triggers a thorough >redisplay. > That's right I double check and there was an error in the corrections, I just fixed. I am wondering if there is a way to put conditionals there, because the redisplay needs to be triggered only if one of the variables is already non-nil and we need to redisplay if we change fill-column only if display-fill-column-indicator-column is t. Similar thing should happen for display-line-numbers right? >> I am wondering why in display-line-numbers the symbols are needed and >> the inclusion in frame.el, but not for display-fill-column-indicator if >> they are implemented in a so similar way. >> >> Whats the internal criteria for that? Some code to read? > >I just followed the procedure described there, AFAIR. OK.