From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Sat, 6 Apr 2019 17:20:14 +0200 Message-ID: <20190406152014.zykyiakddmwsmkko@Ergus> References: <20190405103614.oivi4mtlnklldli4@Ergus> <835zrsd670.fsf@gnu.org> <20190405150404.bm2d6wjtivwyesek@Ergus> <83r2agbhwv.fsf@gnu.org> <20190405173010.snavjhxrmmufwp54@Ergus> <83h8bcb7ce.fsf@gnu.org> <20190405200319.jfwt7lgevas556id@Ergus> <834l7bbp9a.fsf@gnu.org> <83k1g79smt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="221645"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 06 17:20:34 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hCn7R-000vYN-El for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2019 17:20:33 +0200 Original-Received: from localhost ([127.0.0.1]:55981 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCn7Q-0001BM-FR for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2019 11:20:32 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58573) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCn7K-0001BD-LJ for emacs-devel@gnu.org; Sat, 06 Apr 2019 11:20:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hCn7H-0007fn-Kk for emacs-devel@gnu.org; Sat, 06 Apr 2019 11:20:25 -0400 Original-Received: from sonic305-20.consmr.mail.ir2.yahoo.com ([77.238.177.82]:38220) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hCn7F-0007fB-66 for emacs-devel@gnu.org; Sat, 06 Apr 2019 11:20:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1554564018; bh=14Xyn/2LjNhYn8m/wnEDEvUiqWSesNpL6zNgerMOgKE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=s2Dv9G//7DDSmPiOHhcFU5dJUAqXJnrfrEiIBh4AHOzFY1gK4GMLmOPkOPVbG7NFwd2vqfRy5Du4IS+QLDvfp4Rfhe45zemLwXAVNgqhbGMLxOn1LaP6iXjgY/HMA/bkaTWTaF+cClOzVoONod87dsLjQu1K3avFfws/jScM3S81T2CWuFnRdBRhx323+p9axK1iXK+yKqT0DBDPWefC9E7IgR1y/ViZIb4i47Cdc20P/llwv4XK9IpOlt8vqtuvnBcSrvMkTpLgn7tvgk+AdH2J3LKSW3Ea4Xs7fjuGBkJxOcfj/g3MhlvCssYoaEMa4Fz5ZCxL7+9lR7BAOhT39g== X-YMail-OSG: Y4QG2g4VM1mPnBgaGjoisXch5AMCFmyENVZbkoT561DX170XQyrVEtm6T3xhjQB yKCo3CwUikgRhUABD2rRDZE1wX7qmr9d173NxY7iFE6HhLjRKV8a1v.qGvFiF1Smswhc6u9flaEr k1dP5XNOBwxwQMZXfPXCex4DMOSA.s3R79u39jUesEtWIaIdISPsnRM.kSgxYy3hlWm_9XcrgN7K xpcSt3H6SSqOaFtemTrQMhxg4iQlknggS2o.Wq6UpfCQkbeKvZQFoWFu9m.L.1KbUc3sFjz8sxvR 8ELBFXb7DZ1Y1VS2kFGUyOFJx7zBbzOBUYspL0Qvffga5owOW8Lo3YI_z7Q8fy1tYd7CtB7KJ4UM E2RK4XbBJWbSpBNmUs_wWtswP5YOwjhkgRIRtqNSll1R7rfJBCuAeJSjGzzhIZtMH.PrQXdCDW4E 6cQj79H6j1WktFVWb14a6bIW5jd3pCu7xKtLqLjU3bxGQmGiaAP8pUSXYjtqEYp50Il1EGtjkFl. RFW9CIJplVcYEL0wtpDU_v5INPeMD7ile5A2ExIefJNzOYd2f6BUEDcmcD6IaQ8bB5VTBaKrYide 397vKFFK053U2LqpnwYXInREl12tprVmdCBKjMbdn.Z6vdIdN78Q1doH2DtZmEFtF2rT.kje6KT0 K9pVQtTOIqLlbC_rO1v_QIvhfxKMaiPd9aAlBLdEb7xxzUfT7ED6DVnkNoxMCwzBY8.8xwBOssQ1 1ZAVYNEY210x.gtJX1AeOvhfBvcHE_MVf_9ADw15TV0_13tnu8lfo3m84AE6FQ6i86thKTUdAT4D rpT6F5BAa7QYh4VNolBTGYN.stlSwnUb91u9dL3Q.h Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ir2.yahoo.com with HTTP; Sat, 6 Apr 2019 15:20:18 +0000 Original-Received: from 2.152.205.184.dyn.user.ono.com (EHLO Ergus) ([2.152.205.184]) by smtp419.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID d89f6d7c2edb43d4be63ef5afb21b8f7; Sat, 06 Apr 2019 15:20:16 +0000 (UTC) Content-Disposition: inline In-Reply-To: <83k1g79smt.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.177.82 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235035 Archived-At: On Sat, Apr 06, 2019 at 04:21:14PM +0300, Eli Zaretskii wrote: >> Date: Sat, 06 Apr 2019 09:51:13 +0300 >> From: Eli Zaretskii >> Cc: emacs-devel@gnu.org >> >> > >After changing the value, you need to click "STATE" and select "Set >> > >for current session". Did you do that? >> > > >> > >> > Yes, I did, and there is not change. >> >> So you are saying that display-fill-column-indicator is nil if you >> eval it with M-:, but the indicator is still being displayed? > >I think you should add display-fill-column-indicator (and maybe other >related variables) to the list you see at the end of frame.el. Please >follow the procedure described in the comment there to find out which >of the new variables need to be added, don't just add them all. > >Thanks. Hi: I just pushed 2 commits that seems to fix (most of) the issues: In the first one I extended the conditions for the character selection. It is not perfect for the reasons we have exposed, but in the mean time it will work for no very fancy conditions until we agree if we should use | or find a better solution because I don't like that one :(, it looks too ugly by default. In the last commit I removed the Qfoo symbols which seems to fix the customize-variable issue. I also removed the variables from frame.el because it seems they were not needed when I followed the procedure. I am wondering why in display-line-numbers the symbols are needed and the inclusion in frame.el, but not for display-fill-column-indicator if they are implemented in a so similar way. Whats the internal criteria for that? Some code to read?