Re: Fill column indicator functionality

[Ergus <spacibba@aol.com>]

On Sat, Apr 06, 2019 at 04:21:14PM +0300, Eli Zaretskii wrote:
>> Date: Sat, 06 Apr 2019 09:51:13 +0300
>> From: Eli Zaretskii <eliz@gnu.org>
>> Cc: emacs-devel@gnu.org
>>
>> > >After changing the value, you need to click "STATE" and select "Set
>> > >for current session".  Did you do that?
>> > >
>> >
>> > Yes, I did, and there is not change.
>>
>> So you are saying that display-fill-column-indicator is nil if you
>> eval it with M-:, but the indicator is still being displayed?
>
>I think you should add display-fill-column-indicator (and maybe other
>related variables) to the list you see at the end of frame.el.  Please
>follow the procedure described in the comment there to find out which
>of the new variables need to be added, don't just add them all.
>
>Thanks.

Hi:

I just pushed 2 commits that seems to fix (most of) the issues:

In the first one I extended the conditions for the character
selection. It is not perfect for the reasons we have exposed, but in the
mean time it will work for no very fancy conditions until we agree if we
should use | or find a better solution because I don't like that one :(,
it looks too ugly by default.

In the last commit I removed the Qfoo symbols which seems to fix the
customize-variable issue.

I also removed the variables from frame.el because it seems they were
not needed when I followed the procedure.

I am wondering why in display-line-numbers the symbols are needed and
the inclusion in frame.el, but not for display-fill-column-indicator if
they are implemented in a so similar way.

Whats the internal criteria for that? Some code to read?