From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Fri, 5 Apr 2019 12:36:14 +0200 Message-ID: <20190405103614.oivi4mtlnklldli4@Ergus> References: <83h8bgfj53.fsf@gnu.org> <20190402170031.l64saf2qdr3gez3u@Ergus> <83d0m4fhe6.fsf@gnu.org> <20190402174857.ydvsrgplftya4nti@Ergus> <83a7h8feho.fsf@gnu.org> <20190402212251.ee6jlzptyll24ebo@Ergus> <83sguzekc5.fsf@gnu.org> <20190403102234.gyk45tfk4uypilhn@Ergus> <83d0m3e43f.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="47761"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 05 12:36:39 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hCMD6-000CCw-9r for ged-emacs-devel@m.gmane.org; Fri, 05 Apr 2019 12:36:36 +0200 Original-Received: from localhost ([127.0.0.1]:39661 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCMD5-00081R-4N for ged-emacs-devel@m.gmane.org; Fri, 05 Apr 2019 06:36:35 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCMCy-00081A-QO for emacs-devel@gnu.org; Fri, 05 Apr 2019 06:36:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hCMCx-0003DS-7K for emacs-devel@gnu.org; Fri, 05 Apr 2019 06:36:28 -0400 Original-Received: from sonic311-30.consmr.mail.ir2.yahoo.com ([77.238.176.162]:34665) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hCMCv-00037u-CN for emacs-devel@gnu.org; Fri, 05 Apr 2019 06:36:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1554460580; bh=Y6L+f3RAzLKmanAEnH3l+i79OfmPvNwfA0Uf7WYx788=; h=Date:From:To:Subject:References:In-Reply-To:From:Subject; b=qDMD9S9RxzcKYZ01lFVJ3zuyyBPT0Mut7B6sVUtc5Vcywo9EEz071yTobRo4571XA8ohEZ9xh/pa549g+/n9uGGddkG2a4I+orJxb1AfR2m8ym3GKWBhZc898kWFz4oo7VsCIQ2FZgYHMFsRCSZqNil3WoQwYUcPhgafhuAmHKlI9Kvc87vir9ZCr9565P/npE/JdFP9/mHxzB/g0B9iyBZYp2tCXrZLs3NisppnGcMBGb4HvjzcftfIAbh6BOCkp9uvN+SID7p1NbzkMaN1jlnjDVvDE7qnQTK24AhzNTuyHgb9s9xTTd0hAtsgoj+sXMG54xsx36OQETj7c/6GFw== X-YMail-OSG: sog9YrsVM1lU97Nf_x_GaBp16Hz_RK5hkXgn8uALkQ8EqpBQTyxAtozuRGlDYCv arKkI07T7efqozHidoFlYPe3mmhrfWF4DS6yhXuyT5SAX5azwMksXJFpmWEWjnpc8UY8Cvuq.4Wv 1N_2muj0FXO2rqHGiFTOvKGk2Fo6voGf7MM__k77sRZFQTxxoah2uooN5vHHNzRzTB0m_5wyTg5J 3tjszPMiMh8U.miRh7jj73jhyz5aolsAuLNmKs9Vp8wrGoas67iYT0O3ZCUjzCTfdQhs9c0wO8uH ID3UsL.UHom.1g0zcMzQMXmBxzySNgIoh0IVInQfnv4uV7YsQzd6XBsShChwv.1HCPYk6a7CtuIm uozxvw9yTjKoFsJG3xGT0GbP7qCnSFlk79Qo0RJqrGPNTOQSTCygL_ggipTNpZibMMQ6dsvOq3Nc JCEwmpinxkWanhig7HNsaOfclJh2UeDia3vBEHxhgFWLCaJnYUkaLEGZMrIKTs_ebdFSGZ_yygZX f9.BmHHa46CXDsiZZiocaAM_WQRO1aFm9wv0I8WnXoGRD46vqXPb70eL1wSaClnEWZorUeLFGOV_ Q5tq5JOZ.UT2rYkYpXsA1ZhUde3iueSEUKQ1bolSQwE7j0jDzXeq0i36dInTO1S4dpiWxlM72DLH _kwCqS9aq2EYtKtFMfnAeK6f17SR8ciAOxZmu2_l_GMTmAZkUjxhSJ1knB5BTAIXNqqy81egNeWt 8eTtgJaTTfs.418_MKot_evYpgIUT9Txkp.mlT.OiQ5pn4arsoZAoldPzrn4Yo44DkhOotbwV8kE 2oSbqafatwgBqvBRRD4CwbuaMVFGmxJV5OrC9LKjdV Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ir2.yahoo.com with HTTP; Fri, 5 Apr 2019 10:36:20 +0000 Original-Received: from 2.152.205.184.dyn.user.ono.com (EHLO Ergus) ([2.152.205.184]) by smtp424.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID cf6b2797275aeb216d030c2e6c9800c7 for ; Fri, 05 Apr 2019 10:36:15 +0000 (UTC) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.176.162 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234971 Archived-At: On Fri, Apr 05, 2019 at 11:10:15AM +0200, Robert Pluim wrote: >>>>>> On Wed, 03 Apr 2019 14:11:00 +0300, Eli Zaretskii said: > > Eli> The changes you made look fine to me. Let's wait for more > Eli> people to try the branch. > >Iʼve just tried it. > >- etc/NEWS says: > > Customize the buffer-local variables 'display-fill-column-indicator' > >but M-x customize-variable doesnʼt know about >'display-fill-column-indicator' > Hi: Sorry, I forgot to add it to cus-start.el I fixed right now. Ween I set the variable with set-variable it works for me. (and redisplay is called) The problem now is that I added it to cus-start.el but when I set it with the interface, the line does not change at all. Nothing really happens when I save. Could anyone tell me what I am missing here please?? >- the manual talks about 'global-display-fill-column-indicator-mode', but >M-x doesnʼt know about that function until I > (require 'display-fill-column-indicator) >(this may be due to the way autoloads work in emacs. Thereʼs an entry >in ldefs-boot.el for it) > I have it without the require, so maybe when generating the autoload (which seems to be an automatic process) it will appear. >- the Commentary section in display-fill-column-indicator.el still >talks about line numbers, and appears truncated. > Fixed, thanks! >- when I turn it on, it chooses \u2502, which is not displayable by my >default font, but is displayable by a fallback font. I end up with >empty blocks at the end of each line. I can probably customize >'fill-column-face' to work around this, but Iʼd expect this to work by >default (either by using '|' or using the fallback font). > I don't really find a right method to fix this because the char-displayable-p function seems not to be accurate in many cases. There was a discussion about this before, but there was not a final agreement I think. And from the char-displayable-p documentation: ``` On a multi-font display, the test is only whether there is an appropriate font from the selected frame's fontset to display CHAR's charset in general. Since fonts may be specified on a per-character basis, this may not be accurate. ``` Any suggestion here? >- in org-mode buffers the indicator is displayed as '['. This may be >related to the previous point (those buffers use yet a third font). > >Robert Ergus