From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Tue, 2 Apr 2019 19:26:20 +0200 Message-ID: <20190402172619.6jfwwqn4cpomoa2b@Ergus> References: <20190318114249.ouqxfghhw5dfr5ry@Ergus> <83y35cumzs.fsf@gnu.org> <20190402124236.cpb63pdopfk6vpj5@Ergus> <87k1gczhi8.fsf@telefonica.net> <20190402133718.z464xomdq6l3pfrl@Ergus> <83pnq4fnte.fsf@gnu.org> <20190402153504.jfliuexzn4ntqnn4@Ergus> <83k1gcfm3y.fsf@gnu.org> <20190402163623.2gvlraa5qitzgi6y@Ergus> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="184170"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 02 19:30:01 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hBNEX-000ln8-AY for ged-emacs-devel@m.gmane.org; Tue, 02 Apr 2019 19:30:01 +0200 Original-Received: from localhost ([127.0.0.1]:40123 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBNEW-0000fC-9U for ged-emacs-devel@m.gmane.org; Tue, 02 Apr 2019 13:30:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBNB6-00074c-TL for emacs-devel@gnu.org; Tue, 02 Apr 2019 13:26:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBNB5-0001rR-UK for emacs-devel@gnu.org; Tue, 02 Apr 2019 13:26:28 -0400 Original-Received: from sonic310-11.consmr.mail.ir2.yahoo.com ([77.238.177.32]:45870) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBNB4-0001mw-Hk for emacs-devel@gnu.org; Tue, 02 Apr 2019 13:26:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1554225984; bh=yDuLNjvE7OnnCrRSt7KVdILNqp3j5PXd9XbswcYuH9A=; h=Date:From:To:Subject:References:In-Reply-To:From:Subject; b=fR/WSWiDVCwUk/InYXW5+1efnsJmdM6xrGVRYoiCucscVy0Ztni4na4e3M/MXjbmC/tkJsPiMHOsAitUIYSN77FgmGmScQytxd7Prjul6KNVhylvl+km1KuOrjNW0GXjifoxcNPN6tXkUv+ozIiKQFbQ7U/BV3/ffhASqy6v2YqNt3NYNY0gl0zw127SKbBQLRUnImEL9sHHxWuqvZYZ3rfmWmEa0fFA4SACxYZbsWYOhl0W8x10h4dpnQlxTu7p9XbPyM4nQekPvxm1Z6XaPxw7yDsYfYtLQMQ+GC4vP2H9Y3zgVqeqes81rzKHrL00x0AaKG5AG/5udSKeLJN3NQ== X-YMail-OSG: .iceWIQVM1lG.5OCJ245tAwzPWUXypP4YB8uZGKAoaVbDcTjYZInIGw2nBD80rs zF0XuZ4zBnK2T0nLlBH7RnTltli6d4ydLgNQxZ9ajRd2.Y0OfYhzG3JhmXcEC01MYq8nVMRGg.Rz PNKax_GGGrCTCrPYY2iNC8Nh5cs8CJYEILG25UOY7V5ALiRdpxuvSy6jxSJyoWxuP4TiIRIyfoCV lKsdXT7h7eteR7rFB0BSdkKEj6vFdVn16Llzvy_rrYZ7cYm52i7vRqqu4R7TNWGS.hpuDO6i8jG1 _1xF_eZy6a86X3rWxMLU.C7PAG5Z2dAOEAryWmSHaUBToUuuegfPOGZp.tW7Lg5whD7Fgd4lw0mV FtIkucW.FPUyj.hwUmlZxZ8kqFBVGW0tvAlouUCLmGJTR5CaapUIzq_sG2bsMlZCuAMAEW_2ytfm wGkwCoszu_XSiGIhC8XZGwYmd8yhS0F_3urCjo_JV0o.jzL5TtuL9LgMR1Cm9BJmGKWt_9jy_Jhb YW9GB4WJKAD9wN.yTiTTYs5sOukK3scFXSzdK9EK_IU.EQ5Pp0KA27VO3IPdqhi37r1gBlPOqcwG 9Klyuffn3C547TqynvAdTdTh_Ja1tONJaautWUyvVB1Sbtl7nWSPmVRKkNUkEOI_VknGWKkYT.xt 6buvXhoJhtsflYck065KDJkxJuKc_7.2oh.Go5lo_44tcUxXOAxcpJOceESN8hSetwSDGm5HJqXs 6dx7zOjB1h4JtO.Q.6UtqfkYutB1xpBWkJGadyP6PX5dAnreI0OxCvHptd1t85Jk_gKr0uF_A__X goK8l0ms6qVZMUKa5BmEeB_Ax36ZQZOBop4Fl0DQL5 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Tue, 2 Apr 2019 17:26:24 +0000 Original-Received: from 2.152.205.184.dyn.user.ono.com (EHLO Ergus) ([2.152.205.184]) by smtp426.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 3481a753bd61700957aa82de94d2f3af for ; Tue, 02 Apr 2019 17:26:22 +0000 (UTC) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.177.32 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234883 Archived-At: On Tue, Apr 02, 2019 at 07:01:45PM +0200, Robert Pluim wrote: >>>>>> On Tue, 2 Apr 2019 18:36:23 +0200, Ergus said: > > Ergus> I just pushed a new branch with the fill-column-indicator > Ergus> feature. I would prefer to rebase before pushing to the > Ergus> master branch. (In my ideal world I will rebase and then do > Ergus> a merge with -no-ff. But this is not the workflow you have > Ergus> here) > >I took a quick look. Itʼs three commits, including the NEWS >changes. Any reason you donʼt want to squash those into a single >commit? > No, I do the squash when I rebase before merging to master and I do all the changes and fixes recommended on top of this branch. I just keep it like this now because recommendations will arrive and I don't want to overwrite public history constantly if many changes are suggested before the approval. This is like a develop branch for the feature, so I'll put things "pretty" in the last moment. and in the mean time I will just add commits on top of it. > Ergus> So, how is decided when to move this to the master branch? > Ergus> (the equivalent to accept the pull request) > > Ergus> There are changes in the NEWS already but not in the > Ergus> manual. So, just tell me the following steps. > >The NEWS changes have some minor issues (spelling, two spaces after >full stop, spurious whitespace), but the new user variables and modes >need descriptions in the user manual. > >Robert > So you mean that the variables descriptions shouldn't be in NEWS?