From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Mon, 18 Mar 2019 02:03:13 +0100 Message-ID: <20190318010313.rec67ljatygf5xlf@Ergus> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="159330"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 18 02:04:27 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h5ghW-000fMt-GF for ged-emacs-devel@m.gmane.org; Mon, 18 Mar 2019 02:04:26 +0100 Original-Received: from localhost ([127.0.0.1]:33905 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5ghV-0008Cr-DG for ged-emacs-devel@m.gmane.org; Sun, 17 Mar 2019 21:04:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5ggS-0008Bq-FE for emacs-devel@gnu.org; Sun, 17 Mar 2019 21:03:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5ggR-0006B4-GF for emacs-devel@gnu.org; Sun, 17 Mar 2019 21:03:20 -0400 Original-Received: from sonic308-19.consmr.mail.ir2.yahoo.com ([77.238.178.147]:34547) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5ggR-0006Ao-5u for emacs-devel@gnu.org; Sun, 17 Mar 2019 21:03:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1552870996; bh=RoWAY+raR24LyugU1mv7To6bhSr8TOBCkskS0yWI6xc=; h=Date:From:To:Cc:Subject:From:Subject; b=P/OcmQ3dgjH0JtJ7sWHfY/CGV2dh3PrvGwnCWQ5W8+vz4Hga6H3qF0qpiIc1e2z1+7nZZXifALfOVQl2avIrCuB43iuMPDxKVBAORpG2Rt54/88D/GsF9fSKQpF7FVeIUAfWA+HQvQya8NFods8zKkOsAIm/xSmw43IV30G2qMBydQg3lmJ+NJ42neO+8TkC8hDKcOpZewCmShcZk1qhLw2OIxNiAfy+p9q4BjW5WqvPZ9BYnqcTw2GcoA6fy/y+AjiAJXzPdgFh8A6nAm9A02i+/0sKdKXpMytOq3PyyPHDqiULcEQO6X4MROyMOJZICJu8feB1Y4TulyOf67G6uA== X-YMail-OSG: TOMopYEVM1l0WnEG1ybrnIpy1M.nd7gekFgVCQ.CBiOVfh8_TVYIqAY2FPn3OFv Pt33kZc3sZgRS8gxvKxyQnuC4zbrfkBWoOV_HY0AO4_UrjEx8HLLYVERPNcCxAqMc9eMDewjOt.8 XPWMwWWQrX83dvsQ_Vu2vhNa_HzVNIM_73AB1HpIBdVSHnolIRSthK8UhVF4cnBYbKPTapjtNSt7 cynFnI3d9o0qqtTBVl43oYaLuH7Z.wqZbyrxkncUTrdUxZ_fPA13N1Ci9sjdT06exGrHpzF.Xs0A szCJ6FM1nNEZDIt5bpKa4l9o4T_Roj8G7.jp465H.DIf22u2NBJ.D.36YQu2pXIRQJUig9ca_WE_ LFBQfAt8cBb38GfWrjGzgFJhjc00zHKjXRELB0H6K0.9hKT0.ZrmhukCEQ9eYGXeAxP7UVmI6FxP 8ApdKNas6YNfOje51nK_LTUDlH.xHZ5USfIE_vpQjJ.JbVdFdxBaLBMwMRPBlPRppnPJ9JOiQN7B z58Si15PPNk_JwJCn6fO.DT2ypALBdo64AD5FxDoYu6ILWzsU0iTb_t8maoWVM36S916d88VhcpH JAwdLmsENdF.R.6EmT0DfTqwkbmsOG6x3FzkBjAGvEK5JqVM6HdsY4S3mT8cTpKGFgVGHG3cQuQO VsyTTotSGANjQ2hXbRZaZvx_Yh3NUhTHPhGzPTkrN_wClglVbO86L1hkN2OO3l7U901mW5uqG725 oNms.7RIJAtfiQVzNZTR6tbdQhTVgmL7CmsxPaoJyCAkFqUUGHPCuHnxWSqNoPII4QXf1tEX21n3 CjwM6rg1Xz8NBXPWvcZA_OvO53vA7peVzoalL9smkT Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ir2.yahoo.com with HTTP; Mon, 18 Mar 2019 01:03:16 +0000 Original-Received: from 2.152.205.184.dyn.user.ono.com (EHLO Ergus) ([2.152.205.184]) by smtp408.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID e1758c508ac3dbf49f50bb1664da3661; Mon, 18 Mar 2019 01:03:16 +0000 (UTC) Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.178.147 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234309 Archived-At: Hi: The variable fill-column is defined in the buffer.c file. I should access it in every display_line when display-fill-column is enabled if I want to keep the difference between display-fill-column-indicator-column and fill-column. (when display-fill-column-indicator is t). Whats the better method to do that? I think that doing the check every time display_line is called is something not really needed because a redisplay is triggered when those variables change, so maybe is better to do a variable update in the redisplay there and then we can access directly an int variable without the need to call all the if-&&-else for every line. That must be cleaner because the checking and comparisons will be just in one part of the code. But I am wondering if that could have some undesired side effect.