From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Fri, 15 Mar 2019 21:56:26 +0100 Message-ID: <20190315205626.4ulamwcaojxnhfu6@Ergus> References: <20190312192017.fkfd4h5gsbdue5q3@Ergus> <83imwm3fxf.fsf@gnu.org> <20190313200225.dpqrw7xthkj47fqw@Ergus> <83bm2e35a1.fsf@gnu.org> <20190314030224.l5zseslncw3xc5ox@Ergus> <835zsm2c2s.fsf@gnu.org> <20190314165147.gmtwgzqaibwbzhbm@Ergus> <83r2b91flg.fsf@gnu.org> <20190314211313.giyz7p6jtmquabea@Ergus> <83bm2c1smi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="237100"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 15 22:12:24 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h4u7r-000zZ2-KZ for ged-emacs-devel@m.gmane.org; Fri, 15 Mar 2019 22:12:23 +0100 Original-Received: from localhost ([127.0.0.1]:33089 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4u7q-0006PU-GB for ged-emacs-devel@m.gmane.org; Fri, 15 Mar 2019 17:12:22 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4u6F-0005lW-HI for emacs-devel@gnu.org; Fri, 15 Mar 2019 17:10:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4tsX-0000rX-PG for emacs-devel@gnu.org; Fri, 15 Mar 2019 16:56:34 -0400 Original-Received: from sonic301-22.consmr.mail.ir2.yahoo.com ([77.238.176.99]:33230) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4tsX-0000rB-5A for emacs-devel@gnu.org; Fri, 15 Mar 2019 16:56:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1552683391; bh=hq0HN4rJbzioRWGDfbxRyoC8A5VEXb1DPlTi6+lQSz4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=nxl07fU0z/c9uOmeTVEuuO3nnKWB6JfVdfirT/0a8R+QfjFKzTkvfo+jKpuWTo9PlEmA2oRcI6n0vC27Ls5AKATXIXi9jix9unaCpHwdaAXUStxC4OviYcmAbltXozAk9LyXUM8SezU+hplSA9v+KuckHPkSzCuwDmylQpD9hb4B2Pr9PmNzU3QL8KjTlzC114lRr5kRXuxeY1tDKn4ud7SaOaZ/D7zziGMM8AcGPZf1rtQcD5q7N2PAQvMq2dCsSrxzaeOETbWEqOdoVefwg7PosL3qbhHye3oq9cv4ITncay0LfDfHR3iqwoB7X2dBpCoc1Ea7cXsDirWgNF7hMw== X-YMail-OSG: 3WwRZ1UVM1nFAyMx0XRVQYbvbOuQ5xeeRUNTHRuOwU.lkx3f3tzW6r_baWbGirj C_xgKdI1X_wL2KFI9rWcRcSenSESbEgRqO9BCwiGDvSA2k8CEHgyOns0XUDbcD.lRO74jqWiPpzW 0tDpmAsH4epXDRrr8LZBBDxm3S1xccksg4vM8AcJmk07r7EbioVtq.AbnYJ81irVjinh8e1CRkyA uF6ffJ1dnjROuFU3BOnnK4q9NSr_WjBuInS4SoecA_7HkvNLiiGlXf0A09KZuzdtyPOAHzEsXCQB kumOwBbN.oPN6dDdWZPHn6.1cquErBNdTF7EBSaCjjqHdNX23.Bfsjj9QM4elLJcHvzxPpPpP9V5 27bxQP9c32IfeCO9rLMn8.DNdT6a7J5REmv7KTJClYSEGe7xIDWZEdlYBtJcWTW5cSCRwz.VgyM3 kB.4eOLWpkJxM0Y4xlAjTw2tjO3rWWZTTG.Ca54BlLjm9e0yvNslaqNZgInYZgJc02i31YkBeTzm cVIsHguJfoncum.ejS4WC57JDvI0idyJCAKGQbEgSyVdgAzD035mmt4k797FuEP.V4Bshe27vsW9 PPBB1_Qy4T_c08wXHaJB2mwMwrQjzCSmxMJVNQy54bj.tpF_E6RLA.hRcFeA1QUalhZjajVwLTld CUIILUcieXR5jzguvykzH5IdaC5A_M4IydejgyZ3OWMS.pLguINMx7UeqjGWdYI2M_aGKNRjVKpZ BVLw391.TIaIV4J7mmE1kkGpu.jeofFhk0PE.uSwDMIfaYIoMJ_Jo9rmZmptEYeCIRUkUay6gh5t Dr38i3xrT1etGe7_y0AdhqYxG_.irkZjOM4fojrQuE Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ir2.yahoo.com with HTTP; Fri, 15 Mar 2019 20:56:31 +0000 Original-Received: from 84.88.50.33 (EHLO Ergus) ([84.88.50.33]) by smtp406.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 2e571162ba2ed3875a309e0e1f3ee93c; Fri, 15 Mar 2019 20:56:30 +0000 (UTC) Content-Disposition: inline In-Reply-To: <83bm2c1smi.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.176.99 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234189 Archived-At: On Fri, Mar 15, 2019 at 09:52:53AM +0200, Eli Zaretskii wrote: >> Date: Thu, 14 Mar 2019 22:13:15 +0100 >> From: Ergus >> >Can you solve this problem by using the :height attribute whose value >is 1.0 (a floating-point number) for the face of the character? If >that doesn't work, we might introduce a special feature for this use >case. > I'll try this in a while to see how the experience changes. If we set that this way the font will autoresize depending of the height of the current column? Anyway I think the discussion in progress can give a different answer. I will wait a bit more to get a recommendation. Or a solution that promise to be better. >In any case, I think this use case is rare enough to leave it for >subsequent improvements. It doesn't sound as show-stopper to me. > >> Or use a different type of glyph in graphical mode... maybe an image as >> the fci package does? Is that possible? > >It should be possible to use an image, yes. Does the fci package >solve the use case of lines that are taller than default, as in Info >or EWW? If so, what do they do -- use a larger slice of an image >according to the line height or something? Because using an image >still needs to solve the problem of displaying a taller image when the >line's height is larger than the default. > The XPM image seems to be a good enough approach according to Alp's comment/experience, but it only solves a part of the problem. But I haven't go in the details of what they do and I don't want to over specify the functionality or produce too much overhead. >One more potential issue that I think you should test is when the >fringes are disabled on GUI frames, and we usurp the last column of >the text area to display continuation and truncation glyphs there, as >we do on TTY frames. If the fill-column is equal to the last column >of the window, or to one before the last, I think you will need to >augment your comparison with it->last_visible_x in this case. > The code that adds the information looks to run later, so the line is hidden in that case, which for me is the expected behavior. Otherwise I didn't understand the issue. Apart from that there, are some corrections I made in order to fix some background issues I observed in graphical mode. In graphical interfaces the space after the line is always filled with the background color of the face of the last produced glyph, even if I reset it to the saved value after the generation. The only solution I found so far was to add an extra glyph after reset the face to the default (saved) value, but hopefully there is a better way?