From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#34525: replace-regexp missing some matches Date: Wed, 27 Feb 2019 17:31:32 +0000 Message-ID: <20190227173132.GG4772__709.876178164848$1551289747$gmane$org@ACM> References: <20190220213003.GC9655@ACM> <83bm35hkqo.fsf@gnu.org> <20190224173746.GA21808@ACM> <83mumlnk8y.fsf@gnu.org> <20190224210058.GB21808@ACM> <83mumjmxv6.fsf@gnu.org> <20190226135048.GA19653@ACM> <20190227142251.GB4772@ACM> <838sy1kwxo.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="96604"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.10.1 (2018-07-13) Cc: daniel.lopez999@gmail.com, monnier@IRO.UMontreal.CA, 34525@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 27 18:49:03 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gz3KF-000OvF-UN for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Feb 2019 18:49:00 +0100 Original-Received: from localhost ([127.0.0.1]:48331 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gz3KE-0005w1-Qw for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Feb 2019 12:48:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gz38q-0005Bm-IP for bug-gnu-emacs@gnu.org; Wed, 27 Feb 2019 12:37:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gz38p-00064g-Nl for bug-gnu-emacs@gnu.org; Wed, 27 Feb 2019 12:37:12 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40753) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gz38g-0005ve-QT; Wed, 27 Feb 2019 12:37:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gz38g-0005xc-9Q; Wed, 27 Feb 2019 12:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Wed, 27 Feb 2019 17:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34525 X-GNU-PR-Package: emacs,cc-mode Original-Received: via spool by 34525-submit@debbugs.gnu.org id=B34525.155128899122875 (code B ref 34525); Wed, 27 Feb 2019 17:37:02 +0000 Original-Received: (at 34525) by debbugs.gnu.org; 27 Feb 2019 17:36:31 +0000 Original-Received: from localhost ([127.0.0.1]:54297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gz38B-0005wt-GS for submit@debbugs.gnu.org; Wed, 27 Feb 2019 12:36:31 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:28584 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1gz386-0005wi-KL for 34525@debbugs.gnu.org; Wed, 27 Feb 2019 12:36:27 -0500 Original-Received: (qmail 60862 invoked by uid 3782); 27 Feb 2019 17:36:21 -0000 Original-Received: from acm.muc.de (p4FE15D59.dip0.t-ipconnect.de [79.225.93.89]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 27 Feb 2019 18:36:19 +0100 Original-Received: (qmail 23670 invoked by uid 1000); 27 Feb 2019 17:31:32 -0000 Content-Disposition: inline In-Reply-To: <838sy1kwxo.fsf@gnu.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155865 Archived-At: Hello, Eli. On Wed, Feb 27, 2019 at 18:39:31 +0200, Eli Zaretskii wrote: > > Date: Wed, 27 Feb 2019 14:22:51 +0000 > > Cc: Eli Zaretskii , daniel.lopez999@gmail.com, > > 34525@debbugs.gnu.org > > From: Alan Mackenzie > > if (! NULL_RIGHT_CHILD (i)) > > { > > i = i->right; > > while (! NULL_LEFT_CHILD (i)) > > i = i->left; <=============== > > i->position = next_position; > > return i; > > } > > Here, in seeking the next interval, we go down a chain of `left's. We > > do not set the ->position field of these intervals, except for the last > > one, which we return. > The position field is just a cache, isn't it? It's a cache, yes. But it's used in update_interval, for example. It would appear bad things were happening because it wasn't being kept up to date. > > So the returned interval doesn't satisfy the condition that all its > > parents have their ->position's set correctly. Thus if we use this > > interval as an argument to update_interval, we will likely fail. I > > think this can happen in update_syntax_table. > next_interval and previous_interval are used extensively, so I'm > having hard time believing that they have such a blatant bug. Yes, how come we haven't seen many more consequences? Maybe syntax-table text properties aren't as widely used as all that. Also, the effect would have to be seen within the time between successive calls to SETUP_SYNTAX_TABLE and friends, since each such call reinitialises this cache, in an important sense. And we only saw the effect when the replacement text "SharedBitmap" was exactly twice the length of the original word "Bitmap". Anyhow, fixing this item appears to fix the bug (see the tentative patch in my post from 15:08:49 +0000 to Stefan). I'm guessing this fix will be deemed too unsafe to make it into the emacs-26 release branch. ;-( -- Alan Mackenzie (Nuremberg, Germany).