From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Khaled Hosny Newsgroups: gmane.emacs.bugs Subject: bug#33729: 27.0.50; Partial glyphs not rendered for Gujarati with Harfbuzz enabled (renders fine using m17n) Date: Wed, 30 Jan 2019 00:33:30 +0200 Message-ID: <20190129223330.GC20784@macbook.localdomain> References: <838t0gapcj.fsf@gnu.org> <20181223135109.GA6568@macbook.localdomain> <83va3k8c79.fsf@gnu.org> <20181224020847.GC6568@macbook.localdomain> <83lg4e9a7q.fsf@gnu.org> <20181224173723.GH6568@macbook.localdomain> <838t085qx8.fsf@gnu.org> <20190105205314.GA28761@macbook.localdomain> <20190105210420.GA31354@macbook.localdomain> <83pnt9zn73.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="209086"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.11.2 (2019-01-07) Cc: behdad@behdad.org, far.nasiri.m@gmail.com, 33729@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 29 23:35:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gobyK-000sD9-PX for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Jan 2019 23:35:12 +0100 Original-Received: from localhost ([127.0.0.1]:56571 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gobyJ-00041I-Q8 for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Jan 2019 17:35:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38572) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gobyE-00041A-5S for bug-gnu-emacs@gnu.org; Tue, 29 Jan 2019 17:35:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gobyC-0000lT-8d for bug-gnu-emacs@gnu.org; Tue, 29 Jan 2019 17:35:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51650) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gobyA-0000jH-2w for bug-gnu-emacs@gnu.org; Tue, 29 Jan 2019 17:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1goby9-0000rV-V0 for bug-gnu-emacs@gnu.org; Tue, 29 Jan 2019 17:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Khaled Hosny Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Jan 2019 22:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33729 X-GNU-PR-Package: emacs Original-Received: via spool by 33729-submit@debbugs.gnu.org id=B33729.15488012493245 (code B ref 33729); Tue, 29 Jan 2019 22:35:01 +0000 Original-Received: (at 33729) by debbugs.gnu.org; 29 Jan 2019 22:34:09 +0000 Original-Received: from localhost ([127.0.0.1]:50931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gobxI-0000qH-Rw for submit@debbugs.gnu.org; Tue, 29 Jan 2019 17:34:09 -0500 Original-Received: from mail-wm1-f54.google.com ([209.85.128.54]:54701) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gobxG-0000pm-SS for 33729@debbugs.gnu.org; Tue, 29 Jan 2019 17:34:07 -0500 Original-Received: by mail-wm1-f54.google.com with SMTP id a62so19626379wmh.4 for <33729@debbugs.gnu.org>; Tue, 29 Jan 2019 14:34:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=sjpl2j4h3lwodH5ZNN8SBKjW0MscgxcsPGHfxezSapQ=; b=AwtGu5L9LkJqX4Rm6bRKXiUt5rVrAmmd8glIgG/+SBJIhyg799KP4CySc0g8og/bhP 2WhOe+xurnOZIu13WzNPWrVnJweBYGGAkvgHv6U5T9p//+TvmLgiBjsJrNW9U60WHW+W 1c+HLiWn7x00BhkrXa8GOZiJ+7DV8g9YIL6GSFZxYn5kV21bHmxO0rZgFAEebTzeM+5d D6LXo8uwho+L/P5Qn371RwZv1C16K6BAHS5E0VwXfzlst6wzaNGsZDLimdi1UOIrmAfG 9NvMx3IdMC2i+GQgWw+DYVJxrzLNRnO7Iw27i/r2d+ua7J2znxt4IfeDzWG5S4A8SGvv pwEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=sjpl2j4h3lwodH5ZNN8SBKjW0MscgxcsPGHfxezSapQ=; b=TNVbZe7ANHIJflA/KQuKhGj+VJk8TY1qXvInXqS3hkk/7dWws/wrmkq1uyHCOHFrR1 WYVWfywy3EzUL/I+boUkH/xRrkPGQ3FqZMM+l/6e6nbUox3PnCVLbDjJYFboKUE4byjj 7zD+DHTw6J1bdXlv1Fnm/bRbtcoQahLwFwGolBm6HHetd/sN93LHQsqBuGtC6olR0MBQ Qy3S2sYSNC6kUEX7aBsKd6yq46xDzGsQzKqQa5M1i2YhS2lbUEzg6uUylgwctWtwWS/A R3PpyTNel84eoVLZiYO7p5kilYh/cMGMqpVci/pR2aJAJoV2Iw0PH8V0VgdD9PGeRgyS MrAw== X-Gm-Message-State: AJcUukdXtInfkVPy/uJhyJBqh/2LzXaRqNHK7YM6j0wTxnOfDDbHA4N9 5nM4TMcC1XXZ+hCsDxXsz8ywR6W0 X-Google-Smtp-Source: ALg8bN7SXuo5p1oRpVjHHG2k6mQboFN1AKlHfHrqMCl430Tz5Jp2ywCgWz/kn7tHtpoV0Zv5rqccAA== X-Received: by 2002:a1c:d00d:: with SMTP id h13mr22308758wmg.13.1548801240587; Tue, 29 Jan 2019 14:34:00 -0800 (PST) Original-Received: from macbook.localdomain ([197.58.129.117]) by smtp.gmail.com with ESMTPSA id g188sm96124wmf.32.2019.01.29.14.33.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 Jan 2019 14:33:59 -0800 (PST) Content-Disposition: inline In-Reply-To: <83pnt9zn73.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154877 Archived-At: On Sun, Jan 06, 2019 at 07:54:24PM +0200, Eli Zaretskii wrote: > > Date: Sat, 5 Jan 2019 23:04:20 +0200 > > From: Khaled Hosny > > Cc: far.nasiri.m@gmail.com, behdad@behdad.org, 33729@debbugs.gnu.org > > > > I pushed a couple of commits that does this based on my limited > > understanding of Emacs code, please check. > > Can you explain why you moved the call to > hb_buffer_guess_segment_properties _after_ the code which sets some of > the properties? I cannot find anything about that in the HarfBuzz > documentation. Is this because guessing the unset properties can > benefit from knowing the properties which _are_ set, such as the > direction? hb_buffer_guess_segment_properties() won’t guess set properties, so moving it last was to avoid wasting time guessing properties that we will override later anyway. > I did it the other way around, because my mental model was: first set > the defaults, then override them where better info is available. hb_buffer_guess_segment_properties() is not for setting defaults (there is no such thing as default buffer properties in HarfBuzz working model), it is a kind of quick and dirty hack and production code should not use it. Regards, Khaled