From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Khaled Hosny Newsgroups: gmane.emacs.bugs Subject: bug#33729: 27.0.50; Partial glyphs not rendered for Gujarati with Harfbuzz enabled (renders fine using m17n) Date: Mon, 24 Dec 2018 04:08:47 +0200 Message-ID: <20181224020847.GC6568@macbook.localdomain> References: <20181222090644.GB2244@macbook.localdomain> <83va3lan24.fsf@gnu.org> <20181222151509.GC2244@macbook.localdomain> <83h8f5a7po.fsf@gnu.org> <20181222154945.GE2244@macbook.localdomain> <83bm5d9wsc.fsf@gnu.org> <20181222205948.GF2244@macbook.localdomain> <838t0gapcj.fsf@gnu.org> <20181223135109.GA6568@macbook.localdomain> <83va3k8c79.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1545617230 440 195.159.176.226 (24 Dec 2018 02:07:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 24 Dec 2018 02:07:10 +0000 (UTC) User-Agent: Mutt/1.11.1 (2018-12-01) Cc: behdad@behdad.org, 33729@debbugs.gnu.org, far.nasiri.m@gmail.com, kaushal.modi@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 24 03:07:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gbFe5-0008R8-0H for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Dec 2018 03:07:05 +0100 Original-Received: from localhost ([127.0.0.1]:60930 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gbFgB-0002hL-7H for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Dec 2018 21:09:15 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:49659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gbFg4-0002gx-R1 for bug-gnu-emacs@gnu.org; Sun, 23 Dec 2018 21:09:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gbFfz-0001Gx-0A for bug-gnu-emacs@gnu.org; Sun, 23 Dec 2018 21:09:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58140) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gbFfy-0001FE-Ry for bug-gnu-emacs@gnu.org; Sun, 23 Dec 2018 21:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gbFfy-0002xs-JT for bug-gnu-emacs@gnu.org; Sun, 23 Dec 2018 21:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Khaled Hosny Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Dec 2018 02:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33729 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33729-submit@debbugs.gnu.org id=B33729.154561733911385 (code B ref 33729); Mon, 24 Dec 2018 02:09:02 +0000 Original-Received: (at 33729) by debbugs.gnu.org; 24 Dec 2018 02:08:59 +0000 Original-Received: from localhost ([127.0.0.1]:34165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gbFfv-0002xZ-21 for submit@debbugs.gnu.org; Sun, 23 Dec 2018 21:08:59 -0500 Original-Received: from mail-wr1-f47.google.com ([209.85.221.47]:42337) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gbFft-0002xK-Bb for 33729@debbugs.gnu.org; Sun, 23 Dec 2018 21:08:57 -0500 Original-Received: by mail-wr1-f47.google.com with SMTP id q18so10410188wrx.9 for <33729@debbugs.gnu.org>; Sun, 23 Dec 2018 18:08:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=nZOV9QV+WhHVBttOHPNwez+nlyT/V5avzsnJt4DlvTg=; b=QnQnf/noCVHWwkrTqhQ54Cby2obBToIBrWsb7CScPrlm0HzvAM0HJARNc14KmOmn6b d0yrh+eO0pFe4ZbaMYe9WjCtJgGoqgWa7DVPgqYLb4pSYxP+Y0unNVw9edWrGwIbAm2A gUyH7JYWakjspsshiVYw9qnvNzadnSgLqJGEYuE9YdIAs1H8+zQohC3ouae5BfCS6hRK RGaUBc82ZjzTIQBrkAvqorJaTGazNlFPaG+87rY1Yv6OI3cCzl7nJOTT1EoDSw1GtcJl EhFPPhs4pzur+6A4j/hcysQFIvb2d1RZIWxjEa+3jF8TfOL8y++b4TmgvDAWdG4kAJ7L kCDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=nZOV9QV+WhHVBttOHPNwez+nlyT/V5avzsnJt4DlvTg=; b=Zri9TIwV1hjZPDdUhMWXpiwZhbvo4KN0kOzYACR0abKTaOPFHde/RQJT9U0d3r/Qy4 QnrUlgKiN8y5Cc40SIXVezfWrPlT63tkFi8co+towqavJSPAE9vpX7xWl6EAnp49spVJ zKB4L/9bq1gOUpGuVJjlB6Ij7qLv7sAa7TbIoOYQr24i+ddcSnjea7AhQmYwkACKA8FB REwqJZ0g//pv4hzOuevuOF3z2oST6vSRpdn87zymqL9ocWcK07HSpdOjm0Kyf9AUxlak SEfmTAUfvQ2f7ekjZ0QZBL4Zjq91htSXX9fHRqy2grDD/IiyWDM3AWQ+qv7QjY3qtRfH 3VKg== X-Gm-Message-State: AJcUukciJt66ZpxtBOI5lvSD5PSJjJ5kLSFVE/gPr1ZsiXwAvvazrkXe 6C2ZyrfhPIEgdXrw/mdVKUM= X-Google-Smtp-Source: ALg8bN7+6WZkVnAkfPppEyeh+YV663s4ryyFPyC0uPHZ0fhCgkASRQ7ay95gXDBDFTy7z/jh2Ddj7g== X-Received: by 2002:adf:a393:: with SMTP id l19mr10315183wrb.110.1545617331697; Sun, 23 Dec 2018 18:08:51 -0800 (PST) Original-Received: from macbook.localdomain ([41.237.113.27]) by smtp.gmail.com with ESMTPSA id 199sm25002083wmh.21.2018.12.23.18.08.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 23 Dec 2018 18:08:50 -0800 (PST) Content-Disposition: inline In-Reply-To: <83va3k8c79.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153815 Archived-At: On Sun, Dec 23, 2018 at 06:00:58PM +0200, Eli Zaretskii wrote: > > Date: Sun, 23 Dec 2018 15:51:09 +0200 > > From: Khaled Hosny > > Cc: rgm@gnu.org, far.nasiri.m@gmail.com, behdad@behdad.org, > > 33729@debbugs.gnu.org, kaushal.modi@gmail.com > > > > > Are there any disadvantages in using the built-in support? I mean, > > > why did you envision an Emacs-specific implementation in the first > > > place? > > > > I thought, but I might be mistaken, that Emacs allow changing these > > character properties at runtime and someone might possibly want to use > > that to change some character property (e.g. make some PUA character a > > combining mark) and it would then be nice if HarfBuzz respected that. I > > admit that is very niche thing if possible at all, and I’m more than > > happy to let HarfBuzz use it default Unicode functions and simplify the > > Emacs integration code. > > Right, I agree that we should for now leave that to HarfBuzz. It > could be added later as an optional feature. (I don't expect many > users to want to modify the Unicode character properties.) I think we are almost good now. There is only one serious FIXME left: /* FIXME: guess_segment_properties is BAD BAD BAD. * we need to get these properties with the LGSTRING. */ #if 1 hb_buffer_guess_segment_properties (hb_buffer); #else hb_buffer_set_direction (hb_buffer, XXX); hb_buffer_set_script (hb_buffer, XXX); hb_buffer_set_language (hb_buffer, XXX); #endif We need to know, for a given lgstring we are shaping: * Its direction (from applying bidi algorithm). Each lgstring we are shaping must be of a single direction. * Its script, possibly after applying something like: http://unicode.org/reports/tr24/#Common * Its language, is Emacs allows setting text language (my understand is that it doesn’t). Some languages really need this for applying language-specfic features (Urdu digits, Serbian alternate glyphs, etc.).