From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Khaled Hosny Newsgroups: gmane.emacs.bugs Subject: bug#33729: 27.0.50; Partial glyphs not rendered for Gujarati with Harfbuzz enabled (renders fine using m17n) Date: Sun, 23 Dec 2018 15:51:09 +0200 Message-ID: <20181223135109.GA6568@macbook.localdomain> References: <83mup4du5z.fsf@gnu.org> <20181222085448.GA2244@macbook.localdomain> <20181222090644.GB2244@macbook.localdomain> <83va3lan24.fsf@gnu.org> <20181222151509.GC2244@macbook.localdomain> <83h8f5a7po.fsf@gnu.org> <20181222154945.GE2244@macbook.localdomain> <83bm5d9wsc.fsf@gnu.org> <20181222205948.GF2244@macbook.localdomain> <838t0gapcj.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1545573015 28939 195.159.176.226 (23 Dec 2018 13:50:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 23 Dec 2018 13:50:15 +0000 (UTC) User-Agent: Mutt/1.11.1 (2018-12-01) Cc: behdad@behdad.org, 33729@debbugs.gnu.org, far.nasiri.m@gmail.com, kaushal.modi@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 23 14:50:11 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gb48w-0007NE-Hg for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Dec 2018 14:50:10 +0100 Original-Received: from localhost ([::1]:56529 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gb4B3-0005YY-6a for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Dec 2018 08:52:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41337) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gb4Au-0005YH-4k for bug-gnu-emacs@gnu.org; Sun, 23 Dec 2018 08:52:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gb4Am-0005IR-Gi for bug-gnu-emacs@gnu.org; Sun, 23 Dec 2018 08:52:10 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56354) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gb4Ak-0005Fx-Bg for bug-gnu-emacs@gnu.org; Sun, 23 Dec 2018 08:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gb4Ak-0000l0-8O for bug-gnu-emacs@gnu.org; Sun, 23 Dec 2018 08:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Khaled Hosny Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Dec 2018 13:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33729 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33729-submit@debbugs.gnu.org id=B33729.15455730812850 (code B ref 33729); Sun, 23 Dec 2018 13:52:02 +0000 Original-Received: (at 33729) by debbugs.gnu.org; 23 Dec 2018 13:51:21 +0000 Original-Received: from localhost ([127.0.0.1]:60611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gb4A5-0000jr-7p for submit@debbugs.gnu.org; Sun, 23 Dec 2018 08:51:21 -0500 Original-Received: from mail-wm1-f52.google.com ([209.85.128.52]:37036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gb4A4-0000ja-0j for 33729@debbugs.gnu.org; Sun, 23 Dec 2018 08:51:20 -0500 Original-Received: by mail-wm1-f52.google.com with SMTP id g67so9876886wmd.2 for <33729@debbugs.gnu.org>; Sun, 23 Dec 2018 05:51:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=oHqB464v2DcOygKq/1ULYmQb8jGmH7avhL9st7Y1wUM=; b=uiBnUO36mRbYXD/UX7P6FG3DuzBj0qdTzbB74W4cYW0Y1Y/5pniOMjuWXn6/UlMFny p4uz8ge6QXDhKc7yqEMBDdr0dldEX/y2dLcz9uua9OdOOQ01LqupNFR4Jx3aqlnIprqs AqdH9ERtcLfvUZlp2EsqV3CNEYptp0sqA46Y6Fk9Pr2LaoQJOtTn4OZ03RW5fjFsk8CI eiCY1vszJAaA9wpVLuWtQfoAwNFxdcsA2hbA3b2kGBc4890O0ltgLHQlqIRlN8692YgQ SxkAesK4Hfs5Fy9pXzdabqfo7zr2wxgxgYwRr81uCVprMJX8QtfurmIg7kFnDPqgOWRI h14g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=oHqB464v2DcOygKq/1ULYmQb8jGmH7avhL9st7Y1wUM=; b=r9/3675aqdOC2FDP7YY3yQ3QgBjvZ0n9/4TbaQdj30eSNm6XURdU0EVLoL6S+iG0MZ AqNGY5TyPfpuRBzF+cqei52Fzwh5+m/XF07hUyJE5NFOOeKbnMxyqMffo+kBUIv+iABA t2lq8y99xE1SlO6k99Dtd3daz2Y/omMClNpmAFq24zZI/HT9l8bdLOruQUEDDL0uxG6B Gi37DrAlJY01MyQMlAUSgv/eko7ogAmWz9oFk8MyTJ8E8A5aGFdiHS9EUw7t8aEajbz7 rMkrWcnFMiGWkkHhMh/UJq4rsEYxwVIZ4xQm9wbufWuV/Bn1zr+k31Tmct6Jhn8BPh8+ ewyg== X-Gm-Message-State: AA+aEWYA2wxRLHzLU788Z+BxiaXa3+Jf7xDvq6rSZ9HIl5FudS52JXV+ wCDzJHu9MwWYVX4TvAl2LxUNzF23fvU= X-Google-Smtp-Source: AFSGD/V3rAMYu7OwSwHrIwLNknMjUVlDnZ/PlmCP44V82bYOwcUgN/klT4c171wqbGwzpagXhHKs/w== X-Received: by 2002:a7b:c156:: with SMTP id z22mr9235362wmi.24.1545573074238; Sun, 23 Dec 2018 05:51:14 -0800 (PST) Original-Received: from macbook.localdomain ([41.237.113.27]) by smtp.gmail.com with ESMTPSA id t5sm16754031wmd.15.2018.12.23.05.51.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 23 Dec 2018 05:51:13 -0800 (PST) Content-Disposition: inline In-Reply-To: <838t0gapcj.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153785 Archived-At: On Sun, Dec 23, 2018 at 05:34:04AM +0200, Eli Zaretskii wrote: > > Date: Sat, 22 Dec 2018 22:59:48 +0200 > > From: Khaled Hosny > > Cc: rgm@gnu.org, far.nasiri.m@gmail.com, behdad@behdad.org, > > 33729@debbugs.gnu.org, kaushal.modi@gmail.com > > > > On Sat, Dec 22, 2018 at 09:38:43PM +0200, Eli Zaretskii wrote: > > > > Date: Sat, 22 Dec 2018 17:49:45 +0200 > > > > From: Khaled Hosny > > > > Cc: rgm@gnu.org, far.nasiri.m@gmail.com, behdad@behdad.org, > > > > 33729@debbugs.gnu.org, kaushal.modi@gmail.com > > > > > > > > Yes, the standard Unicode composition and decomposition. HarfBuzz uses > > > > these during shaping (it prefers composed form for a given sequence if > > > > supported by the font, and falls back to decomposed form otherwise). > > > > > > Btw, how is this problem solved in the other projects that use > > > Harfuzz? Does every project need to provide this functionality, or > > > does Harfuzz have it built-in, like with the script tags? If there's > > > built-in support for this, perhaps Emacs could just use that? > > > > There is built-in support, and currently we are using that. I can just > > remove the FIXME. > > Are there any disadvantages in using the built-in support? I mean, > why did you envision an Emacs-specific implementation in the first > place? I thought, but I might be mistaken, that Emacs allow changing these character properties at runtime and someone might possibly want to use that to change some character property (e.g. make some PUA character a combining mark) and it would then be nice if HarfBuzz respected that. I admit that is very niche thing if possible at all, and I’m more than happy to let HarfBuzz use it default Unicode functions and simplify the Emacs integration code. Regards, Khaled