From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Khaled Hosny Newsgroups: gmane.emacs.bugs Subject: bug#33729: 27.0.50; Partial glyphs not rendered for Gujarati with Harfbuzz enabled (renders fine using m17n) Date: Sat, 22 Dec 2018 11:06:44 +0200 Message-ID: <20181222090644.GB2244@macbook.localdomain> References: <83h8fghcpo.fsf@gnu.org> <20181214075056.GI2244@macbook.localdomain> <8336r0h1cb.fsf@gnu.org> <20181214110316.GK2244@macbook.localdomain> <83y38sfcme.fsf@gnu.org> <83tvjgf7ux.fsf@gnu.org> <83mup4du5z.fsf@gnu.org> <20181222085448.GA2244@macbook.localdomain> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1545469505 16726 195.159.176.226 (22 Dec 2018 09:05:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 22 Dec 2018 09:05:05 +0000 (UTC) User-Agent: Mutt/1.11.1 (2018-12-01) Cc: behdad@behdad.org, 33729@debbugs.gnu.org, far.nasiri.m@gmail.com, kaushal.modi@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 22 10:05:01 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gadDQ-0004CC-Lt for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Dec 2018 10:05:00 +0100 Original-Received: from localhost ([::1]:59655 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gadFX-0006a3-Ej for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Dec 2018 04:07:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gadFR-0006Zw-8p for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 04:07:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gadFO-0000e1-2x for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 04:07:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54865) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gadFN-0000dd-VB for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 04:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gadFN-0003LB-Mr for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 04:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Khaled Hosny Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Dec 2018 09:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33729 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33729-submit@debbugs.gnu.org id=B33729.154546961812831 (code B ref 33729); Sat, 22 Dec 2018 09:07:01 +0000 Original-Received: (at 33729) by debbugs.gnu.org; 22 Dec 2018 09:06:58 +0000 Original-Received: from localhost ([127.0.0.1]:59123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gadFJ-0003Kt-O2 for submit@debbugs.gnu.org; Sat, 22 Dec 2018 04:06:58 -0500 Original-Received: from mail-wm1-f54.google.com ([209.85.128.54]:32970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gadFH-0003Kg-4V for 33729@debbugs.gnu.org; Sat, 22 Dec 2018 04:06:55 -0500 Original-Received: by mail-wm1-f54.google.com with SMTP id r24so15772214wmh.0 for <33729@debbugs.gnu.org>; Sat, 22 Dec 2018 01:06:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=qcVpSqdJ7le6hJGh1xq2XYove73A1hkwlqmQilswBlg=; b=IqdSXy7NYYfTJf6JVpXXQfMzClq47agW0S6D4RGKHraKF2hJwLXX8cBqUyhrmVRJXx eQKerx6JYZ6yZHk8HSBAYxS5XS5mEwmsmZsdAtJNa/URJE2NiqatQeB90AdBLxlOWPIy S6ScewS6zuF3VNOpnlEvxeviqQZqTSzoML//x+iap0YSX2hewAJLjeK8g3cKFEpT1t/V YtnQ9BR+pPIAAVuWj9mtr0CWdzz15nHb0Y9+Iz3i1cV1bi3z4yb3mmpNhwZp9KOQdRge pUtcRMyZ/Is6dJUI326kPklBzqb+GR4CRGE8Ox/nxsBhZIwrbCZCuYwp+sdO2j9koyf1 BMAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=qcVpSqdJ7le6hJGh1xq2XYove73A1hkwlqmQilswBlg=; b=t8VEV0Obds3tVm6xW2CMUIm0Fc76rozaMVkGnpw6SgcoHdW2VhtD+Wm/Y/7KtNBeub aFVBfi37aAm7WJBp3Kf+gGoQ5RqBT99BUKHFg1BvnaalAm0GVyaOScpodSJFuNbcI7Kp 3EY+38ptRevGGKJ4cruLaPhHZSpkYt2WstD+3quXGi8p+wpOn8TlDw5yFxn03W2Fbjdn 972nrEdFHJBEUk0sKt19zs7yO5lkPF36Q1/FbjNfi7xRKSh+hZxOq5Q8u7gCU6syRbKX BCdeGCyP1jzfvA+MyauHUbc9e1xgKNEYfyG8OlkXp7k31DB/gdPPy0lLZ1yZSNH5uPOC iVww== X-Gm-Message-State: AA+aEWYPAy/HGtTC+YtA8y87aBgIs8cUGwVJct7wpfN+DVnr1pa1HPUx tEGV+CZi7+Po9ti4C0kq/EY= X-Google-Smtp-Source: ALg8bN7NCM1gVRooZKeSJbI1hoZxNuxkcFb/pev7neADnmX+XmJ+bFAEZeAaoqZH/gDK8Pjyv7XFnA== X-Received: by 2002:a1c:2787:: with SMTP id n129mr5997486wmn.128.1545469609316; Sat, 22 Dec 2018 01:06:49 -0800 (PST) Original-Received: from macbook.localdomain ([41.237.113.27]) by smtp.gmail.com with ESMTPSA id f66sm16252507wmd.28.2018.12.22.01.06.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Dec 2018 01:06:48 -0800 (PST) Content-Disposition: inline In-Reply-To: <20181222085448.GA2244@macbook.localdomain> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153718 Archived-At: On Sat, Dec 22, 2018 at 10:54:48AM +0200, Khaled Hosny wrote: > On Mon, Dec 17, 2018 at 05:55:52PM +0200, Eli Zaretskii wrote: > > > From: Glenn Morris > > > Cc: far.nasiri.m@gmail.com, dr.khaled.hosny@gmail.com, behdad@behdad.org, 33729@debbugs.gnu.org, kaushal.modi@gmail.com > > > Date: Sun, 16 Dec 2018 19:30:00 -0500 > > > > > > > After some thinking, my conclusion is that we should import the > > > > ISO 15924 database from https://unicode.org/iso15924/, use a script > > > > similar to admin/unidata/blocks.awk to generate an alist from it that > > > > maps Emacs script names to ISO 15924 tags, and then access that alist > > > > from uni_script to get the correct script information to Harfbuzz. > > > > > > > > Patches implementing that are welcome. > > > > > > I live to write awk scripts. I'm not 100% sure what you want, but as a > > > first example, the following takes > > > http://www.unicode.org/Public/UCD/latest/ucd/PropertyValueAliases.txt > > > as input and outputs lines of the form "(gujr . gujarati)". > > > > > > The aliases are so that the RHS matches charscript.el. > > > > > > If this is not right, please clarify exactly what the inputs and output > > > should be. > > > > Thanks. > > > > It turns out I didn't have this figured out completely, and your > > proposal forced me to dig some more into the relevant parts of Unicode > > and Emacs. I found a few additional issues and considerations; for at > > least some of them I'd like to hear the opinions of the Harfbuzz > > developers. > > > > Here are the issues: > > > > . Contrary to my original thoughts, I now tend to think that a > > separate char-table, say char-iso159240tag-table, that maps > > character codepoints directly to the script tags, is a better > > solution: > > - it will allow a faster look up, obviously > > - the subdivision of characters into scripts, as shown in > > Unicode's Scripts.txt, is slightly different from what > > char-script-table does, so a simple mapping from Emacs scripts > > to ISO 15924 script tag will not do. For example, many > > characters Emacs puts into 'latin' or 'symbol' scripts are in > > the Common script according to Scripts.txt, and similarly for > > the Inherited script. I imagine this is important for > > Harfbuzz. > > Alternatively, we could just use HarfBuzz’s own built in ucdn-based > Unicode function for this. The only reason for overriding this in Emacs > was to keep HarfBuzz and Emacs Unicode support in sync, but if we are > going to duplicate the Unicode script data then better use what HarfBuzz > has. > > I’m going to try this now. I pushed a commit to harfbuzz branch that I think fixes this issue now. Regards, Khaled