From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Khaled Hosny Newsgroups: gmane.emacs.bugs Subject: bug#33729: 27.0.50; Partial glyphs not rendered for Gujarati with Harfbuzz enabled (renders fine using m17n) Date: Sat, 22 Dec 2018 10:54:48 +0200 Message-ID: <20181222085448.GA2244@macbook.localdomain> References: <20181213203102.GF2244@macbook.localdomain> <83h8fghcpo.fsf@gnu.org> <20181214075056.GI2244@macbook.localdomain> <8336r0h1cb.fsf@gnu.org> <20181214110316.GK2244@macbook.localdomain> <83y38sfcme.fsf@gnu.org> <83tvjgf7ux.fsf@gnu.org> <83mup4du5z.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1545468789 23637 195.159.176.226 (22 Dec 2018 08:53:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 22 Dec 2018 08:53:09 +0000 (UTC) User-Agent: Mutt/1.11.1 (2018-12-01) Cc: behdad@behdad.org, 33729@debbugs.gnu.org, far.nasiri.m@gmail.com, kaushal.modi@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 22 09:53:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gad1s-00060d-1c for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Dec 2018 09:53:04 +0100 Original-Received: from localhost ([::1]:58160 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gad3y-0004Y6-T1 for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Dec 2018 03:55:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56081) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gad3p-0004Xk-U4 for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 03:55:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gad3m-0001xs-Oi for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 03:55:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54857) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gad3m-0001xm-Ks for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 03:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gad3m-000327-F6 for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 03:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Khaled Hosny Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Dec 2018 08:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33729 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33729-submit@debbugs.gnu.org id=B33729.154546890111650 (code B ref 33729); Sat, 22 Dec 2018 08:55:02 +0000 Original-Received: (at 33729) by debbugs.gnu.org; 22 Dec 2018 08:55:01 +0000 Original-Received: from localhost ([127.0.0.1]:59115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gad3l-00031p-BA for submit@debbugs.gnu.org; Sat, 22 Dec 2018 03:55:01 -0500 Original-Received: from mail-wr1-f43.google.com ([209.85.221.43]:43291) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gad3j-00031b-VR for 33729@debbugs.gnu.org; Sat, 22 Dec 2018 03:55:00 -0500 Original-Received: by mail-wr1-f43.google.com with SMTP id r10so7419539wrs.10 for <33729@debbugs.gnu.org>; Sat, 22 Dec 2018 00:54:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=rliGVy5bZ70psuVdS/D/r1p74GeUq82RaemItH03TYI=; b=YuEzu+sIfleHp5GNHEqHqh642SjR+XmFLP1PHOHmtt8qhVZf1Fl7jZoo85KYbaPuks ZKsXKSXtLqX56dWyFH7/ycmiAZDNqN5ostkOjpMQKY0XZTApfj5QkFKy65arp8SFZ0jw QgInCNBWGSSVOVnI1FeEFu4vvQRnYqSGkIBjM6G6dN8P7ODAiG6lr2Y6CUTqgWZJp/0l odw/N31zfWasGj2v13bcAueI1u4dbNq5Myi7deY2TBddA2dpO5fWpb0OZbSJhUdBDxLy 8SmvO+PKykfNxFwKAH+WMPOsTmiWR5n607C5n30wjHdPgN8GfWQQ7Xk0HBTqH3E4LHiL oPWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=rliGVy5bZ70psuVdS/D/r1p74GeUq82RaemItH03TYI=; b=CMJnk0wMlrjd+ntx3B1fLHwXXstWMDitJ7N3RG3qRBtDcv99PXQeRYNItiXUSxMZkx dVEYAEjTelC6LCwSvOFbb0YROyKTZAxzuWmj0LCuuW0Ahv4SFZNLXWqK9UiCxnBuhMRi 7bd81eloqfpkGBE7KjLt3kIpnFgi2LFRVTYbpN7lE7hF16dIcbSpt3hoYgY/TcNvqysL ubqE9opRDCQfA0vOTVp9TR0xthWiIvtXW6EDSPTeqm5WpNxHPrKfIrFjEs8VSpALQ75j aZl2Kxy8uk61qUp+NT5XrLGPokQiI7YN7C5qDFrp1IHqIbQqTarUWRuj49Y+lFSFiCNP KJuQ== X-Gm-Message-State: AJcUukc6XPwtRuPW55qAhC74oH4ZN9cw3lywIJprOY4vYR5HMkc8Zsgz n5gUIIf8gsfa+f/esSPNn1o= X-Google-Smtp-Source: ALg8bN5R62WqAdCQ89223V0P/hfCbZBZSsyZ5DSOFOOmb9oHtu8seaovPZF+aEaLPEfFTPB+cvU+pg== X-Received: by 2002:adf:c452:: with SMTP id a18mr5644838wrg.145.1545468894122; Sat, 22 Dec 2018 00:54:54 -0800 (PST) Original-Received: from macbook.localdomain ([41.237.113.27]) by smtp.gmail.com with ESMTPSA id c77sm16246250wmh.12.2018.12.22.00.54.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Dec 2018 00:54:52 -0800 (PST) Content-Disposition: inline In-Reply-To: <83mup4du5z.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153716 Archived-At: On Mon, Dec 17, 2018 at 05:55:52PM +0200, Eli Zaretskii wrote: > > From: Glenn Morris > > Cc: far.nasiri.m@gmail.com, dr.khaled.hosny@gmail.com, behdad@behdad.org, 33729@debbugs.gnu.org, kaushal.modi@gmail.com > > Date: Sun, 16 Dec 2018 19:30:00 -0500 > > > > > After some thinking, my conclusion is that we should import the > > > ISO 15924 database from https://unicode.org/iso15924/, use a script > > > similar to admin/unidata/blocks.awk to generate an alist from it that > > > maps Emacs script names to ISO 15924 tags, and then access that alist > > > from uni_script to get the correct script information to Harfbuzz. > > > > > > Patches implementing that are welcome. > > > > I live to write awk scripts. I'm not 100% sure what you want, but as a > > first example, the following takes > > http://www.unicode.org/Public/UCD/latest/ucd/PropertyValueAliases.txt > > as input and outputs lines of the form "(gujr . gujarati)". > > > > The aliases are so that the RHS matches charscript.el. > > > > If this is not right, please clarify exactly what the inputs and output > > should be. > > Thanks. > > It turns out I didn't have this figured out completely, and your > proposal forced me to dig some more into the relevant parts of Unicode > and Emacs. I found a few additional issues and considerations; for at > least some of them I'd like to hear the opinions of the Harfbuzz > developers. > > Here are the issues: > > . Contrary to my original thoughts, I now tend to think that a > separate char-table, say char-iso159240tag-table, that maps > character codepoints directly to the script tags, is a better > solution: > - it will allow a faster look up, obviously > - the subdivision of characters into scripts, as shown in > Unicode's Scripts.txt, is slightly different from what > char-script-table does, so a simple mapping from Emacs scripts > to ISO 15924 script tag will not do. For example, many > characters Emacs puts into 'latin' or 'symbol' scripts are in > the Common script according to Scripts.txt, and similarly for > the Inherited script. I imagine this is important for > Harfbuzz. Alternatively, we could just use HarfBuzz’s own built in ucdn-based Unicode function for this. The only reason for overriding this in Emacs was to keep HarfBuzz and Emacs Unicode support in sync, but if we are going to duplicate the Unicode script data then better use what HarfBuzz has. I’m going to try this now. > . Whether to produce the character-to-script-tag mapping using the > UCD files, such as Scripts.txt and PropertyValueAliases.txt, or the > canonical ISO 15924 tags from https://unicode.org/iso15924/, > depends on whether the slight differences mentioned in > https://www.unicode.org/reports/tr24/#Relation_To_ISO15924 matter > for Harfbuzz. For example, ISO 15924 has separate tags for the > Fraktur and Gaelic varieties of the Latin script: does this > distinction matter for Harfbuzz? We want the UCD data. Regards, Khaled