From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Khaled Hosny Newsgroups: gmane.emacs.bugs Subject: bug#33748: 27.0.50; harfbuzz branch fails to compile Date: Sat, 15 Dec 2018 12:32:17 +0200 Message-ID: <20181215103217.GO2244@macbook.localdomain> References: <20181214225253.GM2244@macbook.localdomain> <83h8ffff6o.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1544869869 18461 195.159.176.226 (15 Dec 2018 10:31:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 15 Dec 2018 10:31:09 +0000 (UTC) User-Agent: Mutt/1.11.1 (2018-12-01) Cc: behdad@behdad.org, 33748@debbugs.gnu.org, far.nasiri.m@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 15 11:31:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gY7Ds-0004hR-If for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Dec 2018 11:31:04 +0100 Original-Received: from localhost ([::1]:38522 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gY7Fz-0002oE-DH for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Dec 2018 05:33:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gY7Fr-0002nv-9b for bug-gnu-emacs@gnu.org; Sat, 15 Dec 2018 05:33:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gY7Fm-0007Du-Ts for bug-gnu-emacs@gnu.org; Sat, 15 Dec 2018 05:33:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44713) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gY7Fm-0007Dj-Pb for bug-gnu-emacs@gnu.org; Sat, 15 Dec 2018 05:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gY7Fm-0006rq-K8 for bug-gnu-emacs@gnu.org; Sat, 15 Dec 2018 05:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Khaled Hosny Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Dec 2018 10:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33748 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-Cc: behdad@behdad.org, bug-gnu-emacs@gnu.org, far.nasiri.m@gmail.com Original-Received: via spool by submit@debbugs.gnu.org id=B.154486996126371 (code B ref -1); Sat, 15 Dec 2018 10:33:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Dec 2018 10:32:41 +0000 Original-Received: from localhost ([127.0.0.1]:48971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gY7FQ-0006rF-RE for submit@debbugs.gnu.org; Sat, 15 Dec 2018 05:32:41 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:36429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gY7FP-0006r2-Qk for submit@debbugs.gnu.org; Sat, 15 Dec 2018 05:32:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gY7FJ-0006x0-V5 for submit@debbugs.gnu.org; Sat, 15 Dec 2018 05:32:34 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:59024) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gY7FJ-0006ws-Qb for submit@debbugs.gnu.org; Sat, 15 Dec 2018 05:32:33 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46030) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gY7FI-0002J8-So for bug-gnu-emacs@gnu.org; Sat, 15 Dec 2018 05:32:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gY7FH-0006sy-0u for bug-gnu-emacs@gnu.org; Sat, 15 Dec 2018 05:32:32 -0500 Original-Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:35135) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gY7FA-0006pk-Md; Sat, 15 Dec 2018 05:32:24 -0500 Original-Received: by mail-wr1-x431.google.com with SMTP id 96so7719029wrb.2; Sat, 15 Dec 2018 02:32:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=JdXT+r6CDzLldQMnH54JlZYDP+8IbcgbJxh3XqNTzBM=; b=pLiGYeLIZGudQUqODVHWeRsDEEzh/C8Rbe1KpD3KkGHHMEJFfouvWR5lZ1VNYD6v+z WlM+VI939OLF0AgxJdw6bHi0MNxOxkivwZrp+yEWEOEbkfQnAej47YelH2dkTVCT9smp Vv9gnm88j7Ht0wJY8JDxF7jtS7KIUpiZmJ2dIt9uDOZ75LBMYCkXr4aoucaIDwuHMyBv NHZAoy9LFwYZOv5ye7SrkGwMvszEgxz0QBp/IMsk5vVjF+Dx++sIB7V1xBRnpyliCrRY 9hRwlwSukLiSAKpwbaZRoxx8pxYEwLiscnkFpkbfu1uHhfAZ32GcRwNZm3Z2/EWQrhwy eyzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=JdXT+r6CDzLldQMnH54JlZYDP+8IbcgbJxh3XqNTzBM=; b=bGvqeHBfq5EO1t1l57VWFC9MQu8oNOL2ClgEesLdrJ59hOZBg2v/9uU9JKxk3DOzyl +2sW22c4m0s7GzY0SSIjJwXrD3aISwbz1bqoYaxv/BA5ZOkMdSrP1ehg1EaPhjS9FRiC 0noO+wuY/bGdoSqR4p4vkNvndopwrCem+dXRZMMUzYi/2xf2XOfGVq8O9cQYnv4iTCjy NNH9ipizhwOqUDIj7r50OXbf9J+dvQd2sL6tZtWwDc5fFdYzhRTgUnNbU6mKxp9qxxyG 8y/KE7yiL26HxCox3hK6JABK7LUc1Hl8lWP7vTvq8S0vt2x9IiByWzkpW0fJ2K0l36pN jDvA== X-Gm-Message-State: AA+aEWZAw0N4o1gpdSp+QNW/2lxF9hX4S1J10r3w4LIvWuFJjjzmP873 IF74crBsVtGYAJ0VBmEHAsP1mUu8 X-Google-Smtp-Source: AFSGD/WMDAyzWoSpCR7K4b4X3BEq/jMPaklv+ph9Lmo3p3E2dISDwXvF4G9J9u2q60sNdulwB9zvUQ== X-Received: by 2002:adf:f8cf:: with SMTP id f15mr5226388wrq.265.1544869941913; Sat, 15 Dec 2018 02:32:21 -0800 (PST) Original-Received: from macbook.localdomain ([197.58.120.254]) by smtp.gmail.com with ESMTPSA id n15sm11540302wrt.21.2018.12.15.02.32.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 15 Dec 2018 02:32:21 -0800 (PST) Content-Disposition: inline In-Reply-To: <83h8ffff6o.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153480 Archived-At: On Sat, Dec 15, 2018 at 08:59:43AM +0200, Eli Zaretskii wrote: > > Date: Sat, 15 Dec 2018 00:52:53 +0200 > > From: Khaled Hosny > > Cc: bug-gnu-emacs@gnu.org, far.nasiri.m@gmail.com, behdad@behdad.org > > > > > The version of Harfbuzz I have on this machine is 0.9.27. If this too old? If so, what minimum version do I need to successfully build the branch? > > > > Seems so. You can add configure.ac checks for hb_buffer_set_cluster_level > > and use it conditionally, or require a newer HarfBuzz version. I prefer > > the later, since the behaviour of cluster level 1 is assumed elsewhere > > in the code (I don’t recall what exactly). > > Which oldest version of HarfBuzz would you prefer us to require? Is > 0.9.42 OK, or do we need a newer one? I’d prefer the latest version of course, there have been lots of bug fixes and new features since then. If one is building his own HarfBuzz, then definitely the latest version, otherwise the one that comes with the system is good enough (Emacs wouldn’t be disadvantaged anymore than any HarfBuzz-using application on the said system), as long as it has the APIs we use. Regards, Khaled