From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Khaled Hosny Newsgroups: gmane.emacs.bugs Subject: bug#33729: 27.0.50; Partial glyphs not rendered for Gujarati with Harfbuzz enabled (renders fine using m17n) Date: Fri, 14 Dec 2018 13:03:16 +0200 Message-ID: <20181214110316.GK2244@macbook.localdomain> References: <20181213203102.GF2244@macbook.localdomain> <83h8fghcpo.fsf@gnu.org> <20181214075056.GI2244@macbook.localdomain> <8336r0h1cb.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1544785333 24783 195.159.176.226 (14 Dec 2018 11:02:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 14 Dec 2018 11:02:13 +0000 (UTC) User-Agent: Mutt/1.11.1 (2018-12-01) Cc: behdad@behdad.org, kaushal.modi@gmail.com, 33729@debbugs.gnu.org, far.nasiri.m@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 14 12:02:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXlEO-0006Lr-Ij for geb-bug-gnu-emacs@m.gmane.org; Fri, 14 Dec 2018 12:02:08 +0100 Original-Received: from localhost ([::1]:60939 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXlGV-00007C-FQ for geb-bug-gnu-emacs@m.gmane.org; Fri, 14 Dec 2018 06:04:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXlGK-000072-KY for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 06:04:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXlGG-0004E2-JI for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 06:04:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43122) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gXlGG-0004DV-Ee for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 06:04:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gXlGE-0000vz-BS for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 06:04:04 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Khaled Hosny Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Dec 2018 11:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33729 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33729-submit@debbugs.gnu.org id=B33729.15447854083546 (code B ref 33729); Fri, 14 Dec 2018 11:04:02 +0000 Original-Received: (at 33729) by debbugs.gnu.org; 14 Dec 2018 11:03:28 +0000 Original-Received: from localhost ([127.0.0.1]:47380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXlFg-0000v8-2u for submit@debbugs.gnu.org; Fri, 14 Dec 2018 06:03:28 -0500 Original-Received: from mail-wm1-f49.google.com ([209.85.128.49]:33831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXlFe-0000ut-Iz for 33729@debbugs.gnu.org; Fri, 14 Dec 2018 06:03:27 -0500 Original-Received: by mail-wm1-f49.google.com with SMTP id y185so15969436wmd.1 for <33729@debbugs.gnu.org>; Fri, 14 Dec 2018 03:03:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=8k+AVQH5MB7DJfbVezJtjbDqtv3OFog7S/ao1HL+SRE=; b=WlEeO9fZk4mmoWuJcLfnyyAiNwAu7wolckVijYRy5xW7RDFLfLrNqthteyhKMIdihl +sMcOwMZ7fhREEMlEwJvGK+h0Eb5qBxJ7T9RdLTjwE9wTOvhrYOuAl7AGjj3U3exwgrI LmnPQRCukoUqbY1KsGAyHTUp6hY0578Cn7eEDk8Z96BqbL+galpVkGGalyQndlgCe8MG dnBYc3wjPQIx6L7GfvE8MVaw910k0ua2dtxNArcQub+O/KIYpOxf1mVtrM+4afKEUKZ4 CjPcUNKnc7etaorsv312Ly+o2qixQmePtDqTxWPIKmaKWGdbwUhhP+OAC3UgEPZAd7t3 4kuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=8k+AVQH5MB7DJfbVezJtjbDqtv3OFog7S/ao1HL+SRE=; b=OzA8ckWfjILi5UnMXKS1x+tOBGkUyLrU36YdlSQw/ZjROjB6zBYB8lhfTRP1qlgEIO 93RBHPjQu2nGr85cYlZ6YgEl2eJXsncDErpvl03K1Rlpll+73TU4/noSbgdM9MGDLSXt kGjjH0JvmRmemmJq4JRqRj+a0DZWE0rnji4oEnFXiH2VgZFgheIaPzesF91fejrZK0C6 8y6CCjqU18aLzh2IPJqJgdIMiIncNqB4KVhQnbCINADBM1TBepgx7lpVYJszU09Ftbmn XWeCjAphqUh+TVu4KgA6NZCl2YDlOLezr4g7noPLJ1V0j3xe06je7kmuBl2WRTt1CFi5 XTgQ== X-Gm-Message-State: AA+aEWYJUt+BJ6qn6Q93Ca1G8fWujRl23rA7Hvc+mmj/jwhtWGdj0N6N QUnORzDBBJSg1nENmCv2M8o= X-Google-Smtp-Source: AFSGD/W9CHYec424oiAJccQx38NkJQ36ksH+v1QEMpm3NDKPDeMSrOskQ9pAHgmEQRQFEOSMfcfMFw== X-Received: by 2002:a7b:c191:: with SMTP id y17mr2885711wmi.10.1544785400716; Fri, 14 Dec 2018 03:03:20 -0800 (PST) Original-Received: from macbook.localdomain ([197.58.120.254]) by smtp.gmail.com with ESMTPSA id 199sm4913398wmh.21.2018.12.14.03.03.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 14 Dec 2018 03:03:20 -0800 (PST) Content-Disposition: inline In-Reply-To: <8336r0h1cb.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153446 Archived-At: On Fri, Dec 14, 2018 at 12:03:32PM +0200, Eli Zaretskii wrote: > > Date: Fri, 14 Dec 2018 09:50:56 +0200 > > From: Khaled Hosny > > Cc: Kaushal Modi , behdad@behdad.org, > > 33729@debbugs.gnu.org, far.nasiri.m@gmail.com > > > > > Your data indicates that the m17n build performs character composition > > > at buffer position 34, whereas the harfbuzz build does not. The > > > question is why. > > > > See my earlier email, most likely the culprit is the broken Emacs to > > HarfBuzz script code mapping that we discussed earlier. HarfBuzz needs > > to know the correct script of the text to perform shaping, and it looks > > like we are passing nonsense values for certain scripts (or rather for > > certain scripts we are lucky that the mapping is not broken). > > Thanks. > > I don't yet have access to a GNU/Linux system with HarfBuzz installed, > so I cannot myself debug it. > > I hope Mohammad will be able to look into this and either fix it or > provide more focused and detailed analysis of what is wrong, so we > could fix it. Or maybe you could point to the problematic code and > tell more details. > > FWIW, I looked at ftfont.c:uni_script, and I cannot find a problem > with it; in particular looking up in char-script-table each character > of the Gujarati welcome in HELLO yields 'gujarati', so I couldn't see > any evident Emacs issue. Or are you saying that hb_script_from_string > doesn't DTRT? Or maybe Kaushal should upgrade to a newer version of > HarfBuzz? There is this FIXME: /* FIXME: from_string wants an ISO 15924 script tag here. */ As we discussed earlier, hb_script_from_string() expects ISO 15924 script tags, but char_script_table does not provide such tags (I don’t recall what it does provide exactly). We need a way to get ISO 15924 script tags from Emacs. Regards, Khaled