From: Alan Mackenzie <acm@muc.de>
To: Drew Adams <drew.adams@oracle.com>
Cc: 33601@debbugs.gnu.org
Subject: bug#33601: 26; Add macro `with-hook-added'
Date: Tue, 4 Dec 2018 20:10:48 +0000 [thread overview]
Message-ID: <20181204201048.GA13646@ACM> (raw)
In-Reply-To: <bd0aa687-8e35-4c63-b4a4-abefdcda99e4@default>
Hello, Drew.
On Tue, Dec 04, 2018 at 11:18:29 -0800, Drew Adams wrote:
> > > Enhancement request: Please consider adding a macro such as this, to
> > > facilitate temporary use of a hook function.
> > > (defmacro with-hook-added (hook function &rest body)
> > > "Evaluate forms in BODY with FUNCTION added to HOOK, then remove FUNCTION."
> > > (declare (indent 1) (debug t))
> > > `(unwind-protect (progn (add-hook ',hook ',function) ,@body)
> > > (remove-hook ',hook ',function)))
> > Just a big point: you need to test whether FUNCTION is already on HOOK
> > at the start, and if so, not remove it at the end.
> Hi Alan,
> A big point? Need to?
I think so, yes. The essence of the `with-...' macros is that they
temporarily change something, then evaluate ,@body, and at the end, the
something is restored to what it was.
If with-hook-added didn't preserve the hook, it would be an anomaly, an
outlier, and quite possibly a PITA.
> That wasn't the behavior I had in mind for this, but it's
> another possibility. I intended to provide only for the
> behavior of always removing at the end.
Why? What's the use case?
> There are in fact several different possibilities for such
> a macro. We could provide also for `add-hook' args APPEND
> and LOCAL. I left that out as well.
> Choices:
> 1. Provide a single macro for all such possibilities, with
> 3 (mandatory) args for APPEND, LOCAL and whether to remove
> FUNCTION at the end if it was already present at the outset.
> 2. Provide multiple macros, each specific for a given case.
> #2 would mean 8 macros, to cover all the combinations
> (nil or t for each of the 3 args).
How many of these would actually be of any use?
> Another possibility would be to accept a single arg for
> the BODY code, instead of that being a &rest parameter,
> and so be able to provide those 3 behavior-specifying
> args as optional. In that case, we'd want to decide on
> the best order among those args, e.g., based on which we
> expect to be used most often.
> I'm not sure what the right approach is. I think the
> most common use case would be the one I wrote up (but
> I don't know that):
> . Always remove FUNCTION at the end
> . Prepend, not append.
> . Global, not local.
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2018-12-04 20:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <<mailman.5097.1543862895.1284.bug-gnu-emacs@gnu.org>
[not found] ` <<20181204184614.2049.qmail@mail.muc.de>
2018-12-04 19:18 ` bug#33601: 26; Add macro `with-hook-added' Drew Adams
2018-12-04 20:10 ` Alan Mackenzie [this message]
2018-12-04 21:22 ` Drew Adams
2018-12-03 18:47 Drew Adams
2018-12-03 19:01 ` Glenn Morris
2018-12-03 20:58 ` Drew Adams
2018-12-03 19:03 ` Drew Adams
2018-12-03 22:37 ` Phil Sainty
2018-12-03 22:50 ` Drew Adams
2018-12-03 23:13 ` Phil Sainty
2018-12-03 23:51 ` Drew Adams
[not found] ` <mailman.5097.1543862895.1284.bug-gnu-emacs@gnu.org>
2018-12-04 18:46 ` Alan Mackenzie
2022-02-12 8:46 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204201048.GA13646@ACM \
--to=acm@muc.de \
--cc=33601@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.