From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: macOS fullscreen crashes Date: Sat, 1 Dec 2018 13:18:51 +0000 Message-ID: <20181201131851.GA65351@breton.holly.idiocy.org> References: <20181130110458.GA54580@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1543670247 8576 195.159.176.226 (1 Dec 2018 13:17:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 1 Dec 2018 13:17:27 +0000 (UTC) User-Agent: Mutt/1.10.1 (2018-07-13) Cc: emacs-devel@gnu.org To: "Charles A. Roelli" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 01 14:17:23 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gT599-00026s-1G for ged-emacs-devel@m.gmane.org; Sat, 01 Dec 2018 14:17:23 +0100 Original-Received: from localhost ([::1]:41297 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gT5BF-0001mI-B5 for ged-emacs-devel@m.gmane.org; Sat, 01 Dec 2018 08:19:33 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gT5Ae-0001mD-Iu for emacs-devel@gnu.org; Sat, 01 Dec 2018 08:18:57 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gT5Ad-0005gI-RP for emacs-devel@gnu.org; Sat, 01 Dec 2018 08:18:56 -0500 Original-Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:40552) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gT5Ad-0005ff-Kv for emacs-devel@gnu.org; Sat, 01 Dec 2018 08:18:55 -0500 Original-Received: by mail-wr1-x42b.google.com with SMTP id p4so7801782wrt.7 for ; Sat, 01 Dec 2018 05:18:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=CsRSEoVagmI6L48Qg9svxBD/J4tZVNQMIk6NxM4GFuY=; b=tqOpt+ROyS1FFDdNqz65t/rLtr7GveXvxJEqrsafwpvvSEZA5YZhLi3MZlsfmi1Ma4 Qr1ULAItAFB2n/L9NFm8Gyc9SteyWc8DrHgHnpoJAXipCaIUBFxJuxInPpBlkwrgDt+S BaBE0Cpz8u49hKJoEUXEBRxwR/VwQi5LhLs5QO+rVOeAGh8rh0CpFVDnqEErQAzxZYoV rssyxQUEu8r75t9JueZoxQbKRVtCvijqJxCP5gRLYYlQKJsWKoTfXpN/GwBiTiNHWf2q 70FmEIyvK/+aHnxq7KT86SBL8gS2rm+FCCwuoBN019GvfTBffa3jevoK05yM1Br/Vaos 6nZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=CsRSEoVagmI6L48Qg9svxBD/J4tZVNQMIk6NxM4GFuY=; b=k80kX+gQ8hpUjWBOMyBOmPnL69siOwQvQtbxQeCzBfxTPanqWTTn/t1dbP5xfHdTQm NQqn4Biv8S9Fm4mfe8V4FOayxEljOU7K8IcRM5820FRlTiSzTCvt2cKE3BIqIsTtMIEz qBFV5xdh1QE5zqFRpu2bLfbz2nTqknUVZi7hRRb/o5JOvsMMvsLZDnVTeA9kUTE5HsW8 rnG+JBvDDIJIV2U0id8UEh2f7GA7fjqPUwv5u0qP8cSfb8FFlCq6CF3YdEgWIRnJid0r 0ox0A5rFKBQIMAwtMmgeaokG+olNUviNtRkzIR+JZ4jpNPis0JsPrBwIfxVq2n144hyE OIVw== X-Gm-Message-State: AA+aEWaC6fTpxhPVgu95rL8Fr0yAJ5MakYkZuC2TzdJi7PM5yYYFubHW pUL1MlN3pLSSZRFDTas98FpIAT5U X-Google-Smtp-Source: AFSGD/WzT6Zku6AzVk4jeJm2Z8eEL88/Z5oaNsX9BiiEi7zf/Bda08DpyAFxQEybPyadXEXlL8kyvg== X-Received: by 2002:adf:ee89:: with SMTP id b9mr8494816wro.246.1543670334159; Sat, 01 Dec 2018 05:18:54 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-c0c6-f0c8-876b-ed70.holly.idiocy.org. [2001:8b0:3f8:8129:c0c6:f0c8:876b:ed70]) by smtp.gmail.com with ESMTPSA id b129sm1469520wmd.24.2018.12.01.05.18.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 01 Dec 2018 05:18:53 -0800 (PST) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231554 Archived-At: On Sat, Dec 01, 2018 at 12:21:13PM +0100, Charles A. Roelli wrote: > > Date: Fri, 30 Nov 2018 11:04:58 +0000 > > From: Alan Third > > > > We still occasionally receive bug reports about crashes on macOS > > 10.12+ caused by macOS turning fullscreen windows into ‘tabbed’ > > windows. I’ve also seen it discussed in a few places round the web. > > > > We currently have a compile‐time check to include code that fixes this > > on 10.12+, and it can be over‐ridden if Emacs is being built on an > > older version of macOS but is expected to run on 10.12+, however it is > > clearly not doing the job. > > Do you know why? It sounds like people are using builds made on an > older macOS without setting MAC_OS_X_VERSION_MIN_REQUIRED and > MAC_OS_X_VERSION_MAX_ALLOWED appropriately. Maybe we should call out > in NEWS (in branch emacs-26, that is) and/or nextstep/README how > exactly to do this. Yes, you’re right, we should probably try education first. BTW, it looks like there are two different sets of macros for this, there are the ones we’re using, and newer ones defined in Availability.h that have two underscores at the start. It looks like the newer ones are a bit neater. If you use -mmacosx-version-min=10.x it disables a great many deprecation warnings that you get if you just set MAC_OS_X_VERSION_MIN_REQUIRED like we do. I don’t think we should be changing anything at the moment, and I don’t know if those macros are available on macOS 10.6 so they may not be much use to us, but it is nice how it makes the compiler output a lot quieter. So, anyway, perhaps we want to put something like this in nextstep/INSTALL: Targeting different macOS versions ---------------------------------- The Emacs build process automatically enables or disables macOS features according to the version of macOS it is being built on. It is possible to over-ride this automatic configuration if you are targeting a different version of macOS, or wish to build one executable that is able to enable or disable features at run-time. To build a version compatible with an older version of macOS use this flag: -DMAC_OS_X_VERSION_MIN_REQUIRED=x and to build for a newer version of macOS: -DMAC_OS_X_VERSION_MAX_ALLOWED=x For example, to enable run-time checks for features available between macOS 10.6, and 10.12 inclusive: ./configure --with-ns CFLAGS="-DMAC_OS_X_VERSION_MIN_REQUIRED=1060 \ -DMAC_OS_X_VERSION_MAX_ALLOWED=101200 -g3 -O2" The macOS version numbers are formatted as 10x0 for macOS up to 10.10, and 10xx00 for macOS 10.10 and above. A full list is available in /usr/include/AvailabilityMacros.h. -- Alan Third