From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: master 1ca436a: Make compilation mode work with warnings from compiled buffer functions Date: Wed, 28 Nov 2018 20:16:00 +0000 Message-ID: <20181128201600.GA5331@ACM> References: <20181128132417.30869.1170@vcs0.savannah.gnu.org> <20181128132418.851A9204F1@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1543437249 32314 195.159.176.226 (28 Nov 2018 20:34:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 28 Nov 2018 20:34:09 +0000 (UTC) User-Agent: Mutt/1.10.1 (2018-07-13) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 28 21:34:05 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gS6X7-0008I4-7y for ged-emacs-devel@m.gmane.org; Wed, 28 Nov 2018 21:34:05 +0100 Original-Received: from localhost ([::1]:49867 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gS6ZD-0002p3-QE for ged-emacs-devel@m.gmane.org; Wed, 28 Nov 2018 15:36:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46289) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gS6VL-0006Ww-1h for emacs-devel@gnu.org; Wed, 28 Nov 2018 15:32:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gS6J8-0002l5-DV for emacs-devel@gnu.org; Wed, 28 Nov 2018 15:19:41 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:59980 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1gS6J8-0002ju-65 for emacs-devel@gnu.org; Wed, 28 Nov 2018 15:19:38 -0500 Original-Received: (qmail 76437 invoked by uid 3782); 28 Nov 2018 20:19:36 -0000 Original-Received: from acm.muc.de (p2E5D5BA9.dip0.t-ipconnect.de [46.93.91.169]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 28 Nov 2018 21:19:35 +0100 Original-Received: (qmail 15265 invoked by uid 1000); 28 Nov 2018 20:16:00 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231497 Archived-At: Hello, Glenn. On Wed, Nov 28, 2018 at 11:37:55 -0500, Glenn Morris wrote: > Hi, > Alan Mackenzie wrote: > > --- a/lisp/emacs-lisp/bytecomp.el > > +++ b/lisp/emacs-lisp/bytecomp.el > > @@ -124,6 +124,7 @@ > > (require 'backquote) > > (require 'macroexp) > > (require 'cconv) > > +(require 'compile) > I would expect this extra require to slow down bootstrap, for an issue > that is not relevant to bootstrap (bug#33475)? I've looked at this, and I don't think there would be other than a microscopic slowdown. The previous version of bytecomp.el used at least one function in compile.el (namely compilation-mode), suggesting that compile.elc? is already loaded when bytecomp starts. However, for some fiddly reason a macro in compile.el was no longer defined, hence the require. > Can this be avoided? Yes it can, by moving the declaration of emacs-lisp-compilation-mode out of bytecomp.el, probably into compile.el itself. > Indeed, my automatic overnight build today was about 13 mins, whereas > every previous day this month was < 11.5 mins. I've timed several builds, and seen no differences between before and after, appart from normal measurement error. I see 2min 29sec +- 1 second for "cold starts", and 2min 3sec += 1 second for a subsequent build, when all the source files are in filestore cache. Are you sure that bug #33475 is the cause of your slowdown? -- Alan Mackenzie (Nuremberg, Germany).