From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstraps. Date: Sun, 25 Nov 2018 19:36:15 +0000 Message-ID: <20181125193614.GI27152@ACM> References: <83muq7u9rk.fsf@gnu.org> <20181123130904.GA2916@ACM> <20181125143125.GA27152@ACM> <87y39h6vie.fsf@igel.home> <20181125154203.GB27152@ACM> <838t1hjejt.fsf@gnu.org> <20181125175929.GE27152@ACM> <83y39hhvlp.fsf@gnu.org> <20181125182330.GG27152@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1543174698 1575 195.159.176.226 (25 Nov 2018 19:38:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 25 Nov 2018 19:38:18 +0000 (UTC) User-Agent: Mutt/1.10.1 (2018-07-13) Cc: cpitclaudel@gmail.com, charles@aurox.ch, michael_heerdegen@web.de, emacs-devel@gnu.org, schwab@linux-m68k.org, monnier@IRO.UMontreal.CA To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 25 20:38:14 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gR0EN-0000FG-0x for ged-emacs-devel@m.gmane.org; Sun, 25 Nov 2018 20:38:11 +0100 Original-Received: from localhost ([::1]:32777 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gR0GT-0008Fx-E3 for ged-emacs-devel@m.gmane.org; Sun, 25 Nov 2018 14:40:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gR0Fm-0008Ek-3B for emacs-devel@gnu.org; Sun, 25 Nov 2018 14:39:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gR0Fi-0003ck-Bx for emacs-devel@gnu.org; Sun, 25 Nov 2018 14:39:38 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:58255 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1gR0Fi-0003c3-5J for emacs-devel@gnu.org; Sun, 25 Nov 2018 14:39:34 -0500 Original-Received: (qmail 65084 invoked by uid 3782); 25 Nov 2018 19:39:33 -0000 Original-Received: from acm.muc.de (p2E5D5C08.dip0.t-ipconnect.de [46.93.92.8]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 25 Nov 2018 20:39:30 +0100 Original-Received: (qmail 20854 invoked by uid 1000); 25 Nov 2018 19:36:15 -0000 Content-Disposition: inline In-Reply-To: <20181125182330.GG27152@ACM> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231365 Archived-At: Hello again, Eli. On Sun, Nov 25, 2018 at 18:23:30 +0000, Alan Mackenzie wrote: > On Sun, Nov 25, 2018 at 20:15:30 +0200, Eli Zaretskii wrote: > > > Date: Sun, 25 Nov 2018 17:59:29 +0000 > > > From: Alan Mackenzie > > > Cc: cpitclaudel@gmail.com, charles@aurox.ch, michael_heerdegen@web.de, > > > emacs-devel@gnu.org, schwab@linux-m68k.org, monnier@IRO.UMontreal.CA [ .... ] > > As I said, I'd be very surprised if using DEFVAR_BOOL would slow down > > what you did in any significant way, beyond the slowdown due to the > > comparison and struct member access. > I'll time it, then we'll know. [ .... ] > > > I'm still a little confused as to what a DEFVAR_BOOL is. > > It's a C 'bool'. Look at defvar_bool the function: its last argument > > is a pointer to the C counterpart of a DEFVAR_BOOL. > > You can also use ptype in the debugger to see what it really is, if > > you want to be absolutely sure. > OK, thanks for the explanation. I'll change the declaration of that > variable (and another one) to DEFVAR_BOOL, and tidy up lisp.h to match. > Then I'll time the resulting Emacs again. :-) DONE. The resulting Emacs with DEFVAR_BOOL took just the same amount of time to bootstrap as the same code with DEFVAR_LISP, to within measurement error. So, I'll commit the version with the DEFVAR_BOOLs. > -- > Alan Mackenzie (Nuremberg, Germany).