From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstraps. Date: Sun, 25 Nov 2018 15:42:03 +0000 Message-ID: <20181125154203.GB27152@ACM> References: <20181117124534.GA8831@ACM> <83muq7u9rk.fsf@gnu.org> <20181123130904.GA2916@ACM> <20181125143125.GA27152@ACM> <87y39h6vie.fsf@igel.home> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1543160607 17079 195.159.176.226 (25 Nov 2018 15:43:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 25 Nov 2018 15:43:27 +0000 (UTC) User-Agent: Mutt/1.10.1 (2018-07-13) Cc: cpitclaudel@gmail.com, "Charles A. Roelli" , michael_heerdegen@web.de, emacs-devel@gnu.org, monnier@IRO.UMontreal.CA, eliz@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 25 16:43:22 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQwZ8-0004IR-8z for ged-emacs-devel@m.gmane.org; Sun, 25 Nov 2018 16:43:22 +0100 Original-Received: from localhost ([::1]:60261 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQwbE-00059D-Qi for ged-emacs-devel@m.gmane.org; Sun, 25 Nov 2018 10:45:32 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46593) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQwb7-000595-8L for emacs-devel@gnu.org; Sun, 25 Nov 2018 10:45:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gQwb4-0001qF-4A for emacs-devel@gnu.org; Sun, 25 Nov 2018 10:45:25 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:14604 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1gQwb3-0001po-Q6 for emacs-devel@gnu.org; Sun, 25 Nov 2018 10:45:22 -0500 Original-Received: (qmail 94856 invoked by uid 3782); 25 Nov 2018 15:45:20 -0000 Original-Received: from acm.muc.de (p2E5D5C08.dip0.t-ipconnect.de [46.93.92.8]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 25 Nov 2018 16:45:19 +0100 Original-Received: (qmail 27494 invoked by uid 1000); 25 Nov 2018 15:42:03 -0000 Content-Disposition: inline In-Reply-To: <87y39h6vie.fsf@igel.home> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231339 Archived-At: Hello, Andreas. On Sun, Nov 25, 2018 at 16:12:57 +0100, Andreas Schwab wrote: > On Nov 25 2018, Alan Mackenzie wrote: > > diff --git a/src/lisp.h b/src/lisp.h > > index 4dfd065629..802c9e4259 100644 > > --- a/src/lisp.h > > +++ b/src/lisp.h > > @@ -395,7 +395,7 @@ typedef EMACS_INT Lisp_Word; > > > > /* verify (NIL_IS_ZERO) */ > > #define lisp_h_EQ(x, y) ((XLI ((x)) == XLI ((y))) \ > > - || (Vsymbols_with_pos_enabled \ > > + || (XLI (Vsymbols_with_pos_enabled) \ > You should make that a DEFVAR_BOOL. I'm not sure. If I understand correctly, DEFVAR_BOOLS are bitfields in integers, and they are slow to unpack and test. Or am I wrong, here? Even if it's not the case now, it might be in the future. The idea behind symbols-with-pos-enabled is that it will be a 32/64 bit integer permanently in cache, hence can be tested for zero/non-zero rapidly. Even so, the mechanism has slowed Emacs down by seven or eight per cent. > Andreas. > -- > Andreas Schwab, schwab@linux-m68k.org > GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 > "And now for something completely different." -- Alan Mackenzie (Nuremberg, Germany).