From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#33452: Color of tooltip text on macOS with dark mode Date: Fri, 23 Nov 2018 20:38:51 +0000 Message-ID: <20181123203851.GA25177@breton.holly.idiocy.org> References: <20181121.163056.945274585923720498.tkk@misasa.okayama-u.ac.jp> <8336ruixqg.fsf@gnu.org> <20181121.191435.1741777328559031241.tkk@misasa.okayama-u.ac.jp> <831s7eiuvp.fsf@gnu.org> <20181121194458.GA3180@breton.holly.idiocy.org> <83va4of5ni.fsf@gnu.org> <20181123181049.GA24527@breton.holly.idiocy.org> <83o9afft6z.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1543005487 17836 195.159.176.226 (23 Nov 2018 20:38:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 23 Nov 2018 20:38:07 +0000 (UTC) User-Agent: Mutt/1.10.1 (2018-07-13) Cc: tkk@misasa.okayama-u.ac.jp, 33452@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 23 21:38:02 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQIDC-0004U4-5u for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Nov 2018 21:38:02 +0100 Original-Received: from localhost ([::1]:54221 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQIFI-0008Bv-JY for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Nov 2018 15:40:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQIFC-0008Bn-1B for bug-gnu-emacs@gnu.org; Fri, 23 Nov 2018 15:40:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gQIF8-00074m-4R for bug-gnu-emacs@gnu.org; Fri, 23 Nov 2018 15:40:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40345) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gQIF8-00074i-0r for bug-gnu-emacs@gnu.org; Fri, 23 Nov 2018 15:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gQIF7-0007zX-U9 for bug-gnu-emacs@gnu.org; Fri, 23 Nov 2018 15:40:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Nov 2018 20:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33452-submit@debbugs.gnu.org id=B33452.154300554230639 (code B ref 33452); Fri, 23 Nov 2018 20:40:01 +0000 Original-Received: (at 33452) by debbugs.gnu.org; 23 Nov 2018 20:39:02 +0000 Original-Received: from localhost ([127.0.0.1]:44603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQIEA-0007y7-9I for submit@debbugs.gnu.org; Fri, 23 Nov 2018 15:39:02 -0500 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:33324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQIE8-0007xY-E2 for 33452@debbugs.gnu.org; Fri, 23 Nov 2018 15:39:00 -0500 Original-Received: by mail-wm1-f50.google.com with SMTP id 79so12321761wmo.0 for <33452@debbugs.gnu.org>; Fri, 23 Nov 2018 12:39:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=IY3tnwsEZUbZ4H4GJtBijYWN+g+ZS/5ugUVpHbMpgiI=; b=b0VhMNhW3A8/qJffJLTr9RpuT8YFSausw0Zkb030dCgj95LXBg6gMPIpIJLoF4bGlk 3JShyrwMaRBUIqbSdBcmq6ydw0t7ysQsnANtLd3haZ6IzLtrA5iFSbDNS0GDaPSoFxVu Tlo1j+RLlJkrJDtY86gxXl+zWhTgVO0B0Znssda/EhrmXZQvBNw5m+v/02esno78ewb+ 7/vbw/QVK1wKCSBrBN1K+0sheSviEzOQXK2rMXWiZjADw02Jmu5SMQ+F7sE9nISET2t1 2rI30KeOm6LHtF+6ZgSDR5eHczp9TNiMMJBoDRghvUUL+4isAqlrCqD3AoeHKtLyjnis JJWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=IY3tnwsEZUbZ4H4GJtBijYWN+g+ZS/5ugUVpHbMpgiI=; b=RehiqqXMjwZjALiRvdmHxZzFHD2DJYSSU73wZX9Nb9uTe0UFE1gnO0uoRJryN9tzF8 2PoEitIe63LNiGhEVhjzRoHA94v2+0+qdb4gZ5oCEWTQbUcICtsXt5f6O+35lTGbNL0S tuvdeOWhmsCR8+KAbxEzCxxnyf5eyDqnDTXDlf9JPBwqS2nciEno1zzRJ8SWbC1kkJIg CelU8U9qMro2EZjBovSsw8v2nBWkxr/POU2Kp67LIPWAbD5HjzmmD1uEKIx/CgNQAJ33 pd2xOgnSF3Dtuk3wUCq4QsKmI3l2uYLPL9FWiQW/xHOzaK3RlJ+vZQ+lPZg+P0f8gtfk pJjQ== X-Gm-Message-State: AA+aEWbHrCZc757Xtl6UQg5Ku9S/T1+a2GeRBpFuwA3f2PZoDatnRs85 6okXDbFeHE6jYEJuJ33wkLo= X-Google-Smtp-Source: AJdET5evSU8k734fKtHIZopVkju9TMVjH1lnlxAL0dJl//ICPRxcSPjnk0Yko+tCcILAp9Vc/RkKCQ== X-Received: by 2002:a1c:410b:: with SMTP id o11mr15285475wma.109.1543005534365; Fri, 23 Nov 2018 12:38:54 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-dce1-f8e2-3065-9b77.holly.idiocy.org. [2001:8b0:3f8:8129:dce1:f8e2:3065:9b77]) by smtp.gmail.com with ESMTPSA id t5sm11936875wmd.15.2018.11.23.12.38.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Nov 2018 12:38:53 -0800 (PST) Content-Disposition: inline In-Reply-To: <83o9afft6z.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152723 Archived-At: On Fri, Nov 23, 2018 at 10:13:40PM +0200, Eli Zaretskii wrote: > > Date: Fri, 23 Nov 2018 18:10:49 +0000 > > From: Alan Third > > Cc: tkk@misasa.okayama-u.ac.jp, 33452@debbugs.gnu.org > > > > > Are you saying that tooltips on NS couldn't use colors before that > > > change? Or was that color support broken at some point? If the > > > latter, when was it broken and by what changeset? > > > > Tooltips on NS couldn’t use colours before that change. > > > > What happened is that tooltips set the background to yellow and left > > the foreground (text) to be the system default (black). > > > > MacOS Mojave has introduced ‘dark mode’, which makes the foreground > > colour light, and therefore we’re seeing light text on a yellow > > background. > > > > If you don’t want to apply the above commit the absolute minimum fix > > for emacs-26 would be to explicitly set a foreground colour for > > tooltips, or not set the background, therefore reverting to the system > > default. > > Sorry, I'm confused: does "system default" mean the tooltips will be > without colors, or does it mean they will use the system colors? If > the latter, then why did you say in the beginning that "tooltips on NS > couldn't use colors"? Sorry, I thought you were meaning colours as set by Emacs lisp. We can set the foreground and background to anything we want in C, but in emacs-26 currently we can’t modify them by Emacs lisp, and only the background colour is being set in C, which leaves the foreground to use whatever the system default is. The master branch honours the colours set by lisp. A little more background, which hopefully won’t confuse things more: NS tooltips are very basic, whoever wrote the tooltips for Emacs under NS decided to use a full toolkit window instead, and just colour it like the default Emacs tooltips on X. Except they only did half the job, which wasn’t a problem until Apple decided to change the default colours. -- Alan Third