From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Thoughts on getting correct line numbers in the byte compiler's warning messages Date: Mon, 12 Nov 2018 21:35:13 +0000 Message-ID: <20181112213513.GD4459@ACM> References: <20181106151143.GB4030@ACM> <20181107170036.GA4934@ACM> <20181107184708.GB4934@ACM> <20181108140843.GB5041@ACM> <20181112154448.GB4459@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1542058507 31258 195.159.176.226 (12 Nov 2018 21:35:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 12 Nov 2018 21:35:07 +0000 (UTC) User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Michael Heerdegen , Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 12 22:35:03 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gMJrJ-0007uP-6p for ged-emacs-devel@m.gmane.org; Mon, 12 Nov 2018 22:35:01 +0100 Original-Received: from localhost ([::1]:50755 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMJtP-0001OQ-DS for ged-emacs-devel@m.gmane.org; Mon, 12 Nov 2018 16:37:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMJtF-0001Ls-Dj for emacs-devel@gnu.org; Mon, 12 Nov 2018 16:37:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gMJt9-0007bZ-FU for emacs-devel@gnu.org; Mon, 12 Nov 2018 16:36:59 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:47726 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1gMJt9-0007a7-77 for emacs-devel@gnu.org; Mon, 12 Nov 2018 16:36:55 -0500 Original-Received: (qmail 86597 invoked by uid 3782); 12 Nov 2018 21:36:53 -0000 Original-Received: from acm.muc.de (p5B147649.dip0.t-ipconnect.de [91.20.118.73]) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 12 Nov 2018 22:36:52 +0100 Original-Received: (qmail 12574 invoked by uid 1000); 12 Nov 2018 21:35:13 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231104 Archived-At: Hello, Stefan. On Mon, Nov 12, 2018 at 15:36:14 -0500, Stefan Monnier wrote: > > Unfortunately, this isn't going to work. There will be macros which do > > things like: > > > > (cond ((eq (car form) 'bar) ....) .....) > > > > Here, (car form) is going to be #, so the eq is going > > to return nil. > [...] > > This isn't pretty. If this modification of eq, memq, .... is too much > > to take, then I think the current approach is doomed to failure. > It's indeed a serious concern. Maybe we can circumvent by changing > those pieces of code to use `eql` (and make sure `eql` consider > a symbol and its symbol-with-pos as equal, obviously). We can't change those bits of code - they're in macros that we don't necessarily control. Or are you suggesting that we somehow compile macros such that `eq' gets replaced by `eql' in the critical places? > Changing `eq` would better be avoided, I agree, but don't see how we can avoid it. Apologies for my earlier insistence that the approach would have little impact outside the byte compiler. > Stefan -- Alan Mackenzie (Nuremberg, Germany).