From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Michael Heerdegen <michael_heerdegen@web.de>,
Eli Zaretskii <eliz@gnu.org>,
emacs-devel@gnu.org
Subject: Re: Thoughts on getting correct line numbers in the byte compiler's warning messages
Date: Mon, 12 Nov 2018 21:35:13 +0000 [thread overview]
Message-ID: <20181112213513.GD4459@ACM> (raw)
In-Reply-To: <jwv8t1y3ujn.fsf-monnier+emacs@gnu.org>
Hello, Stefan.
On Mon, Nov 12, 2018 at 15:36:14 -0500, Stefan Monnier wrote:
> > Unfortunately, this isn't going to work. There will be macros which do
> > things like:
> >
> > (cond ((eq (car form) 'bar) ....) .....)
> >
> > Here, (car form) is going to be #<symbol bar at 42>, so the eq is going
> > to return nil.
> [...]
> > This isn't pretty. If this modification of eq, memq, .... is too much
> > to take, then I think the current approach is doomed to failure.
> It's indeed a serious concern. Maybe we can circumvent by changing
> those pieces of code to use `eql` (and make sure `eql` consider
> a symbol and its symbol-with-pos as equal, obviously).
We can't change those bits of code - they're in macros that we don't
necessarily control. Or are you suggesting that we somehow compile
macros such that `eq' gets replaced by `eql' in the critical places?
> Changing `eq` would better be avoided,
I agree, but don't see how we can avoid it.
Apologies for my earlier insistence that the approach would have little
impact outside the byte compiler.
> Stefan
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2018-11-12 21:35 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 17:59 Thoughts on getting correct line numbers in the byte compiler's warning messages Alan Mackenzie
2018-11-01 22:45 ` Stefan Monnier
2018-11-05 10:53 ` Alan Mackenzie
2018-11-05 15:57 ` Eli Zaretskii
2018-11-05 16:51 ` Alan Mackenzie
2018-11-06 4:34 ` Herring, Davis
2018-11-06 8:53 ` Alan Mackenzie
2018-11-06 13:56 ` Stefan Monnier
2018-11-06 15:11 ` Alan Mackenzie
2018-11-06 16:29 ` Stefan Monnier
2018-11-06 19:15 ` Alan Mackenzie
2018-11-06 20:04 ` Stefan Monnier
2018-11-07 12:35 ` Alan Mackenzie
2018-11-07 17:11 ` Stefan Monnier
2018-11-07 17:00 ` Alan Mackenzie
2018-11-07 17:25 ` Stefan Monnier
2018-11-07 18:47 ` Alan Mackenzie
2018-11-07 19:12 ` Stefan Monnier
2018-11-08 14:08 ` Alan Mackenzie
2018-11-08 17:02 ` Stefan Monnier
2018-11-08 22:13 ` Alan Mackenzie
2018-11-11 12:59 ` Alan Mackenzie
2018-11-11 15:53 ` Eli Zaretskii
2018-11-11 20:12 ` Alan Mackenzie
2018-11-11 20:47 ` Stefan Monnier
2018-11-12 3:30 ` Eli Zaretskii
2018-11-12 16:19 ` Eli Zaretskii
2018-11-12 14:16 ` Alan Mackenzie
2018-11-12 15:44 ` Alan Mackenzie
2018-11-12 20:36 ` Stefan Monnier
2018-11-12 21:35 ` Alan Mackenzie [this message]
2018-11-14 13:34 ` Stefan Monnier
2018-11-15 16:32 ` Alan Mackenzie
2018-11-15 18:01 ` Stefan Monnier
2018-11-16 14:14 ` Alan Mackenzie
2018-11-08 4:47 ` Michael Heerdegen
2018-11-08 11:07 ` Alan Mackenzie
2018-11-09 2:06 ` Michael Heerdegen
2018-11-10 10:59 ` Alan Mackenzie
2018-11-10 13:20 ` Stefan Monnier
2018-11-11 7:56 ` Michael Heerdegen
2018-11-08 13:45 ` Stefan Monnier
2018-11-09 3:06 ` Michael Heerdegen
2018-11-09 16:15 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181112213513.GD4459@ACM \
--to=acm@muc.de \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=michael_heerdegen@web.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.