From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Thoughts on getting correct line numbers in the byte compiler's warning messages Date: Mon, 12 Nov 2018 14:16:32 +0000 Message-ID: <20181112141632.GA4459@ACM> References: <20181107170036.GA4934@ACM> <20181107184708.GB4934@ACM> <20181108140843.GB5041@ACM> <20181108221311.GD5041@ACM> <20181111125945.GA6487@ACM> <83k1lja9w6.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1542032255 22055 195.159.176.226 (12 Nov 2018 14:17:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 12 Nov 2018 14:17:35 +0000 (UTC) User-Agent: Mutt/1.10.1 (2018-07-13) Cc: michael_heerdegen@web.de, monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 12 15:17:30 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gMD1q-0005XK-Hx for ged-emacs-devel@m.gmane.org; Mon, 12 Nov 2018 15:17:26 +0100 Original-Received: from localhost ([::1]:48888 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMD3w-0003Te-Pv for ged-emacs-devel@m.gmane.org; Mon, 12 Nov 2018 09:19:36 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35233) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMD2r-0003OY-4Z for emacs-devel@gnu.org; Mon, 12 Nov 2018 09:18:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gMD2e-0003li-Vw for emacs-devel@gnu.org; Mon, 12 Nov 2018 09:18:25 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:33520 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1gMD2e-0003kk-FI for emacs-devel@gnu.org; Mon, 12 Nov 2018 09:18:16 -0500 Original-Received: (qmail 67201 invoked by uid 3782); 12 Nov 2018 14:18:14 -0000 Original-Received: from acm.muc.de (p5B147649.dip0.t-ipconnect.de [91.20.118.73]) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 12 Nov 2018 15:18:12 +0100 Original-Received: (qmail 9969 invoked by uid 1000); 12 Nov 2018 14:16:32 -0000 Content-Disposition: inline In-Reply-To: <83k1lja9w6.fsf@gnu.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231093 Archived-At: Hello, Eli. On Sun, Nov 11, 2018 at 17:53:13 +0200, Eli Zaretskii wrote: > > Date: Sun, 11 Nov 2018 12:59:45 +0000 > > From: Alan Mackenzie > > Cc: Michael Heerdegen , emacs-devel@gnu.org > > > > I've now got this working, and created the new, optimistically named, > > branch /scratch/accurate-warning-pos. > Thanks. > +/* Return a new located symbol with the specified SYMBOL and LOCATION. */ > +Lisp_Object > +build_located_symbol (Lisp_Object symbol, Lisp_Object location) > +{ > I'd prefer something like symbol_with_pos instead, and accordingly in > other related symbol names. DONE. > +DEFUN ("only-symbol-p", Fonly_symbol_p, Sonly_symbol_p, 1, 1, 0, > + doc: /* Return t if OBJECT is a symbol, but not a located symbol. */ > + attributes: const) > + (Lisp_Object object) > symbol-bare-p? DONE. (bare-symbol-p) [ .... ] > diff --git a/src/lisp.h b/src/lisp.h > index eb67626..b4fc6f2 100644 > --- a/src/lisp.h > +++ b/src/lisp.h > @@ -323,6 +323,64 @@ typedef union Lisp_X *Lisp_Word; > typedef EMACS_INT Lisp_Word; > #endif > +/* A Lisp_Object is a tagged pointer or integer. Ordinarily it is a > + Lisp_Word. However, if CHECK_LISP_OBJECT_TYPE, it is a wrapper > + around Lisp_Word, to help catch thinkos like 'Lisp_Object x = 0;'. > + > + LISP_INITIALLY (W) initializes a Lisp object with a tagged value > + that is a Lisp_Word W. It can be used in a static initializer. */ > Looks like you moved a large chunk of lisp.h to a different place in > the file. Any reasons for that? I've now moved all but a few inline functions back again. > +/* FIXME!!! 2018-11-09. Consider using lisp_h_PSEUDOVECTOR here. */ > What is this FIXME about? It's gone, the issue having been resolved. > This needs support in src/.gdbinit and documentation. Not yet done. > Thanks again for working in this. -- Alan Mackenzie (Nuremberg, Germany).