From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#32932: 27.0.50; render bugs on macOS Mojave Date: Thu, 8 Nov 2018 23:23:49 +0000 Message-ID: <20181108232349.GB15030@breton.holly.idiocy.org> References: <20181104132404.GA58336@breton.holly.idiocy.org> <20181104201148.GA70884@breton.holly.idiocy.org> <20181105185516.GA71125@breton.holly.idiocy.org> <20181108152117.GA98842@breton.holly.idiocy.org> <83va57bmzq.fsf@gnu.org> <20181108161715.GA99392@breton.holly.idiocy.org> <83tvkrbjhi.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1541719328 25765 195.159.176.226 (8 Nov 2018 23:22:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 8 Nov 2018 23:22:08 +0000 (UTC) User-Agent: Mutt/1.10.1 (2018-07-13) Cc: boris@d12frosted.io, 32932@debbugs.gnu.org, aaronjensen@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 09 00:22:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKtci-0006Z9-1x for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Nov 2018 00:22:04 +0100 Original-Received: from localhost ([::1]:59454 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKteo-00039q-81 for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Nov 2018 18:24:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKteh-00039k-Mt for bug-gnu-emacs@gnu.org; Thu, 08 Nov 2018 18:24:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKted-0007BD-NT for bug-gnu-emacs@gnu.org; Thu, 08 Nov 2018 18:24:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37750) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gKted-0007Ap-C8 for bug-gnu-emacs@gnu.org; Thu, 08 Nov 2018 18:24:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gKtec-0005Lk-0n for bug-gnu-emacs@gnu.org; Thu, 08 Nov 2018 18:24:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Nov 2018 23:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32932 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32932-submit@debbugs.gnu.org id=B32932.154171944020555 (code B ref 32932); Thu, 08 Nov 2018 23:24:01 +0000 Original-Received: (at 32932) by debbugs.gnu.org; 8 Nov 2018 23:24:00 +0000 Original-Received: from localhost ([127.0.0.1]:42008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKtea-0005LS-Fv for submit@debbugs.gnu.org; Thu, 08 Nov 2018 18:24:00 -0500 Original-Received: from mail-wm1-f49.google.com ([209.85.128.49]:38191) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKteY-0005LF-CA for 32932@debbugs.gnu.org; Thu, 08 Nov 2018 18:23:58 -0500 Original-Received: by mail-wm1-f49.google.com with SMTP id f2-v6so335665wme.3 for <32932@debbugs.gnu.org>; Thu, 08 Nov 2018 15:23:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=T+IPKhY6xm5VeImzmXle6fDzUNBpwOcq3/3A2YVPZYU=; b=Er68D/mw5uq1EYMPRKcJDS3sKrHvagm3V4pOtDoBn4Ax5Mdaosv6yl1zNmOvtjTVM4 VNpu+HfvpLgG0wxzLk8NP5m5How3yYHG9H8MwLGcixW4gAYufyTGQdDzvY7G8Qs5AR5G PqcWfI7gyoDU06XKSgFvaLgMTfSebsDWp5H4xVpF8/WqN1EvK9SMtW6VLFH/Xrrin4fr 0KUohW2qL4ML03lAoK6OgEoga2JLAcE0b5V8YP94QvXyB/w36YcUIHD1LNhYWwVQDoar icDLGPpmNQ6vUyz3aEdTIYZK68WYfrzbcUzMEqY/aSS+l2BskUzKgLn13DI5k2XSDD0p hfRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=T+IPKhY6xm5VeImzmXle6fDzUNBpwOcq3/3A2YVPZYU=; b=WLN4Cv49EyUV4cihc9xQquVo/o2RA22MB/b8QrmJfL4EpnUBdLJJPLRJowx9Xiqvdz GYngRLZGa20ruIcB33nG8mQCX8AVIe1k0pnIDKNkX8j9gHLoKjcwj0wXeCdbnawbEPwc jnlkcoUdA6gCnvB87NfyhfKzn15N3ZEKFFP3QN22z9Btk3bAKvI5HPmgU+lXBMY4wl53 pG2JJc9qg2NIKIEeDgUaQkmCmjgFxL8klldgz/mE4xITTjVIP8Fhu2lzm59vjVQQzseN VnzR5pOD9ZaJUxsRwXoiRKS3P4LHBV25PHeknbpL+UH0h6xNGeQtCiEhjIFtvKVrqI62 n9gg== X-Gm-Message-State: AGRZ1gLaiupgj+qqSp8BUlx0uq6rKvCH0oIF8EROJzItL6v4E00C7nBG 0e24S+or2remwWDqgOEAa0s= X-Google-Smtp-Source: AJdET5ciPIy0Ch9s8pVAnka7cbd4WqB9j6AC5qrXIaM+GEKZI/oVMDBBp0kJ2hpvAj5bsqc1eKeh1A== X-Received: by 2002:a1c:ccb:: with SMTP id 194-v6mr2983422wmm.102.1541719432608; Thu, 08 Nov 2018 15:23:52 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-8cfe-35d9-62a3-d426.holly.idiocy.org. [2001:8b0:3f8:8129:8cfe:35d9:62a3:d426]) by smtp.gmail.com with ESMTPSA id y13-v6sm6269692wrq.13.2018.11.08.15.23.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Nov 2018 15:23:51 -0800 (PST) Content-Disposition: inline In-Reply-To: <83tvkrbjhi.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152184 Archived-At: On Thu, Nov 08, 2018 at 06:51:37PM +0200, Eli Zaretskii wrote: > > Date: Thu, 8 Nov 2018 16:17:15 +0000 > > From: Alan Third > > Cc: aaronjensen@gmail.com, 32932@debbugs.gnu.org, boris@d12frosted.io > > > > > What exactly do you mean by WHENEVER REQUESTED? As opposed to what > > > alternative? > > > > At the moment expose_frame doesn’t draw anything if the frame or > > window has been marked as garbaged > > AFAIR, that's a mere optimization, so if you want expose_frame to go > ahead and redraw on NS regardless of the frame's garbaged flag, it's > fine with me. > > > (there may be other circumstances too). > > The only other case is when the frame's face cache is empty, in which > case you won't be able to draw anything anyway. > > There's a no-op return in expose_window, but I think its condition > cannot happen nowadays, it's a relic from when expose_frame could be > entered asynchronously from a signal handler. It may be worth keeping it for now as I’m unsure what will happen when I finally get round to splitting the NS and lisp code into separate threads (I had a go at it before and it was largely successful, but there were a lot of graphical issues that caused crashes). > > If expose_frame could draw the rectangle as it was before the > > frame/window was marked garbaged, that would also solve the problem. > > Not sure what this means: you can only draw what's in the glyph > matrices, what was there before the garbaged flag was set is gone for > good. That’s exactly what I meant. Thanks. -- Alan Third