all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ota, Takaaki" <Takaaki.Ota@sony.com>
To: 33197@debbugs.gnu.org
Subject: bug#33197: 26.1; cc-mode enum indentation
Date: Mon, 29 Oct 2018 14:03:58 -0700	[thread overview]
Message-ID: <20181029.140358.335851305.Takaaki.Ota@sony.com> (raw)

The enum indentation in cc-mode used to look like this.

	  enum {
	    pDlen = sizeof pD - 1,
	    pIlen = sizeof pI - 1,
	    pMlen = sizeof pMd - 2
	  };
	  enum {
	    no_modifier, long_modifier, pD_modifier, pI_modifier, pM_modifier
	  } length_modifier = no_modifier;

This is a portion of doprnt.c in the current 26.1 source code.  But
now the 26.1 cc-mode indents like this

	  enum {
                pDlen = sizeof pD - 1,
                pIlen = sizeof pI - 1,
                pMlen = sizeof pMd - 2
	  };
	  enum {
                no_modifier, long_modifier, pD_modifier, pI_modifier, pM_modifier
	  } length_modifier = no_modifier;

If the enum has a long name before the open brace it looks even worse
by wasting a lot of unnecessary spaces.

	  enum some_long_enum_type_name {
                                         pDlen = sizeof pD - 1,
                                         pIlen = sizeof pI - 1,
                                         pMlen = sizeof pMd - 2
	  };
	  enum another_long_enum_type_name {
                                            no_modifier, long_modifier, pD_modifier, pI_modifier, pM_modifier
	  } length_modifier = no_modifier;

Please consider bringing it back to how it used to be.

-Tak





             reply	other threads:[~2018-10-29 21:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-29 21:03 Ota, Takaaki [this message]
2020-11-26 13:00 ` bug#33197: 26.1; cc-mode enum indentation Lars Ingebrigtsen
2020-11-26 13:14   ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181029.140358.335851305.Takaaki.Ota@sony.com \
    --to=takaaki.ota@sony.com \
    --cc=33197@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.