From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#33126: 26.1; xpm2 broken in MacOSX Date: Thu, 25 Oct 2018 11:04:52 +0100 Message-ID: <20181025100452.GA45995@breton.holly.idiocy.org> References: <20181024111736.GC40431@breton.holly.idiocy.org> <83efcfs7tm.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="T4sUOijqQbZv57TR" Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1540462212 25794 195.159.176.226 (25 Oct 2018 10:10:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 25 Oct 2018 10:10:12 +0000 (UTC) User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Emacs-Hacker2018@jovi.net, 33126@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 25 12:10:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFcad-0006ao-92 for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Oct 2018 12:10:07 +0200 Original-Received: from localhost ([::1]:53546 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFccj-00086h-QD for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Oct 2018 06:12:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFcaA-0006Us-JZ for bug-gnu-emacs@gnu.org; Thu, 25 Oct 2018 06:09:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gFcWj-0006k6-Uc for bug-gnu-emacs@gnu.org; Thu, 25 Oct 2018 06:06:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36962) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gFcWh-0006hX-UX for bug-gnu-emacs@gnu.org; Thu, 25 Oct 2018 06:06:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gFcWf-0004Fw-VL for bug-gnu-emacs@gnu.org; Thu, 25 Oct 2018 06:06:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Oct 2018 10:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33126 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33126-submit@debbugs.gnu.org id=B33126.154046190616297 (code B ref 33126); Thu, 25 Oct 2018 10:06:01 +0000 Original-Received: (at 33126) by debbugs.gnu.org; 25 Oct 2018 10:05:06 +0000 Original-Received: from localhost ([127.0.0.1]:41220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFcVl-0004Em-9e for submit@debbugs.gnu.org; Thu, 25 Oct 2018 06:05:05 -0400 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:35628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFcVi-0004EB-CC for 33126@debbugs.gnu.org; Thu, 25 Oct 2018 06:05:02 -0400 Original-Received: by mail-wm1-f50.google.com with SMTP id w186-v6so886513wmf.0 for <33126@debbugs.gnu.org>; Thu, 25 Oct 2018 03:05:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=nLO9EcrWi8eyDJxw90+7BTGWG4iwWJpWjeTFBBXh8Ic=; b=nwkABoh1D+GrrKeJ/mn+soJj/zVfGNMQ87Yl8GQWaTD6jmROb4dpMZZ87gTnCGCSf4 ZZwXC8qNfD9AhQCkBK4mFlHHY/kj1qL5tFaDTj1clpzq0by8Tk5MbyhZ7HfpqYP4HFG1 nHV5dItJ5EsY4jxIsQ0nE82vle5psP8nlSb5rQX9A5c1VhYeki5l6IZ9E2V2PVnJlnHn oaP3vGWLvifhi1AxBOBq1iikEPBAhwf9v9v9WPSQl/JFHfPJIPo2h3/vGdy5O7KQTYFK bt+HNllOKG8cAwBCzwFpLbZA3u+T3E2IQSuw550MQ/y/+ArpDgf7XDWavCuaJxzKmVvZ /UcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=nLO9EcrWi8eyDJxw90+7BTGWG4iwWJpWjeTFBBXh8Ic=; b=p/5uryZruyGYZ3fKZIRbMSB3d3bDtg/Giy7Ape06ILuPeAINeopsULnGnSqlHOtq4x 27+Q1Vbp4iX4IRgplEr/tQlrqDFmlJImLh2GEoQpaIDWR+ZQDLrI0SIfIeZikLhKqtOk X/Tp0u+1A4bTuX0hdxm57jbzGeEypbEb3f2zPeOI8VMvIM2SSBbEwkTxu34l3iKei4dB /ofTnAUvUYl2VaY/YMTNtGoxAxAZTOGqmBI4v/cI6Y3UNlmqkthc2Q+uCnmyGLhVlHTe eVd+AHzRIrtm4PCSuolru/nIH8C0w/flC8HeyNsUT2oxzoiYm3KgWcvR15ry2I3El2Fg pJ7Q== X-Gm-Message-State: AGRZ1gJrbl3Jfr8yk9vz7w5iPdgCYwX48ciF/uJSpyNlwTJnC7lhTzQY uRry+CIjXpvZTQGO9ME19aE= X-Google-Smtp-Source: AJdET5etO+qek2ZOy3Y0L9F5dbZZt8GYNviNF9TXff5ng+NXr9iX3KNa4NXWBSaRjf23RUecTD30iQ== X-Received: by 2002:a1c:540d:: with SMTP id i13-v6mr1176758wmb.149.1540461896049; Thu, 25 Oct 2018 03:04:56 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-a9a7-73e3-89ce-d96b.holly.idiocy.org. [2001:8b0:3f8:8129:a9a7:73e3:89ce:d96b]) by smtp.gmail.com with ESMTPSA id l67-v6sm1996888wma.20.2018.10.25.03.04.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Oct 2018 03:04:54 -0700 (PDT) Content-Disposition: inline In-Reply-To: <83efcfs7tm.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151592 Archived-At: --T4sUOijqQbZv57TR Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Wed, Oct 24, 2018 at 06:06:13PM +0300, Eli Zaretskii wrote: > > Date: Wed, 24 Oct 2018 12:17:36 +0100 > > From: Alan Third > > Cc: 33126@debbugs.gnu.org > > > > Confirmed. I found this in image.c: > > > > /* XPM support functions for NS where libxpm is not available. > > Only XPM version 3 (without any extensions) is supported. */ > > > > I suppose to get xpm2 support you’ll have to find a version of libxpm > > somewhere. > > > > There is an error logged in *Messages*, perhaps it should specify XPM3 > > per the attached patch. > > Yes. In addition, I'd add an entry about this in PROBLEMS. Done. I created a subsection for macOS, although I’m not sure if this is actually a macOS specific issue, or general to systems lacking X11 libraries (MS Windows?). -- Alan Third --T4sUOijqQbZv57TR Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-Improve-XPM-load-failure-message-bug-33126.patch" >From d0ecdda6b173d125547bd2efca347279c70f6eda Mon Sep 17 00:00:00 2001 From: Alan Third Date: Wed, 24 Oct 2018 12:15:16 +0100 Subject: [PATCH] Improve XPM load failure message (bug#33126) * src/image.c (xpm_load_image): Only XPM3 is supported, so make that explicit. --- etc/PROBLEMS | 7 +++++++ src/image.c | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/etc/PROBLEMS b/etc/PROBLEMS index 7dfafe04de..45370512ca 100644 --- a/etc/PROBLEMS +++ b/etc/PROBLEMS @@ -2616,6 +2616,13 @@ please call support for your X-server and see if you can get a fix. If you do, please send it to bug-gnu-emacs@gnu.org so we can list it here. +* Runtime problems specific to macOS + +** macOS doesn't come with libxmp, so only XPM3 is supported. + +Libxpm is available for macOS as part of the XQuartz project. + + * Build-time problems ** Configuration diff --git a/src/image.c b/src/image.c index 767979e63b..a6b2d9060b 100644 --- a/src/image.c +++ b/src/image.c @@ -4308,7 +4308,7 @@ xpm_load_image (struct frame *f, return 1; failure: - image_error ("Invalid XPM file (%s)", img->spec); + image_error ("Invalid XPM3 file (%s)", img->spec); x_destroy_x_image (ximg); x_destroy_x_image (mask_img); x_clear_image (f, img); -- 2.18.0 --T4sUOijqQbZv57TR--